fslint-gui duplicates select - within groups - select all but newest/oldest results in error

[Florian]

The goal is to search for duplicate files and then delete all duplicates except the newest version of the file. This could be done by using fslint-gui - but the selection of the files creates an error.

The error was a regression in 2.44 and seems to be fixed in upstream project: https://github.com/pixelb/fslint/issues/94

1. Click "Find" in first tab "Duplicates"
2. Click "Select" -> "within groups" -> "Select all but newest" - then all files except the newest ones are selected
3. Click "Delete" - the expectation is that the marked files will be deleted

In Step 2 the following error is printed in the console:

Traceback (most recent call last):
  File "/usr/bin/fslint-gui", line 1580, in on_select_all_but_newest_in_each_group_activate
    self.on_select_all_but_one_in_each_group_activate("newest")
  File "/usr/bin/fslint-gui", line 1616, in on_select_all_but_one_in_each_group_activate
    unselect_row = find_row_to_unselect(clist, row, which)
  File "/usr/bin/fslint-gui", line 1602, in find_row_to_unselect
    while get_selectable(row, row_data) and row < clist.rows:
  File "/usr/bin/fslint-gui", line 421, in get_selectable
    return row_data[row][0] != '#'
IndexError: list index out of range

ProblemType: Bug
DistroRelease: Ubuntu 16.04
Package: fslint 2.44-2
ProcVersionSignature: Ubuntu 4.3.0-2.11-generic 4.3.0
Uname: Linux 4.3.0-2-generic x86_64
NonfreeKernelModules: nvidia bbswitch
ApportVersion: 2.19.3-0ubuntu2
Architecture: amd64
CurrentDesktop: XFCE
Date: Mon Dec 28 21:19:11 2015
InstallationDate: Installed on 2015-11-23 (35 days ago)
InstallationMedia: Xubuntu 16.04 LTS "Xenial Xerus" - Alpha amd64 (20151122)
JournalErrors:
 Error: command ['journalctl', '-b', '--priority=warning', '--lines=1000'] failed with exit code 1: Hint: You are currently not seeing messages from other users and the system.
       Users in the 'systemd-journal' group can see all messages. Pass -q to
       turn off this notice.
 No journal files were opened due to insufficient permissions.
PackageArchitecture: all
SourcePackage: fslint
UpgradeStatus: No upgrade log present (probably fresh install)

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Rufus Laggren (rlaggren)]

fslint-gui fails to delete after selecting as above.

Version 2.44-9.1; OpenSuse LEAP 42.1

It _will_ "Save" the selection and that can be used w/a command line to complete the delete operation.

Additionally the display has a glitch where after the above "select..." the current list box displays _all_ entries as selected - which is not correct. Moving the elevator down/up (to look down the list and then return to original view) shows the entries selected correctly as expected.

[Darin (newhoa)]

This was fixed 2 years ago on Github.

https://github.com/pixelb/fslint/issues/112

I'm using the 2.46 release here without any issue:

https://github.com/pixelb/fslint/releases

-----------

The current Ubuntu package (and Debian package) is 3+ years old now and broken. It needs to be removed or updated.

[John Russell (jrussell-88)]

Ubuntu 17.04 I have the same problems. Select with wildcard doesn't work at all, select first works sometimes, manually selecting several files and deleting them - none were deleted. Select and delete one file worked.

After selecting a group ie all bit newest, none of the selections work and I'm stuck with my first selection.

The only one which works is 'within groups' 'Select all but first'. When I then delete the selection, I get some deletions and many [Errno 107] Transport endpoint is not connected.

With all these problems it is pretty much broken.

[Rolf Leggewie (r0lf)]

I backported the fix to Debian just in time for bionic, so closing as fixed. Sorry for the delay. I intend to push 2.46 to ubuntu+1 after bionic is released and the archive reopens.

fslint (2.44-4) unstable; urgency=medium

  * control: use publicly accessible Vcs-Git URI
  * patches:
    - backport r291 from upstream. Closes: #767932
    - backport 9efd7fff from upstream. Closes: #892356
  * watch: include tar.xz in watch

 -- Rolf Leggewie <email address hidden> Tue, 17 Apr 2018 17:16:51 +0800