A note on virtio blk and net modules

Bug #1533382 reported by Dimitri John Ledkov
This bug affects 1 person
Affects Status Importance Assigned to Milestone
debian-installer (Ubuntu)
linux (Ubuntu)
Fix Released
Tim Gardner
Fix Released
Tim Gardner

Bug Description

If VIRTIO_BLK and VIRTIO_NET become =m, instead of current =y the following should happen:

VIRTIO_NET should be in the nic-modules udeb, and seeded into the d-i builds.

VIRTIO_BLK can stay in block-modules-udeb, and in general is not needed in the d-i build, as it can be fetched over the VIRTIO_NET provided network.

VIRTIO_BLK needs to be available (e.g. server udebs pool, for offline s390x installations)

on the kernel side

virtio-blk and virtio-nic most certainly need to be the in the "main" package of a flavor, and not in -extra.

Revision history for this message
Dimitri John Ledkov (xnox) wrote :

<infinity> xnox: Why did you add block-modules to generic/s390x.cfg?
<infinity> xnox: "Add block-modules (depends on virtio-modules) for s390x" seems pointless with the kernel change to make those builtin. I think I'll revert that commit.
<infinity> xnox: Or was there some other reason?
* infinity shrugs and leaves it there for now.
* mwenning has quit (Quit: Leaving)
* foka_ (~foka@198-48-131-98.cpe.pppoe.ca) has joined
<xnox> infinity, so apw wanted to make it a module on all platforms, rather than changing it to =y on s390x.
<xnox> infinity, so i made the change, just in case. The net difference now is adding nbd module to the installer.
<xnox> infinity, i don't know if apw will revert it to a =m everywhere. If he does, we will need block-modules in all/most d-i flavours.
<infinity> xnox: It should still be in virtio-modules anyway (if it's =m), I'd say it's a bug that it was in block-modules.
<infinity> xnox: But this works for now, I won't be too picky (already uploaded your change).
<xnox> ok.
<xnox> infinity, let me point that virtio-blk was in the wrong package to apw. cause we were slightly dilusional about it.
<xnox> infinity, the whole bug was i went to boot cloud images, and virtio-blk was not in the initramfs, and was only in the -extra image....
<infinity> xnox: Err, surely this was about virtio-net anyway?
<xnox> anyway all good now.
<infinity> xnox: virtio-blk shouldn't be needed to boot the installer, it should be fetched over the network.
<xnox> virtio-net and virtio-blk. Both were =m in -extra package and in block/virtio-udebs split
<xnox> and i do need virtio-net and virtio-blk in the cloud-images initramfs.
<xnox> virtio-blk can be fetched over the network true, in the d-i case.
<infinity> Right, moving them to -virtual (either in image or =y) is correct, and yes, you need them in the cloud-init initrd, but that has nothing to do with d-i.
<infinity> So, we probably should revert your change before we forget this conversation. :P
<xnox> right. and apw wants to drop them from =y -> =m everywhere, as otherwise they are always loaded, and never unloaded.
<infinity> And then make sure the kernel debs/udebs are correct if they go =m
<xnox> right.
<xnox> let me copy the irc log into a bug with actions to be done.
<infinity> I'm not convinced virtio-modules needs to exist at all, except maybe as a dep of block-modules and nic-modules, if it has some common bits.
<infinity> virtio-net should be in nic- and virtio-blk should be in block-, the more I think about it.
<infinity> There's nothing about those drivers that make them any more "special" than any other block or nic device.
<xnox> there is virtio-scsi and virtio-something else.
<xnox> in virtio-udebs.
<xnox> but yeah vitio-nic should be in nic-modules

Revision history for this message
Brad Figg (brad-figg) wrote : Missing required logs.

This bug is missing log files that will aid in diagnosing the problem. From a terminal window please run:

apport-collect 1533382

and then change the status of the bug to 'Confirmed'.

If, due to the nature of the issue you have encountered, you are unable to run this command, please add a comment stating that fact and change the bug status to 'Confirmed'.

This change has been made by an automated script, maintained by the Ubuntu Kernel Team.

Changed in linux (Ubuntu):
status: New → Incomplete
Changed in linux (Ubuntu):
importance: Undecided → Medium
tags: added: bot-stop-nagging kernel-da-key
Changed in linux (Ubuntu):
status: Incomplete → Triaged
Revision history for this message
Tim Gardner (timg-tpi) wrote :

set CONFIG_VIRTIO_{NET,BLK}=y and updated annotations.

Changed in linux (Ubuntu Xenial):
assignee: nobody → Tim Gardner (timg-tpi)
status: Triaged → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (17.3 KiB)

This bug was fixed in the package linux - 4.4.0-2.16

linux (4.4.0-2.16) xenial; urgency=low

  [ Andy Whitcroft ]

  * Release Tracking Bug
    - LP: #1539090
  * SAUCE: hv: hv_set_ifconfig -- convert to python3
    - LP: #1506521
  * SAUCE: dm: introduce a target_ioctl op to allow target specific ioctls
    - LP: #1538618

  [ Colin Ian King ]

  * SAUCE: ACPI / tables: Add acpi_force_32bit_fadt_addr option to force 32
    bit FADT addresses (LP: #1529381)
    - LP: #1529381

  [ John Johansen ]

  * SAUCE: (no-up): apparmor: fix for failed mediation of socket that is
    being shutdown
    - LP: #1446906

  [ Mahesh Salgaonkar ]

  * SAUCE: Powernv: Remove the usage of PACAR1 from opal wrappers
    - LP: #1537881
  * SAUCE: powerpc/book3s: Fix TB corruption in guest exit path on HMI
    - LP: #1537881
  * SAUCE: KVM: PPC: Book3S HV: Fix soft lockups in KVM on HMI for time
    base errors
    - LP: #1537881

  [ Paolo Pisati ]

  * SAUCE: arm64: errata: Add -mpc-relative-literal-loads to erratum
    #843419 build flags
    - LP: #1533009
  * [Config] MFD_TPS65217=y && REGULATOR_TPS65217=y
  * [Config] disable ARCH_ZX (ZTE ZX Soc)

  [ Tim Gardner ]

  * Revert "SAUCE: (noup) cxlflash: a couple off by one bugs"
  * SAUCE: (no-up) Update bnx2x firmware to
    - LP: #1536719
  * SAUCE: drop obsolete bnx2x firmware
  * SAUCE: i40e: Silence 'may be used uninitialized' warnings
    - LP: #1536474
  * [Config] CONFIG_ZONE_DMA=y for amd64 lowlatency
    - LP: #1534647
  * [Config] Add pvpanic to virtual flavour
    - LP: #1537923
    - LP: #1520457

  [ Upstream Kernel Changes ]

  * i40evf: fix compiler warning of unused variable
    - LP: #1536474
  * intel: i40e: fix confused code
    - LP: #1536474
  * i40e/i40evf: remove unused tunnel parameter
    - LP: #1536474
  * i40e: Change BUG_ON to WARN_ON in service event complete
    - LP: #1536474
  * i40e: remove BUG_ON from feature string building
    - LP: #1536474
  * i40e: remove BUG_ON from FCoE setup
    - LP: #1536474
  * i40e: Workaround fix for mss < 256 issue
    - LP: #1536474
  * i40e/i40evf: Add a stat to track how many times we have to do a force
    - LP: #1536474
  * i40e: Move the saving of old link info from handle_link_event to
    - LP: #1536474
  * i40e/i40evf: Add comment to #endif
    - LP: #1536474
  * i40e/i40evf: clean up error messages
    - LP: #1536474
  * i40evf: handle many MAC filters correctly
    - LP: #1536474
  * i40e: return the number of enabled queues for ETHTOOL_GRXRINGS
    - LP: #1536474
  * i40e: rework the functions to configure RSS with similar parameters
    - LP: #1536474
  * i40e: create a generic configure rss function
    - LP: #1536474
  * i40e: Bump version to 1.4.2
    - LP: #1536474
  * i40e: add new fields to store user configuration
    - LP: #1536474
  * i40e: rename rss_size to alloc_rss_size in i40e_pf
    - LP: #1536474
  * i40e/i40evf: Fix RS bit update in Tx path and disable force WB
    - LP: #1536474
  * i40e/i40evf: prefetch skb data on transmit
    - LP: #1536474
  * i40evf: rename VF adapter s...

Changed in linux (Ubuntu Xenial):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.