Don't pull in network-online.target in apt-daily.timer

Bug #1716973 reported by Julian Andres Klode on 2017-09-13
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
apt (Ubuntu)
High
Unassigned
Xenial
High
Unassigned
Zesty
High
Unassigned

Bug Description

[Impact]
apt-daily.timer is enabled on every boot and pulls in network-online.target via Wants and After. While nothing has an After=apt-daily.timer (or rather an After=timers.target) and this should thus not impact boot performance, the rc-local.service specifies an After=network-online.target and the login stuff (getty, gdm, etc) is ordered After=rc-local, thus severely increasing the time to login if nothing else pulls in network-online (like an LSB script).

This works around the problem on most boots, the problem will only occur if the timer would have elapsed while the machine was off.

[Test case]
Well, the change is fairly obvious. Actually testing that is pointless, and depending on the system configuration, network-online.target might be pulled in by something else. So just look at the file and check that the network-online.target dependency moved to the service.

[Regression potential]
Literally none. We just move the dependency to the service which actually needs it.

Changed in apt (Ubuntu Xenial):
status: New → Triaged
Changed in apt (Ubuntu Zesty):
status: New → Triaged
Changed in apt (Ubuntu Xenial):
importance: Undecided → High
Changed in apt (Ubuntu Zesty):
importance: Undecided → High
Changed in apt (Ubuntu):
importance: Undecided → High
status: New → Fix Released
Changed in apt (Ubuntu Zesty):
status: Triaged → In Progress
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers