xtrs: FTBFS with GCC 5: trs_memory.c:152:6: error: type of 'state' defaults to 'int' [-Werror=implicit-int]

[Logan Rosen]

Imported from Debian bug http://bugs.debian.org/798765:

Package: xtrs
Version: 4.9c-3.4
Severity: serious
Tags: sid stretch
Justification: fails to build from source (but built successfully in the past)

Hi,

xtrs FTBFS in sid with GCC 5:

[...]
/usr/bin/make DEBUG="-Wall -Werror -Wno-error=unused-but-set-variable -O2 -g -D_REENTRANT" PREFIX=/usr
make[1]: Entering directory '/tmp/buildd/xtrs-4.9c'
cc -Wall -Werror -Wno-error=unused-but-set-variable -O2 -g -D_REENTRANT -DDEFAULT_ROM='"/usr/local/lib/xtrs/level2rom.hex"' -DDEFAULT_ROM3='"/usr/local/lib/xtrs/romimage.m3"' -DDEFAULT_ROM4P='"/usr/local/lib/xtrs/romimage.m4p"' -DREADLINE -DDISKDIR='"."' -I/usr/include/X11 -DAPPDEFAULTS='"/usr/X11/lib/X11/app-defaults"' -DKBWAIT -DHAVE_SIGIO -c -o z80.o z80.c
cc -Wall -Werror -Wno-error=unused-but-set-variable -O2 -g -D_REENTRANT -DDEFAULT_ROM='"/usr/local/lib/xtrs/level2rom.hex"' -DDEFAULT_ROM3='"/usr/local/lib/xtrs/romimage.m3"' -DDEFAULT_ROM4P='"/usr/local/lib/xtrs/romimage.m4p"' -DREADLINE -DDISKDIR='"."' -I/usr/include/X11 -DAPPDEFAULTS='"/usr/X11/lib/X11/app-defaults"' -DKBWAIT -DHAVE_SIGIO -c -o main.o main.c
cc -Wall -Werror -Wno-error=unused-but-set-variable -O2 -g -D_REENTRANT -DDEFAULT_ROM='"/usr/local/lib/xtrs/level2rom.hex"' -DDEFAULT_ROM3='"/usr/local/lib/xtrs/romimage.m3"' -DDEFAULT_ROM4P='"/usr/local/lib/xtrs/romimage.m4p"' -DREADLINE -DDISKDIR='"."' -I/usr/include/X11 -DAPPDEFAULTS='"/usr/X11/lib/X11/app-defaults"' -DKBWAIT -DHAVE_SIGIO -c -o load_cmd.o load_cmd.c
cc -Wall -Werror -Wno-error=unused-but-set-variable -O2 -g -D_REENTRANT -DDEFAULT_ROM='"/usr/local/lib/xtrs/level2rom.hex"' -DDEFAULT_ROM3='"/usr/local/lib/xtrs/romimage.m3"' -DDEFAULT_ROM4P='"/usr/local/lib/xtrs/romimage.m4p"' -DREADLINE -DDISKDIR='"."' -I/usr/include/X11 -DAPPDEFAULTS='"/usr/X11/lib/X11/app-defaults"' -DKBWAIT -DHAVE_SIGIO -c -o load_hex.o load_hex.c
cc -Wall -Werror -Wno-error=unused-but-set-variable -O2 -g -D_REENTRANT -DDEFAULT_ROM='"/usr/local/lib/xtrs/level2rom.hex"' -DDEFAULT_ROM3='"/usr/local/lib/xtrs/romimage.m3"' -DDEFAULT_ROM4P='"/usr/local/lib/xtrs/romimage.m4p"' -DREADLINE -DDISKDIR='"."' -I/usr/include/X11 -DAPPDEFAULTS='"/usr/X11/lib/X11/app-defaults"' -DKBWAIT -DHAVE_SIGIO -c -o trs_memory.o trs_memory.c
trs_memory.c: In function 'mem_romin':
trs_memory.c:152:6: error: type of 'state' defaults to 'int' [-Werror=implicit-int]
 void mem_romin(state)
      ^
cc1: all warnings being treated as errors
<builtin>: recipe for target 'trs_memory.o' failed
make[1]: *** [trs_memory.o] Error 1
make[1]: Leaving directory '/tmp/buildd/xtrs-4.9c'
debian/rules:34: recipe for target 'build-stamp' failed
make: *** [build-stamp] Error 2
dpkg-buildpackage: error: debian/rules build gave error exit status 2

Andreas

[Launchpad Janitor (janitor)]

This bug was fixed in the package xtrs - 4.9c-3.5ubuntu1

---------------
xtrs (4.9c-3.5ubuntu1) xenial; urgency=medium

  * Merge from Debian unstable (LP: #1508289). Remaining changes:
    - {debug,dis}.c: fix instances of "format not a string literal and no
      format arguments" to fix build failure.
    - Makefile: Remove -DHAVE_SIGIO to stop hangs on startup.
    - trs_disk.c: Override unchecked usages of ftruncate, fwrite, and fread, as
      there is no error checking on any other function around there.
    - mkdisk.c: Handle errors from fwrite.
    - trs_xinterface.c: Fix unused result warning and ignored retval error,
      resolving FTBFS.

xtrs (4.9c-3.5) unstable; urgency=medium

  * Non-maintainer upload.
  * Fix function declare: type of 'state' defaults to 'int'
     [-Werror=implicit-int] (Closes: #798765)

 -- Logan Rosen <email address hidden> Sat, 24 Oct 2015 03:01:58 -0400