fix ftbfs with GCC 5

Bug #1429978 reported by Matthias Klose
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
shim (Ubuntu)
Fix Released
High
Mathieu Trudel-Lapierre
Wily
Fix Released
High
Mathieu Trudel-Lapierre
shim-signed (Ubuntu)
Invalid
High
Mathieu Trudel-Lapierre

Bug Description

cc -ggdb -O0 -fno-stack-protector -fno-strict-aliasing -fpic -fshort-wchar -Wall -Werror -mno-red-zone -maccumulate-outgoing-args -mno-mmx -mno-sse -fno-builtin "-DDEFAULT_LOADER=L\"\\\\grubx64.efi\"" "-DDEFAULT_LOADER_CHAR=\"\\\\grubx64.efi\"" -nostdinc -ICryptlib -ICryptlib/Include -I/usr/include/efi -I/usr/include/efi/x86_64 -I/usr/include/efi/protocol -Iinclude -DEFI_FUNCTION_WRAPPER -DGNU_EFI_USE_MS_ABI -DVENDOR_CERT_FILE=\"debian/canonical-uefi-ca.der\" -D_FORTIFY_SOURCE=2 -c -o shim.o shim.c
In file included from /usr/include/efi/efi.h:35:0,
                 from shim.c:36:
/usr/include/efi/x86_64/efibind.h:86:24: fatal error: stdint.h: No such file or directory
compilation terminated.
<builtin>: recipe for target 'shim.o' failed
make[2]: *** [shim.o] Error 1

the efibind.h header tries to include stdint.h for c99 or c11, and fails with -nostdinc.

Tags: ftbfs patch

Related branches

Revision history for this message
Matthias Klose (doko) wrote :
tags: added: patch
Steve Langasek (vorlon)
Changed in shim (Ubuntu):
status: Confirmed → Triaged
Steve Langasek (vorlon)
Changed in shim (Ubuntu):
assignee: nobody → Mathieu Trudel-Lapierre (mathieu-tl)
Revision history for this message
Mathieu Trudel-Lapierre (cyphermox) wrote :

This bug probably should have been closed with the upload of shim 0.8-0ubuntu1; marking as Fix Released.

At the least, it would not be the same issue with stdint.

Changed in shim (Ubuntu):
status: Triaged → Fix Released
Revision history for this message
Mathieu Trudel-Lapierre (cyphermox) wrote :

I'm wrong. We still have some fixes to land for 0.8-0ubuntu3 which include this and a cherry-pick of d51739a4.

Changed in shim (Ubuntu):
status: Fix Released → Triaged
Changed in shim (Ubuntu):
importance: Undecided → High
Revision history for this message
dekchay (dekchay) wrote :

cc -ggdb -O0 -fno-stack-protector -fno-strict-aliasing -fpic -fshort-wchar -Wall -Werror -mno-red-zone -maccumulate-outgoing-args -mno-mmx -mno-sse -fno-builtin "-DDEFAULT_LOADER=L\"\\\\grubx64.efi\"" "-DDEFAULT_LOADER_CHAR=\"\\\\grubx64.efi\"" -nostdinc -ICryptlib -ICryptlib/Include -I/usr/include/efi -I/usr/include/efi/x86_64 -I/usr/include/efi/protocol -Iinclude -DEFI_FUNCTION_WRAPPER -DGNU_EFI_USE_MS_ABI -DVENDOR_CERT_FILE=\"debian/canonical-uefi-ca.der\" -D_FORTIFY_SOURCE=2 -c -o shim.o shim.c
In file included from /usr/include/efi/efi.h:35:0,
                 from shim.c:36:
/usr/include/efi/x86_64/efibind.h:86:24: fatal error: stdint.h: No such file or directory
compilation terminated.
<builtin>: recipe for target 'shim.o' failed
make[2]: *** [shim.o] Error 1

the efibind.h header tries to include stdint.h for c99 or c11, and fails with -nostdinc.

Revision history for this message
Steve Langasek (vorlon) wrote :

> the efibind.h header tries to include stdint.h for c99 or c11, and fails with -nostdinc.

This is known, and the fix for it is staged in the bzr branch for the package. As there is no other reason to upload shim right now, which would require us to submit a new binary for signing, the fix has not been uploaded.

Changed in shim (Ubuntu Wily):
status: Triaged → Fix Committed
Changed in shim (Ubuntu):
status: Triaged → Fix Committed
Changed in shim-signed (Ubuntu):
importance: Undecided → High
Changed in shim-signed (Ubuntu Wily):
importance: Undecided → High
Changed in shim-signed (Ubuntu):
status: New → In Progress
Changed in shim-signed (Ubuntu Wily):
status: New → In Progress
Changed in shim-signed (Ubuntu):
assignee: nobody → Mathieu Trudel-Lapierre (cyphermox)
Changed in shim-signed (Ubuntu Wily):
assignee: nobody → Mathieu Trudel-Lapierre (cyphermox)
no longer affects: shim-signed (Ubuntu Wily)
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package shim - 0.9+1465500757.14a5905-0ubuntu1

---------------
shim (0.9+1465500757.14a5905-0ubuntu1) yakkety; urgency=medium

  * New upstream release.
    - Better handle LoadOptions. (LP: #1581299)
    - Measure state and second stage in TPM.
    - Mirror MokSBState in runtime as MokSBStateRT.
    - Fix failure to build with GCC 5. (LP: #1429978)
    - Various bug fixes and other improvements.
  * Refreshed patches.
    - Remaining patches:
      + second-stage-path
      + sbsigntool-not-pesign
  * debian/patches/unused-variable: remove unused variable size.
  * debian/patches/binutils-version-matching: revert d9a4c912 to correctly
    match objcopy's version on Ubuntu.
  * debian/copyright: update copyright for patches.

 -- Mathieu Trudel-Lapierre <email address hidden> Tue, 26 Jul 2016 16:48:32 -0400

Changed in shim (Ubuntu):
status: Fix Committed → Fix Released
Steve Langasek (vorlon)
Changed in shim-signed (Ubuntu):
status: In Progress → Invalid
Revision history for this message
Mathieu Trudel-Lapierre (cyphermox) wrote :

This has been fixed for a while, we're now on shim 0.9+1474479173.6c180c6-1ubuntu1.

Changed in shim (Ubuntu Wily):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.