Search suggestions should be disabled in private mode
Bug #1457958 reported by
Olivier Tilloy
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | ||
|---|---|---|---|---|---|---|
| webbrowser-app |
Fix Released
|
Critical
|
Arthur Mello | |||
| webbrowser-app (Ubuntu) | ||||||
| Vivid |
New
|
Undecided
|
Unassigned | |||
Bug Description
Given that search suggestions issue queries to a remote server, they should be inhibited while in private mode, to not disclose anything about the user input.
Related branches
lp:~artmello/webbrowser-app/webbrowser-app-private_browsing
- Olivier Tilloy: Approve
- PS Jenkins bot: Needs Fixing (continuous-integration)
-
Diff: 873 lines (+477/-26)14 files modifiedsrc/Ubuntu/Web/UbuntuWebContext.qml (+3/-1)
src/Ubuntu/Web/UbuntuWebView02.qml (+4/-0)
src/app/ChromeBase.qml (+3/-0)
src/app/ChromeButton.qml (+1/-0)
src/app/webbrowser/Browser.qml (+126/-16)
src/app/webbrowser/BrowserTab.qml (+9/-3)
src/app/webbrowser/Chrome.qml (+8/-1)
src/app/webbrowser/LeavePrivateModeDialog.qml (+43/-0)
src/app/webbrowser/NewPrivateTabView.qml (+60/-0)
src/app/webbrowser/NewTabView.qml (+2/-0)
src/app/webbrowser/TabsList.qml (+1/-1)
tests/autopilot/webbrowser_app/emulators/browser.py (+93/-1)
tests/autopilot/webbrowser_app/tests/__init__.py (+16/-3)
tests/autopilot/webbrowser_app/tests/test_private.py (+108/-0)
| Changed in webbrowser-app: | |
| status: | Triaged → In Progress |
| Changed in webbrowser-app: | |
| status: | In Progress → Fix Released |
To post a comment you must log in.
