defaultGridUnit unit test fails on hidpi screen

Bug #1457421 reported by Cris Dywan
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
ubuntu-ui-toolkit (Ubuntu)
Fix Released
High
Cris Dywan
Vivid
New
Undecided
Unassigned

Bug Description

There's a test failure in tests/unit/tst_units

tst_units: FAIL! : tst_UCUnits::defaultGridUnit() Compared floats are not the same (fuzzy compare)
tst_units: Actual (units.gridUnit()): 16
tst_units: Expected (8.0f) : 8
tst_units: Loc: [tst_units.cpp(36)]

My environment has the following setting

> echo $GRID_UNIT_PX
16

matching the 2x scale factor to accomodate my screen resolution.

I'm not sure why the default needs to be tested considering it's different on every device... it should either be dropped or the "units" test needs to clear the environment variable before testing it.

Related branches

Cris Dywan (kalikiana)
Changed in ubuntu-ui-toolkit (Ubuntu):
status: New → In Progress
assignee: nobody → Christian Dywan (kalikiana)
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-ui-toolkit - 1.3.1517+15.10.20150523-0ubuntu1

---------------
ubuntu-ui-toolkit (1.3.1517+15.10.20150523-0ubuntu1) wily; urgency=medium

  [ Christian Dywan ]
  * Expose textDocument of TextField. Fixes LP: #1392276
  * Unset GRID_UNIT_PX before checking default value. Fixes LP: #1457421
  * No cutting and copying of passwords. Fixes LP: #1438976
  * Implement new API tool based on qmlplugindump producing JSON.
    Fixes LP: #1187010

  [ Leo Arias ]
  * Make explicit the dependency on upstart for the autopilot helpers.

  [ Timo Jyrinki ]
  * uitk_test_plan.sh: Switch to vivid-overlay & wily instead of rtm-14.09 &
    vivid. Fixes LP: #1457015.

 -- CI Train Bot <email address hidden> Sat, 23 May 2015 17:24:43 +0000

Changed in ubuntu-ui-toolkit (Ubuntu):
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.