Header contents not full width after navigating to a page with more actions

Bug #1408481 reported by Andrew Hayzen
14
This bug affects 3 people
Affects Status Importance Assigned to Milestone
ubuntu-ui-toolkit (Ubuntu)
Fix Released
High
Tim Peeters
Vivid
New
Undecided
Unassigned

Bug Description

I have a page with 1 action (search which shows a textfield filling the header) and another with multiple actions causing an overflow. If you select the search action after navigating to the other tab its right anchor is moved to where the left most action from the other page is, not the current page.

I have an example branch here [0]
Steps:
* Select search
* Note the search bar fills the width
* Select back
* Switch to the other tab and back again
* Select search
* Notice its right anchor point has moved

0 - lp:~andrew-hayzen/+junk/header-not-full-width-example

Related branches

Tim Peeters (tpeeters)
Changed in ubuntu-ui-toolkit (Ubuntu):
assignee: nobody → Tim Peeters (tpeeters)
importance: Undecided → High
Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in ubuntu-ui-toolkit (Ubuntu):
status: New → Confirmed
Tim Peeters (tpeeters)
Changed in ubuntu-ui-toolkit (Ubuntu):
status: Confirmed → In Progress
Revision history for this message
Tim Peeters (tpeeters) wrote :

the code to reproduce the issue can be simplified to this:

    MainView {
      width: units.gu(50)
      height: units.gu(80)
        useDeprecatedToolbar: false

        Tabs {
            Tab {
                title: "Search"
                page: Page {
                    head.contents: TextField {
                        anchors {
                            left: parent ? parent.left : undefined
                            right: parent ? parent.right : undefined
                            rightMargin: units.gu(1)
                        }
                        placeholderText: i18n.tr("Search...")
                    }
                }
            }
            Tab {
                title: "Actions"
                page: Page {
                    head.actions: [
                        Action {
                            iconName: "add"
                        },
                        Action {
                            iconName: "clear"
                        },
                        Action {
                            iconName: "delete"
                        }
                    ]
                }
            }
        }
    }

Tim Peeters (tpeeters)
Changed in ubuntu-ui-toolkit (Ubuntu):
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (4.3 KiB)

This bug was fixed in the package ubuntu-ui-toolkit - 1.1.1403+15.04.20150206-0ubuntu1

---------------
ubuntu-ui-toolkit (1.1.1403+15.04.20150206-0ubuntu1) vivid; urgency=medium

  [ Albert Astals Cid ]
  * Adapt to behaviour change in handling of QVariants from QML to
    C++ in Qt 5.4
  * Don't use Qt::PopupFocusReason to change the focus Even if it
    is the correct reason QtQuick is since 5.4 ignoring focus changes
    due to PopupFocusReason. Fixes LP: #1395014.
  * Fix test failure with Qt 5.4 ExpandablesColumn::test_expandedItem()
    In Qt 5.4 an alias to a null variable is correctly null instead of
    undefined like it was in 5.3, since we still want 5.3 support i'm
    conveting it to a verify with == that uses JS loose comparison to
    accept both null and undefined. Fixes LP: #1395012.

  [ Alexandre Abreu ]
  * Remove the unecessary DBUS bindingi to global address
    org.freedesktop.Application by the UriHAndler. It actually fails
    for confined apps and the uri-dispatcher anyway does not work by
    directly calling into the exposed "well known names" exposed on
    the bus as TEd explains here LP: #1342129 but by directly calling
     into the process dbus connection. Fixes LP: #1378823.

  [ Benjamin Zeller ]
  * Fix scripts to work in shadowbuild mode.
  * Shadowbuild support for ubuntu-ui-toolkit.

  [ Christian Dywan ]
  * Abort export_modules_dir.sh and ergo run_tests.sh if binaries are
    absent. Fixes LP: #1415973.
  * Asterisk are needed for cp -R.
  * Ensure adb is running (and fallback arch if dpkg-dev is missing).
    Fixes LP: #1417997.
  * Get arch for push_to_phone.sh from device and handle adb refusal.
  * Implement and unit-test i18n.(c)tag. Fixes LP: #1417031.
  * Print component creation errors in popupUtils.open.
    Fixes LP: #1418507.
  * Use correct unfocussed text field color. Fixes LP: #1396062.

  [ Daniel d'Andrada ]
  * Refactor OrientationHelper Simplify animation code and make it
    more robust. It now survives changes in Screen.primaryOrientation
    and Screen.orientation happening one right after the other.

  [ Daniel Holbach ]
  * Fix broken link to developer site.

  [ Giulio Collura ]
  * This is a bugfix for bug LP: #1341814 and bug LP: #1400297.
    Essentially we have to force the removal of the previous
    'contents' item by removing its parent. This way we ensure that
    the contents are correctly hidden, focused and removed, without
    destroying them.

  [ Loïc Molinari ]
  * Removed unused variables breaking debug builds.

  [ Michael Sheldon ]
  * Only use stableOrientationAngleTimer in the OrientationHelper when
    the orientationAngle has been set automatically.
    Fixes LP: #1409027.

  [ Niklas Wenzel ]
  * Fixes LP: #1395118

  [ nskaggs ]
  * Re-add autopilot helper documentation and update. Fixes
    LP: #1409778, LP: #1410477.

  [ Tim Peeters ]
  * Add a preview of the new list items to the UITK component gallery.
  * Add performance test for MainView.
  * Clean python code to follow pep257 standards.
  * Fix incorrect header contents width when navigating back from a
    page with a lot of actions. Fixes LP: #1408481.
  * Split up MainView in MainView and ...

Read more...

Changed in ubuntu-ui-toolkit (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.