[sdk] Header icon color should be the same as the header text color
Bug #1317816 reported by
Nekhelesh Ramananthan
This bug affects 2 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ubuntu UI Toolkit |
Fix Released
|
Critical
|
Tim Peeters | ||
Ubuntu UX |
Fix Released
|
Medium
|
Unassigned | ||
ubuntu-ui-toolkit (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
Vivid |
New
|
Undecided
|
Unassigned |
Bug Description
The new tab drawer icon is currently always grey regardless of the app background. As a result in some background it stands out poorly. It should in the least have the same color as the tab header title color. Here is a screenshot of the tab drawer icon in the clock app. The grey color does not go too well with the pink-purple background. https:/
Also the action icons should be the same color as the header text.
Related branches
lp:~tpeeters/ubuntu-ui-toolkit/headIconColor
- PS Jenkins bot: Approve (continuous-integration)
- Cris Dywan: Approve
-
Diff: 299 lines (+125/-21)8 files modifiedcomponents.api (+1/-0)
examples/ubuntu-ui-toolkit-gallery/Icons.qml (+4/-6)
modules/Ubuntu/Components/Icon10.qml (+3/-1)
modules/Ubuntu/Components/PageHeadConfiguration.qml (+5/-0)
modules/Ubuntu/Components/Themes/Ambiance/PageHeadButton.qml (+5/-6)
modules/Ubuntu/Components/Themes/Ambiance/PageHeadStyle.qml (+6/-2)
tests/resources/header/header.qml (+5/-6)
tests/unit/tst_components/tst_header_colors.qml (+96/-0)
Changed in ubuntu-ui-toolkit: | |
assignee: | nobody → Tim Peeters (tpeeters) |
Changed in ubuntu-ui-toolkit: | |
status: | New → Confirmed |
importance: | Undecided → Medium |
importance: | Medium → High |
Changed in ubuntu-ux: | |
assignee: | nobody → Jouni Helminen (jounihelminen) |
Changed in ubuntu-ui-toolkit: | |
importance: | High → Critical |
summary: |
- Tab drawer icon color should be the same as the header text color + Header icon color should be the same as the header text color |
description: | updated |
summary: |
- Header icon color should be the same as the header text color + [sdk] Header icon color should be the same as the header text color |
Changed in ubuntu-ux: | |
status: | New → Fix Committed |
Changed in ubuntu-ui-toolkit: | |
status: | Confirmed → In Progress |
Changed in ubuntu-ui-toolkit (Ubuntu): | |
status: | New → In Progress |
Changed in ubuntu-ui-toolkit: | |
status: | Fix Committed → Fix Released |
Changed in ubuntu-ux: | |
importance: | Undecided → Medium |
Changed in ubuntu-ux: | |
status: | Fix Committed → Fix Released |
assignee: | Jouni Helminen (jounihelminen) → Giorgio Venturi (giorgio-venturi) |
To post a comment you must log in.
This, and the related bug #1315884 are prerequisite for customizing scope pages that's a requirement for release.