image provider does not emit sourceChanged signal

Bug #1194778 reported by Michael Zanetti
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Ubuntu UI Toolkit
Fix Released
High
Zsombor Egri
ubuntu-ui-toolkit (Ubuntu)
Fix Released
Undecided
Unassigned
Vivid
New
Undecided
Unassigned
ubuntu-ui-toolkit (Ubuntu RTM)
Fix Released
Undecided
Unassigned

Bug Description

importing Ubuntu.Components breaks Image's (and BorderImage's) sourceChanged signal.

Check out the attached code snippet. All it does is to change the image source when clicking the button. Now, if you run it as is, you will see the print("source changed!") happening every time the Image's source changes.

Now, open the file and uncomment the import for Ubuntu.Components 0.1. Repeat the experiment.

=> the sourceChanged signal is gone.

Related branches

Revision history for this message
Michael Zanetti (mzanetti) wrote :
Changed in ubuntu-ui-toolkit:
importance: Undecided → High
status: New → Confirmed
Changed in ubuntu-ui-toolkit:
assignee: nobody → Florian Boucault (fboucault)
Revision history for this message
Florian Boucault (fboucault) wrote :

The issue is likely to be with qmlRegisterExtendedType that does not proxy the property change signal from the extension object to the extended object.
Oddly, even firing the 'sourceChanged' signal on the extended object manually does not seem to work.

Revision history for this message
Albert Astals Cid (aacid) wrote :

I lost around one hour trying to figure out and tracking why my code wasn't working, it'd be great if this gained some priority so we don't get devels pulling the hair out and leaving the platform because such basic things as onChanged handlers don't work.

Revision history for this message
Zsombor Egri (zsombi) wrote :

All we have to do is not to define change signal, but use the original QQuickImageBase's change signal. That's it.

Changed in ubuntu-ui-toolkit:
status: Confirmed → In Progress
Zsombor Egri (zsombi)
Changed in ubuntu-ui-toolkit:
assignee: Florian Boucault (fboucault) → Zsombor Egri (zsombi)
milestone: none → 11.21
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:ubuntu-ui-toolkit/staging at revision None, scheduled for release in ubuntu-ui-toolkit, milestone Unknown

Changed in ubuntu-ui-toolkit:
status: In Progress → Fix Committed
Zoltan Balogh (bzoltan)
Changed in ubuntu-ui-toolkit:
status: Fix Committed → Fix Released
Zsombor Egri (zsombi)
Changed in ubuntu-ui-toolkit (Ubuntu):
status: New → Fix Released
Changed in ubuntu-ui-toolkit (Ubuntu RTM):
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.