arm64 images built w/ setjmp module fail w/ license error
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
grub2 (Ubuntu) |
Fix Released
|
Medium
|
Unassigned | ||
Trusty |
Fix Released
|
Medium
|
dann frazier | ||
Vivid |
Fix Released
|
Medium
|
dann frazier | ||
Wily |
Fix Released
|
Medium
|
dann frazier | ||
Xenial |
Fix Released
|
Medium
|
Unassigned |
Bug Description
[Impact]
Any ARM64 GRUB image that includes the setjmp module will fail, reporting an "incompatible license" error. Ubuntu doesn't normally include this module in most images. The one exception I know of is MAAS which, by default, includes all modules when generating EFI images. MAAS currently has a hack to blacklist setjmp on arm64 because a fix wasn't available at the time - but I fear other users will try to do the same thing and hit this issue which can be difficult to track down.
[Test Case]
PXE boot a grub image on arm64 that includes the setjmp module:
$ grub-mkimage -v -o grubaa64.efi -O arm64-efi -d /usr/lib/
[Regression Risk]
The patch merely adds a license section to the module and it has been tested to work.
Related branches
summary: |
- arm64 images built w/ setjump module fail w/ license error + arm64 images built w/ setjmp module fail w/ license error |
Changed in grub2 (Ubuntu Xenial): | |
status: | Confirmed → Fix Committed |
importance: | Undecided → Medium |
Changed in grub2 (Ubuntu Wily): | |
importance: | Undecided → Medium |
Changed in grub2 (Ubuntu Vivid): | |
importance: | Undecided → Medium |
Changed in grub2 (Ubuntu Trusty): | |
importance: | Undecided → Medium |
Changed in grub2 (Ubuntu Wily): | |
status: | Confirmed → In Progress |
assignee: | nobody → dann frazier (dannf) |
Changed in grub2 (Ubuntu Vivid): | |
assignee: | nobody → dann frazier (dannf) |
Changed in grub2 (Ubuntu Trusty): | |
assignee: | nobody → dann frazier (dannf) |
Changed in grub2 (Ubuntu Vivid): | |
status: | Confirmed → In Progress |
Changed in grub2 (Ubuntu Trusty): | |
status: | Confirmed → In Progress |
tags: |
added: verification-done verification-vivid-done verification-wily-done removed: verification-needed |
tags: |
added: verification-done-vivid verification-done-wily removed: verification-vivid-done verification-wily-done |
Here's a pull request against debian's git:
The following changes since commit f71c89708048486 81afe0eb0a597ae fb9d4463a2:
releasing package grub2 version 2.02~beta2-29 (2015-10-13 23:40:21 +0100)
are available in the git repository at:
https:/ /git.launchpad. net/~dannf/ grub2 people/ dannf/arm64- setjmp- license
for you to fetch changes up to 269a263bb6c7063 29fec0efa0b68d7 bd100d4fbc:
merge patched- people/ dannf/arm64- setjmp- license into people/ dannf/arm64- setjmp- license (2015-10-23 16:25:25 -0600)
------- ------- ------- ------- ------- ------- ------- ------- ------- - people/ dannf/arm64- setjmp- license into people/ dannf/arm64- setjmp- license
dann frazier (2):
arm64/setjmp: Add missing license macro
merge patched-
debian/.git-dpm | 4 +-- setjmp- Add-missing- license- macro.patch | 33 +++++++ +++++++ +++++++ + patches/ series | 1 + lib/arm64/ setjmp. S | 2 ++ patches/ arm64-setjmp- Add-missing- license- macro.patch
debian/changelog | 6 ++++
.../arm64-
debian/
grub-core/
5 files changed, 44 insertions(+), 2 deletions(-)
create mode 100644 debian/