Fix handling of /dev/uinput

Bug #1350263 reported by Martin Pitt
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
autopilot (Ubuntu)
Fix Released
High
Martin Pitt
Vivid
New
Undecided
Unassigned

Bug Description

The current autopilot rule does that:

# Creates autopilot group specific access to /dev/uinput
KERNEL=="uinput", SUBSYSTEM=="misc", SYMLINK="autopilot-uinput", GROUP="autopilot", MODE="0660"

But on our Ubuntu Touch images, at least on mako, we have other rules which also change the permissions:

 rules.d/70-android.rules:ACTION=="add", KERNEL=="uinput", OWNER="system", GROUP="bluetooth", MODE="0660"

There are multiple things which are wrong with this:

 * We need to stop abusing groups for device permissions. They also apply to remote logins which we really don't want to, and cause conflicts liek this.

 * There is no reason to create a /dev/autopilot-uinput symlink. Device symlinks make sense if they are stable and point to an unstable device name, like /dev/disk/by-label, but /dev/uinput is a fixed name which never changes.

Instead, the rule should provide access to the current foreground session:

  KERNEL=="uinput", SUBSYSTEM=="misc", TAG+="uaccess"

and autopilot be fixed to use /dev/uinput directly. The group "autopilot" should not be created any more.

Related branches

Martin Pitt (pitti)
Changed in autopilot (Ubuntu):
importance: Undecided → High
Martin Pitt (pitti)
Changed in autopilot (Ubuntu):
assignee: nobody → Martin Pitt (pitti)
status: New → In Progress
Revision history for this message
Martin Pitt (pitti) wrote :

This landed in trunk now.

Changed in autopilot (Ubuntu):
status: In Progress → Fix Committed
Revision history for this message
Martin Pitt (pitti) wrote :
Changed in autopilot (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.