Fix handling of /dev/uinput
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
autopilot (Ubuntu) |
Fix Released
|
High
|
Martin Pitt | ||
Vivid |
New
|
Undecided
|
Unassigned |
Bug Description
The current autopilot rule does that:
# Creates autopilot group specific access to /dev/uinput
KERNEL=="uinput", SUBSYSTEM=="misc", SYMLINK=
But on our Ubuntu Touch images, at least on mako, we have other rules which also change the permissions:
rules.
There are multiple things which are wrong with this:
* We need to stop abusing groups for device permissions. They also apply to remote logins which we really don't want to, and cause conflicts liek this.
* There is no reason to create a /dev/autopilot-
Instead, the rule should provide access to the current foreground session:
KERNEL=="uinput", SUBSYSTEM=="misc", TAG+="uaccess"
and autopilot be fixed to use /dev/uinput directly. The group "autopilot" should not be created any more.
Related branches
- Christopher Lee (community): Approve
- PS Jenkins bot: Approve (continuous-integration)
-
Diff: 82 lines (+8/-27)4 files modifiedautopilot/input/_uinput.py (+2/-6)
autopilot/tests/functional/test_input_stack.py (+2/-4)
debian/61-autopilot3-uinput.rules (+2/-2)
debian/python3-autopilot.postinst (+2/-15)
Changed in autopilot (Ubuntu): | |
importance: | Undecided → High |
Changed in autopilot (Ubuntu): | |
assignee: | nobody → Martin Pitt (pitti) |
status: | New → In Progress |
This landed in trunk now.