[SRU] python-eventlet/python-gevent fall back to old behavior if SSLContext is not available

[Corey Bryant]

[Impact]
When backporting the utopic version of python-eventlet to the ubuntu cloud archive on trusty (to pick up the fix for bug #1419117) the build for python-eventlet failed. The build failed because SSLContext() is not defined for Python 2.7 in trusty, whereas it is defined for Python 2.7 and 3.4 in utopic.

Use of SSLContext was introduced in the utopic packaging branch in the following patch: debian/patches/sslwrap.diff. What I've done to enable the backport is to fall back to the original behavior in this patch if SSLContext is not available.

[Test Case]
Build python-eventlet for both trusty and utopic, which will also run the test suite.

[Regression Potential]
Should be zero, as the version of python-eventlet in trusty is running without the sslwrap.diff patch, and when the utopic version falls back to the original behavior, it will result in the same code.

[Brian Murray (brian-murray)]

The upload in the -proposed queue for Utopic isn't based off 0.13.0-1ubuntu3.1 so ends up removing the changes it made e.g.:

diff -Nru python-eventlet-0.13.0/debian/changelog python-eventlet-0.13.0/debian/changelog
--- python-eventlet-0.13.0/debian/changelog 2015-02-09 13:31:24.000000000 +0000
+++ python-eventlet-0.13.0/debian/changelog 2015-02-19 20:23:21.000000000 +0000
@@ -1,9 +1,9 @@
-python-eventlet (0.13.0-1ubuntu3.1) utopic; urgency=medium
+python-eventlet (0.13.0-1ubuntu4) utopic-proposed; urgency=medium

- * debian/patches/socket-timeout.patch: Cherry-pick patch to provide
- socket_timeout support (LP: #1419117).
+ * debian/patches/sslwrap.diff: Fall back to old behavior if SSLContext
+ not available (LP: #1423675).

- -- Corey Bryant <email address hidden> Mon, 09 Feb 2015 13:31:20 +0000
+ -- Corey Bryant <email address hidden> Thu, 19 Feb 2015 13:51:36 -0500

 python-eventlet (0.13.0-1ubuntu3) utopic; urgency=medium

diff -Nru python-eventlet-0.13.0/debian/patches/series python-eventlet-0.13.0/debian/patches/series
--- python-eventlet-0.13.0/debian/patches/series 2015-02-09 13:24:52.000000000 +0000
+++ python-eventlet-0.13.0/debian/patches/series 2015-02-19 20:21:57.000000000 +0000
@@ -1,4 +1,3 @@
 skip-failing-tests.patch
 fix-FTBFS-on-sphinx-build.patch
 sslwrap.diff
-socket-timeout.patch

[Corey Bryant (corey.bryant)]

Ugh, I'm not sure why that never got merged. I have a new merge request here. I'll ask Chuck to review it in the morning. https://code.launchpad.net/~corey.bryant/ubuntu/utopic/python-eventlet/0.13.0-1ubuntu3.2/+merge/250400

[Corey Bryant (corey.bryant)]

Bryan, Can you take a look again? Chuck Short just upload the following
merge:
https://code.launchpad.net/~corey.bryant/ubuntu/utopic/python-eventlet/0.13.0-1ubuntu3.2/+merge/250455

On Fri, Feb 20, 2015 at 10:03 AM, Launchpad Bug Tracker <
<email address hidden>> wrote:

> ** Branch linked: lp:~corey.bryant/ubuntu/utopic/python-
> eventlet/0.13.0-1ubuntu3.2
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1423675
>
> Title:
> [SRU] python-eventlet fall back to old behavior if SSLContext is not
> available
>
> Status in python-eventlet package in Ubuntu:
> New
>
> Bug description:
> [Impact]
> When backporting the utopic version of python-eventlet to the ubuntu
> cloud archive on trusty (to pick up the fix for bug #1419117) the build for
> python-eventlet failed. The build failed because SSLContext() is not
> defined for Python 2.7 in trusty, whereas it is defined for Python 2.7 and
> 3.4 in utopic.
>
> Use of SSLContext was introduced in the utopic packaging branch in the
> following patch: debian/patches/sslwrap.diff. What I've done to
> enable the backport is to fall back to the original behavior in this
> patch if SSLContext is not available.
>
> [Test Case]
> Build python-eventlet for both trusty and utopic, which will also run
> the test suite.
>
> [Regression Potential]
> Should be zero, as the version of python-eventlet in trusty is running
> without the sslwrap.diff patch, and when the utopic version falls back to
> the original behavior, it will result in the same code.
>
> To manage notifications about this bug go to:
>
> https://bugs.launchpad.net/ubuntu/+source/python-eventlet/+bug/1423675/+subscriptions
>

--
Regards,
Corey

[Corey Bryant (corey.bryant)]

Bryan, Can you take a look again? Chuck Short just uploaded the following merge:
https://code.launchpad.net/~corey.bryant/ubuntu/utopic/python-eventlet/0.13.0-1ubuntu3.2/+merge/250455

[Brian Murray (brian-murray)]

Hello Corey, or anyone else affected,

Accepted python-eventlet into utopic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/python-eventlet/0.13.0-1ubuntu3.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Corey Bryant (corey.bryant)]

Testing has successfully completed against python-eventlet 0.13.0-1ubuntu3.2.

[Launchpad Janitor (janitor)]

This bug was fixed in the package python-eventlet - 0.13.0-1ubuntu3.2

---------------
python-eventlet (0.13.0-1ubuntu3.2) utopic; urgency=medium

  * debian/patches/sslwrap.diff: Fall back to old behavior if SSLContext
    not available (LP: #1423675).
 -- Corey Bryant <email address hidden> Fri, 20 Feb 2015 09:42:26 -0500

[Brian Murray (brian-murray)]

The verification of the Stable Release Update for python-eventlet has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[Chris J Arges (arges)]

Hello Corey, or anyone else affected,

Accepted python-gevent into trusty-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/python-gevent/1.0-1ubuntu1.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Chris J Arges (arges)]

Hello Corey, or anyone else affected,

Accepted python-eventlet into trusty-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/python-eventlet/0.13.0-1ubuntu2.3 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Matthias Klose (doko)]

  verified that the code both works with python2.7 in trusty, and with 2.7.10 in the ubuntu-toolchain-r/ppa archive.

[Launchpad Janitor (janitor)]

This bug was fixed in the package python-eventlet - 0.13.0-1ubuntu2.3

---------------
python-eventlet (0.13.0-1ubuntu2.3) trusty-proposed; urgency=medium

  * SRU: LP: #1423675, LP: #1371291 (taken from 0.13.0-1ubuntu3.2).
  * Fix build failure with python2.7 and PEP 466.

 -- Matthias Klose <email address hidden> Sat, 12 Dec 2015 13:54:08 +0100

[Launchpad Janitor (janitor)]

This bug was fixed in the package python-gevent - 1.0-1ubuntu1.1

---------------
python-gevent (1.0-1ubuntu1.1) trusty-proposed; urgency=medium

  * SRU: LP: #1423675
  * Fix build failure with python2.7 and PEP 466.

 -- Matthias Klose <email address hidden> Sat, 12 Dec 2015 14:34:10 +0100