btrfs: compress-force needs clearing when remounting with compress option
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
linux (Ubuntu) |
Fix Released
|
Low
|
Colin Ian King | ||
Trusty |
Fix Released
|
Low
|
Colin Ian King | ||
Utopic |
Fix Released
|
Low
|
Colin Ian King |
Bug Description
SRU Justification: (Trusty, Utopic)
[Impact]
Remounting from compress-force to compress could not clear compress-force option. The problem is there is no way for users to clear compress-force option separately.
[Fix]
upstream commit 4027e0f4c4b2df2
"Btrfs: clear compress-force when remounting with compress option"
this is a simple one-liner, risk is low to zero.
[Testcase]
See attached hacked up bash script.btrfs: Without the fix I can reproduce the oops every time. With the fix, it works perfectly.
echo "MNT=$MNT"
echo "TMP=$TMP"
TMPIMG=
DEV=/dev/loop0
truncate --size 1500m $TMPIMG
losetup $DEV $TMPIMG
mkfs.btrfs -f $DEV
mount $DEV $MNT -o compress-force=lzo
mount $DEV $MNT -o remount,
n=$(cat /proc/mounts | grep $DEV | grep "compress-
umount $DEV
losetup -d $DEV
rm $TMPIMG
if [ $n -eq 0 ]; then
echo "compress-
exit 0
else
echo "compress-
exit 1
fi
Changed in linux (Ubuntu): | |
status: | New → In Progress |
importance: | Undecided → Low |
assignee: | nobody → Colin Ian King (colin-king) |
summary: |
- btrfs: ccompress-force needs clearing when remounting with compress + btrfs: compress-force needs clearing when remounting with compress option |
Changed in linux (Ubuntu Trusty): | |
status: | New → In Progress |
Changed in linux (Ubuntu Utopic): | |
status: | New → In Progress |
Changed in linux (Ubuntu Trusty): | |
importance: | Undecided → Low |
Changed in linux (Ubuntu Utopic): | |
importance: | Undecided → Low |
Changed in linux (Ubuntu Trusty): | |
assignee: | nobody → Colin Ian King (colin-king) |
Changed in linux (Ubuntu Utopic): | |
assignee: | nobody → Colin Ian King (colin-king) |
Changed in linux (Ubuntu Utopic): | |
status: | In Progress → Fix Committed |
Changed in linux (Ubuntu Trusty): | |
status: | In Progress → Fix Committed |
This was upstream as of v3.18-rc4, therefore vivid is already released; marking same.