Dash Previews don't scale correctly when the scale factor changes
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Unity |
Fix Released
|
High
|
Eleni Maria Stea | ||
7.2 |
Fix Released
|
High
|
Eleni Maria Stea | ||
unity (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
Trusty |
Fix Released
|
Undecided
|
Unassigned | ||
unity-lens-music (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
Trusty |
New
|
Undecided
|
Unassigned |
Bug Description
[Impact]
When scaling is set to a value different to 1.0 and the user performs a dash search and right clicks a result, the Preview is always rendered with scale factor 1.0.
[Test case]
1. From Unity Control Center -> Displays -> Change the monitor scaling to somewhat
different from 1.0 (might be both bigger and smaller, your choice).
2. Open the dash, [search something], right click over a result
3. The preview items should respect the previously set monitor scaling
[Regression potential]
This is a big change that involved lots of changes in the unity dash code, although we
didn't notice any regression due to this change. At the contrary we improved a lot the old code we worked on. Although it's still possible that some component of the dash previews might be hidden/distorted or not shown as it used to be.
Related branches
- PS Jenkins bot (community): Approve (continuous-integration)
- Eleni Maria Stea (community): Approve
- Marco Trevisan (Treviño): Approve
-
Diff: 4185 lines (+1053/-530)49 files modifieddash/DashView.cpp (+47/-42)
dash/DashView.h (+3/-2)
dash/PlacesGroup.cpp (+15/-9)
dash/ResultRendererHorizontalTile.cpp (+2/-2)
dash/ScopeView.cpp (+2/-0)
dash/StandaloneDash.cpp (+41/-27)
dash/previews/ActionButton.cpp (+9/-11)
dash/previews/ActionLink.cpp (+13/-0)
dash/previews/ActionLink.h (+2/-2)
dash/previews/ApplicationPreview.cpp (+38/-14)
dash/previews/GenericPreview.cpp (+8/-3)
dash/previews/MoviePreview.cpp (+3/-0)
dash/previews/MusicPaymentPreview.cpp (+103/-29)
dash/previews/MusicPaymentPreview.h (+1/-0)
dash/previews/MusicPreview.cpp (+96/-37)
dash/previews/MusicPreview.h (+5/-0)
dash/previews/PaymentPreview.cpp (+45/-17)
dash/previews/PaymentPreview.h (+3/-0)
dash/previews/Preview.cpp (+5/-4)
dash/previews/PreviewContainer.cpp (+40/-42)
dash/previews/PreviewContainer.h (+3/-2)
dash/previews/PreviewInfoHintWidget.cpp (+2/-2)
dash/previews/PreviewNavigator.cpp (+22/-5)
dash/previews/PreviewNavigator.h (+8/-4)
dash/previews/PreviewRatingsWidget.cpp (+3/-2)
dash/previews/PreviewRatingsWidget.h (+1/-1)
dash/previews/SocialPreview.cpp (+125/-50)
dash/previews/SocialPreview.h (+10/-0)
dash/previews/SocialPreviewComments.cpp (+16/-22)
dash/previews/SocialPreviewComments.h (+1/-5)
dash/previews/SocialPreviewContent.cpp (+33/-19)
dash/previews/SocialPreviewContent.h (+4/-1)
dash/previews/StandaloneApplicationPreview.cpp (+28/-13)
dash/previews/StandaloneErrorPreview.cpp (+18/-4)
dash/previews/StandaloneMoviePreview.cpp (+18/-3)
dash/previews/StandaloneMusicPaymentPreview.cpp (+17/-4)
dash/previews/StandaloneSocialPreview.cpp (+22/-8)
dash/previews/Track.cpp (+41/-18)
dash/previews/Track.h (+10/-3)
dash/previews/Tracks.cpp (+36/-5)
dash/previews/Tracks.h (+5/-0)
unity-shared/CoverArt.cpp (+17/-21)
unity-shared/DashStyle.cpp (+46/-29)
unity-shared/IconTexture.cpp (+7/-17)
unity-shared/PreviewStyle.cpp (+1/-1)
unity-shared/SearchBar.cpp (+10/-10)
unity-shared/SearchBarSpinner.cpp (+46/-28)
unity-shared/SearchBarSpinner.h (+3/-0)
unity-shared/UnitySettings.cpp (+19/-12)
- Marco Trevisan (Treviño): Approve
- PS Jenkins bot (community): Needs Fixing (continuous-integration)
- Unity Team: Pending requested
-
Diff: 576 lines (+207/-206)7 files modifieddash/previews/ApplicationPreview.cpp (+1/-1)
dash/previews/GenericPreview.cpp (+1/-1)
dash/previews/MoviePreview.cpp (+1/-1)
dash/previews/MusicPreview.cpp (+2/-2)
dash/previews/SocialPreview.cpp (+1/-1)
unity-shared/PreviewStyle.cpp (+155/-156)
unity-shared/PreviewStyle.h (+46/-44)
- Marco Trevisan (Treviño): Approve
- PS Jenkins bot (community): Approve (continuous-integration)
- Unity Team: Pending requested
-
Diff: 856 lines (+257/-109)15 files modifieddash/DashView.cpp (+5/-1)
dash/previews/ActionButton.cpp (+35/-9)
dash/previews/ActionButton.h (+4/-0)
dash/previews/Preview.cpp (+38/-5)
dash/previews/Preview.h (+4/-0)
dash/previews/PreviewContainer.cpp (+48/-3)
dash/previews/PreviewContainer.h (+4/-0)
dash/previews/PreviewInfoHintWidget.cpp (+73/-77)
dash/previews/PreviewInfoHintWidget.h (+9/-8)
dash/previews/StandaloneApplicationPreview.cpp (+4/-0)
decorations/DecorationsForceQuitDialog.cpp (+5/-0)
unity-shared/CoverArt.cpp (+18/-6)
unity-shared/CoverArt.h (+4/-0)
unity-shared/DecorationStyle.cpp (+4/-0)
unity-shared/PanelStyle.cpp (+2/-0)
- Marco Trevisan (Treviño): Approve
- PS Jenkins bot (community): Approve (continuous-integration)
- Unity Team: Pending requested
-
Diff: 455 lines (+162/-51)6 files modifieddash/previews/ApplicationPreview.cpp (+106/-41)
dash/previews/ApplicationPreview.h (+8/-0)
dash/previews/PreviewRatingsWidget.cpp (+37/-6)
dash/previews/PreviewRatingsWidget.h (+6/-0)
unity-shared/RatingsButton.cpp (+2/-2)
unity-shared/RatingsButton.h (+3/-2)
- Marco Trevisan (Treviño): Approve
- PS Jenkins bot (community): Approve (continuous-integration)
- Unity Team: Pending requested
-
Diff: 218 lines (+78/-26)2 files modifieddash/previews/GenericPreview.cpp (+71/-26)
dash/previews/GenericPreview.h (+7/-0)
- PS Jenkins bot (community): Approve (continuous-integration)
- Marco Trevisan (Treviño): Approve
- Unity Team: Pending requested
-
Diff: 163 lines (+55/-14)2 files modifieddash/previews/ErrorPreview.cpp (+53/-14)
dash/previews/ErrorPreview.h (+2/-0)
- PS Jenkins bot (community): Approve (continuous-integration)
- Marco Trevisan (Treviño): Approve
- Unity Team: Pending requested
-
Diff: 216 lines (+74/-22)2 files modifieddash/previews/MoviePreview.cpp (+68/-21)
dash/previews/MoviePreview.h (+6/-1)
- PS Jenkins bot (community): Approve (continuous-integration)
- Marco Trevisan (Treviño): Approve
- Unity Team: Pending requested
-
Diff: 47 lines (+15/-0)3 files modifieddash/previews/ApplicationPreview.cpp (+8/-0)
dash/previews/GenericPreview.cpp (+4/-0)
dash/previews/MoviePreview.cpp (+3/-0)
- Marco Trevisan (Treviño): Needs Fixing
- PS Jenkins bot (community): Needs Fixing (continuous-integration)
- Unity Team: Pending requested
-
Diff: 599 lines (+208/-88)6 files modifieddash/previews/SocialPreview.cpp (+96/-36)
dash/previews/SocialPreview.h (+9/-0)
dash/previews/SocialPreviewComments.cpp (+66/-41)
dash/previews/SocialPreviewComments.h (+11/-0)
dash/previews/SocialPreviewContent.cpp (+22/-11)
dash/previews/SocialPreviewContent.h (+4/-0)
- Marco Trevisan (Treviño): Approve
- PS Jenkins bot (community): Approve (continuous-integration)
- Unity Team: Pending requested
-
Diff: 292 lines (+88/-34)3 files modifieddash/previews/MusicPreview.cpp (+81/-32)
dash/previews/MusicPreview.h (+4/-0)
dash/previews/PreviewContainer.cpp (+3/-2)
- Marco Trevisan (Treviño): Approve
- PS Jenkins bot (community): Needs Fixing (continuous-integration)
- Unity Team: Pending requested
-
Diff: 608 lines (+174/-47)8 files modifieddash/previews/ActionLink.cpp (+13/-0)
dash/previews/ActionLink.h (+3/-2)
dash/previews/MusicPaymentPreview.cpp (+103/-29)
dash/previews/MusicPaymentPreview.h (+1/-0)
dash/previews/PaymentPreview.cpp (+44/-15)
dash/previews/PaymentPreview.h (+3/-0)
dash/previews/Preview.cpp (+4/-0)
dash/previews/StandaloneMusicPaymentPreview.cpp (+3/-1)
- PS Jenkins bot (community): Approve (continuous-integration)
- Marco Trevisan (Treviño): Pending requested
- Unity Team: Pending requested
-
Diff: 2316 lines (+479/-330)34 files modifieddash/DashView.cpp (+48/-46)
dash/DashView.h (+3/-2)
dash/PlacesGroup.cpp (+13/-9)
dash/StandaloneDash.cpp (+37/-18)
dash/previews/ActionButton.cpp (+9/-11)
dash/previews/ActionLink.h (+0/-1)
dash/previews/ApplicationPreview.cpp (+30/-14)
dash/previews/GenericPreview.cpp (+4/-3)
dash/previews/MusicPreview.cpp (+16/-6)
dash/previews/MusicPreview.h (+1/-0)
dash/previews/PaymentPreview.cpp (+2/-3)
dash/previews/Preview.cpp (+3/-6)
dash/previews/PreviewContainer.cpp (+24/-13)
dash/previews/PreviewContainer.h (+4/-1)
dash/previews/PreviewInfoHintWidget.cpp (+2/-2)
dash/previews/PreviewNavigator.cpp (+22/-5)
dash/previews/PreviewNavigator.h (+8/-4)
dash/previews/PreviewRatingsWidget.cpp (+3/-2)
dash/previews/PreviewRatingsWidget.h (+1/-1)
dash/previews/SocialPreview.cpp (+31/-16)
dash/previews/SocialPreview.h (+1/-0)
dash/previews/SocialPreviewComments.cpp (+41/-72)
dash/previews/SocialPreviewComments.h (+1/-16)
dash/previews/SocialPreviewContent.cpp (+15/-12)
dash/previews/SocialPreviewContent.h (+2/-3)
dash/previews/StandaloneMusicPaymentPreview.cpp (+1/-3)
dash/previews/StandaloneSocialPreview.cpp (+2/-2)
dash/previews/Track.cpp (+54/-15)
dash/previews/Track.h (+10/-3)
dash/previews/Tracks.cpp (+36/-5)
dash/previews/Tracks.h (+5/-0)
unity-shared/CoverArt.cpp (+1/-0)
unity-shared/DashStyle.cpp (+46/-29)
unity-shared/IconTexture.cpp (+3/-7)
- PS Jenkins bot (community): Approve (continuous-integration)
- Brandon Schaefer (community): Approve
-
Diff: 54 lines (+4/-5)3 files modifiedm4/gcov.m4 (+1/-1)
src/musicstore-scope.vala (+2/-3)
src/rhythmbox-collection.vala (+1/-1)
- Unity Team: Pending requested
-
Diff: 13027 lines (+3701/-2676)142 files modifiedUnityCore/GnomeSessionManager.cpp (+62/-14)
UnityCore/GnomeSessionManager.h (+2/-0)
UnityCore/GnomeSessionManagerImpl.h (+1/-0)
UnityCore/SessionManager.h (+3/-0)
dash/DashController.cpp (+2/-2)
dash/DashView.cpp (+55/-71)
dash/DashView.h (+3/-2)
dash/FilterBar.cpp (+8/-18)
dash/FilterBar.h (+0/-2)
dash/FilterBasicButton.cpp (+39/-46)
dash/FilterBasicButton.h (+6/-4)
dash/FilterExpanderLabel.cpp (+39/-41)
dash/FilterExpanderLabel.h (+2/-5)
dash/FilterGenreWidget.cpp (+33/-16)
dash/FilterGenreWidget.h (+1/-1)
dash/FilterMultiRangeButton.cpp (+22/-30)
dash/FilterMultiRangeButton.h (+3/-3)
dash/FilterMultiRangeWidget.cpp (+12/-1)
dash/FilterRatingsButton.cpp (+30/-223)
dash/FilterRatingsButton.h (+8/-21)
dash/FilterRatingsWidget.cpp (+22/-12)
dash/FilterRatingsWidget.h (+2/-1)
dash/PlacesGroup.cpp (+27/-29)
dash/ResultRendererHorizontalTile.cpp (+2/-2)
dash/ResultRendererTile.cpp (+18/-33)
dash/ScopeBar.cpp (+3/-1)
dash/ScopeBarIcon.cpp (+0/-1)
dash/ScopeView.cpp (+23/-23)
dash/ScopeView.h (+0/-1)
dash/StandaloneDash.cpp (+41/-27)
dash/previews/ActionButton.cpp (+43/-20)
dash/previews/ActionButton.h (+4/-0)
dash/previews/ActionLink.cpp (+13/-0)
dash/previews/ActionLink.h (+2/-2)
dash/previews/ApplicationPreview.cpp (+148/-62)
dash/previews/ApplicationPreview.h (+10/-0)
dash/previews/ErrorPreview.cpp (+53/-26)
dash/previews/ErrorPreview.h (+2/-0)
dash/previews/GenericPreview.cpp (+86/-42)
dash/previews/GenericPreview.h (+9/-1)
dash/previews/MoviePreview.cpp (+78/-34)
dash/previews/MoviePreview.h (+8/-1)
dash/previews/MusicPaymentPreview.cpp (+103/-41)
dash/previews/MusicPaymentPreview.h (+1/-0)
dash/previews/MusicPreview.cpp (+96/-37)
dash/previews/MusicPreview.h (+6/-0)
dash/previews/PaymentPreview.cpp (+59/-23)
dash/previews/PaymentPreview.h (+3/-0)
dash/previews/Preview.cpp (+42/-8)
dash/previews/Preview.h (+4/-0)
dash/previews/PreviewContainer.cpp (+62/-20)
dash/previews/PreviewContainer.h (+7/-2)
dash/previews/PreviewInfoHintWidget.cpp (+73/-77)
dash/previews/PreviewInfoHintWidget.h (+9/-8)
dash/previews/PreviewNavigator.cpp (+22/-5)
dash/previews/PreviewNavigator.h (+8/-4)
dash/previews/PreviewRatingsWidget.cpp (+31/-10)
dash/previews/PreviewRatingsWidget.h (+7/-2)
dash/previews/SocialPreview.cpp (+130/-61)
dash/previews/SocialPreview.h (+12/-0)
dash/previews/SocialPreviewComments.cpp (+16/-22)
dash/previews/SocialPreviewComments.h (+1/-5)
dash/previews/SocialPreviewContent.cpp (+33/-19)
dash/previews/SocialPreviewContent.h (+4/-1)
dash/previews/StandaloneApplicationPreview.cpp (+31/-12)
dash/previews/StandaloneErrorPreview.cpp (+18/-4)
dash/previews/StandaloneMoviePreview.cpp (+18/-3)
dash/previews/StandaloneMusicPaymentPreview.cpp (+17/-4)
dash/previews/StandaloneSocialPreview.cpp (+22/-8)
dash/previews/Track.cpp (+41/-18)
dash/previews/Track.h (+10/-3)
dash/previews/Tracks.cpp (+36/-7)
dash/previews/Tracks.h (+5/-1)
debian/changelog (+62/-1)
debian/patches/lp1349128.patch (+0/-164)
debian/patches/series (+0/-1)
hud/HudAbstractView.h (+3/-0)
hud/HudButton.cpp (+40/-28)
hud/HudButton.h (+5/-4)
hud/HudController.cpp (+15/-1)
hud/HudController.h (+4/-2)
hud/HudIcon.cpp (+1/-2)
hud/HudView.cpp (+52/-36)
hud/HudView.h (+2/-2)
hud/StandaloneHud.cpp (+28/-12)
launcher/Launcher.cpp (+1/-1)
launcher/SwitcherView.cpp (+11/-2)
launcher/SwitcherView.h (+1/-0)
lockscreen/LockScreenAcceleratorController.cpp (+46/-2)
lockscreen/LockScreenAcceleratorController.h (+2/-1)
lockscreen/LockScreenController.cpp (+13/-6)
lockscreen/LockScreenShield.cpp (+35/-22)
lockscreen/LockScreenShield.h (+3/-0)
lockscreen/UserPromptView.cpp (+0/-1)
plugins/unityshell/src/unityshell.cpp (+17/-13)
plugins/unityshell/src/unityshell.h (+1/-0)
resources/flow-view.svg (+0/-16)
resources/grid-view.svg (+0/-21)
resources/search_magnify.svg (+155/-0)
services/panel-service.c (+27/-5)
shutdown/SessionDBusManager.cpp (+23/-9)
shutdown/SessionView.cpp (+49/-30)
shutdown/SessionView.h (+6/-5)
shutdown/StandaloneSession.cpp (+2/-0)
tests/autopilot/unity/emulators/switcher.py (+4/-4)
tests/test_mock_session_manager.h (+2/-0)
tests/test_places_group.cpp (+34/-25)
tests/test_previews_payment.cpp (+1/-2)
tests/test_session_controller.cpp (+1/-0)
tests/test_session_view.cpp (+23/-2)
tools/unity.cmake (+14/-1)
unity-shared/CMakeLists.txt (+1/-0)
unity-shared/CoverArt.cpp (+37/-28)
unity-shared/CoverArt.h (+7/-3)
unity-shared/DashStyle.cpp (+260/-302)
unity-shared/DashStyle.h (+88/-94)
unity-shared/DashStyleInterface.h (+13/-11)
unity-shared/IconTexture.cpp (+7/-17)
unity-shared/OverlayRenderer.cpp (+129/-89)
unity-shared/OverlayRenderer.h (+1/-0)
unity-shared/OverlayScrollView.cpp (+56/-0)
unity-shared/OverlayScrollView.h (+43/-0)
unity-shared/PlacesOverlayVScrollBar.cpp (+47/-27)
unity-shared/PlacesOverlayVScrollBar.h (+6/-4)
unity-shared/PlacesVScrollBar.cpp (+54/-53)
unity-shared/PlacesVScrollBar.h (+6/-11)
unity-shared/PluginAdapter.cpp (+1/-0)
unity-shared/PreviewStyle.cpp (+155/-163)
unity-shared/PreviewStyle.h (+46/-45)
unity-shared/RatingsButton.cpp (+20/-20)
unity-shared/RatingsButton.h (+5/-4)
unity-shared/RawPixel.h (+1/-1)
unity-shared/SearchBar.cpp (+39/-32)
unity-shared/SearchBarSpinner.cpp (+48/-34)
unity-shared/SearchBarSpinner.h (+7/-4)
unity-shared/SpreadFilter.cpp (+2/-2)
unity-shared/TextInput.cpp (+6/-24)
unity-shared/TextInput.h (+0/-1)
unity-shared/TextureCache.cpp (+10/-3)
unity-shared/UnitySettings.cpp (+19/-12)
unity-shared/VScrollBarOverlayWindow.cpp (+49/-47)
unity-shared/VScrollBarOverlayWindow.h (+3/-1)
- Marco Trevisan (Treviño): Approve
-
Diff: 51 lines (+9/-3)4 files modifieddebian/changelog (+6/-0)
debian/control (+1/-1)
m4/gcov.m4 (+1/-1)
src/rhythmbox-collection.vala (+1/-1)
- Marco Trevisan (Treviño): Approve
-
Diff: 38 lines (+8/-2)3 files modifieddebian/changelog (+6/-0)
m4/gcov.m4 (+1/-1)
src/rhythmbox-collection.vala (+1/-1)
- Marco Trevisan (Treviño): Approve
-
Diff: 51 lines (+9/-3)4 files modifieddebian/changelog (+6/-0)
debian/control (+1/-1)
m4/gcov.m4 (+1/-1)
src/rhythmbox-collection.vala (+1/-1)
tags: | added: hidpi |
Changed in unity: | |
status: | New → In Progress |
importance: | Undecided → High |
assignee: | nobody → Eleni Maria Stea (hikiko) |
milestone: | none → 7.3.1 |
Changed in unity: | |
status: | In Progress → Fix Committed |
description: | updated |
tags: |
added: verification-done removed: verification-needed |
Changed in unity: | |
status: | Fix Committed → Fix Released |
This bug was fixed in the package unity - 7.3.0+14. 10.20140711- 0ubuntu1
--------------- 14.10.20140711- 0ubuntu1) utopic; urgency=low
unity (7.3.0+
[ Eleni Maria Stea ]
* Previews: scale the dash preview contents to match current monitor
scaling Improved also the scaling of search-bar, spinner, categories
and many other components. (LP: #1339629)
[ Marco Trevisan (Treviño) ] inner textures (and the other spinners as well) uses the
* Previews: scale the dash preview contents to match current monitor
scaling Improved also the scaling of search-bar, spinner, categories
and many other components. (LP: #1339629)
* DashStyle: return RawPixel's instead of integers for sizes, and
avoid duplication in code
* FilterWidgets: add support for scaling (LP: #1340171)
* OverlayRendering: correctly scale the overlays borders and edges to
match settings DashStyle has been modified to return smart pointers
of textures that are loaded depending on the scale level. The cache
will make sure that we don't duplicate the textures and that they
get removed when not needed anymore. Also thanks to this the
SearchBarSp
SVGs scaled at the proper size (I desgined a new SVG for the
magnifier, as we only had a PNG). (LP: #1283415)
* Hud: scale to match current DPI settings for monitor (LP: #1340477)
-- Ubuntu daily release <email address hidden> Fri, 11 Jul 2014 19:59:35 +0000