| 2014-07-23 15:54:46 |
Manoj Iyer |
bug |
|
|
added bug |
| 2014-07-23 15:54:46 |
Manoj Iyer |
attachment added |
|
Power control patch to enable soft shutdown https://bugs.launchpad.net/bugs/1347776/+attachment/4161049/+files/gpio_key_powercontrol.patch |
|
| 2014-07-23 16:28:31 |
Ubuntu Foundations Team Bug Bot |
tags |
|
bot-comment |
|
| 2014-07-23 16:47:27 |
Manoj Iyer |
branch linked |
|
lp:~manjo/ubuntu/trusty/systemd/HP-m800 |
|
| 2014-07-24 09:46:09 |
Martin Pitt |
affects |
ubuntu |
systemd (Ubuntu) |
|
| 2014-07-24 09:46:09 |
Martin Pitt |
systemd (Ubuntu): status |
New |
In Progress |
|
| 2014-07-24 09:46:21 |
Martin Pitt |
nominated for series |
|
Ubuntu Trusty |
|
| 2014-07-24 09:46:21 |
Martin Pitt |
bug task added |
|
systemd (Ubuntu Trusty) |
|
| 2014-07-24 09:46:21 |
Martin Pitt |
nominated for series |
|
Ubuntu Utopic |
|
| 2014-07-24 09:46:21 |
Martin Pitt |
bug task added |
|
systemd (Ubuntu Utopic) |
|
| 2014-08-05 15:56:03 |
Martin Pitt |
systemd (Ubuntu Utopic): status |
In Progress |
Fix Committed |
|
| 2014-08-05 15:56:10 |
Martin Pitt |
systemd (Ubuntu Trusty): status |
New |
In Progress |
|
| 2014-08-05 15:56:25 |
Martin Pitt |
systemd (Ubuntu Trusty): assignee |
|
Manoj Iyer (manjo) |
|
| 2014-08-05 21:25:59 |
Steve Langasek |
systemd (Ubuntu Trusty): status |
In Progress |
Fix Committed |
|
| 2014-08-05 21:26:03 |
Steve Langasek |
bug |
|
|
added subscriber Ubuntu Stable Release Updates Team |
| 2014-08-05 21:26:05 |
Steve Langasek |
bug |
|
|
added subscriber SRU Verification |
| 2014-08-05 21:26:07 |
Steve Langasek |
tags |
bot-comment |
bot-comment verification-needed |
|
| 2014-08-05 21:26:29 |
Manoj Iyer |
description |
Some ARM board uses GPIO gpio_key.12 for power control (key=116). The proposed patch adds entry to logind's 70-power-switch.rules to initiate soft shutdown of the cartridge from ilo.
Here is the udevadm output for /dev/input/event0
sudo udevadm info --query=all --name=/dev/input/event0 --attribute-walk
Udevadm info starts with the device specified by the devpath and then
walks up the chain of parent devices. It prints for every device
found, all possible attributes in the udev rules key format.
A rule to match, can be composed by the attributes of the device
and the attributes from one single parent device.
looking at device '/devices/soc.3/gpio_keys.12/input/input0/event0':
KERNEL=="event0"
SUBSYSTEM=="input"
DRIVER==""
looking at parent device '/devices/soc.3/gpio_keys.12/input/input0':
KERNELS=="input0"
SUBSYSTEMS=="input"
DRIVERS==""
ATTRS{name}=="gpio_keys.12"
ATTRS{phys}=="gpio-keys/input0"
ATTRS{uniq}==""
ATTRS{properties}=="0"
looking at parent device '/devices/soc.3/gpio_keys.12':
KERNELS=="gpio_keys.12"
SUBSYSTEMS=="platform"
DRIVERS=="gpio-keys"
ATTRS{keys}=="116"
ATTRS{switches}==""
ATTRS{disabled_keys}==""
ATTRS{disabled_switches}==""
looking at parent device '/devices/soc.3':
KERNELS=="soc.3"
SUBSYSTEMS=="platform"
DRIVERS==""
Regarding the possibility of gpio_key.12 being used by other systems to map to some other trigger, I put in the check that the gpio_key.12 is associated with power control (keys=116). '116' is supposedly linux generic power control in DTS. There is no uniq idSystem or idVendor for device /dev/input/event0 as you can see from udevadm output, therefore I tried to use the best available combination as a safety check. This patch will enable power control for any system vendor (Other than the one the patch in intended for) that describes in DTS, the trigger gpio_key.12 as power control (116). |
Some ARM board uses GPIO gpio_key.12 for power control (key=116). The proposed patch adds entry to logind's 70-power-switch.rules to initiate soft shutdown of the cartridge from ilo.
Here is the udevadm output for /dev/input/event0
sudo udevadm info --query=all --name=/dev/input/event0 --attribute-walk
Udevadm info starts with the device specified by the devpath and then
walks up the chain of parent devices. It prints for every device
found, all possible attributes in the udev rules key format.
A rule to match, can be composed by the attributes of the device
and the attributes from one single parent device.
looking at device '/devices/soc.3/gpio_keys.12/input/input0/event0':
KERNEL=="event0"
SUBSYSTEM=="input"
DRIVER==""
looking at parent device '/devices/soc.3/gpio_keys.12/input/input0':
KERNELS=="input0"
SUBSYSTEMS=="input"
DRIVERS==""
ATTRS{name}=="gpio_keys.12"
ATTRS{phys}=="gpio-keys/input0"
ATTRS{uniq}==""
ATTRS{properties}=="0"
looking at parent device '/devices/soc.3/gpio_keys.12':
KERNELS=="gpio_keys.12"
SUBSYSTEMS=="platform"
DRIVERS=="gpio-keys"
ATTRS{keys}=="116"
ATTRS{switches}==""
ATTRS{disabled_keys}==""
ATTRS{disabled_switches}==""
looking at parent device '/devices/soc.3':
KERNELS=="soc.3"
SUBSYSTEMS=="platform"
DRIVERS==""
Regarding the possibility of gpio_key.12 being used by other systems to map to some other trigger, I put in the check that the gpio_key.12 is associated with power control (keys=116). '116' is supposedly linux generic power control in DTS. There is no uniq idSystem or idVendor for device /dev/input/event0 as you can see from udevadm output, therefore I tried to use the best available combination as a safety check. This patch will enable power control for any system vendor (Other than the one the patch in intended for) that describes in DTS, the trigger gpio_key.12 as power control (116).
SRU Request
==========
[Impact]
* User won't be able to initiate a soft shutdown from the chassis manager.
[Test Case]
* To reproduce this bug, initiate a soft shutdown from the chassis manager, for example from ilo you could do
<ilo> set node power off shutdown <node number>
[Test Result]
== BEFORE PATCH ==
$ cat /lib/udev/rules.d/70-power-switch.rules
# This file is part of systemd.
#
# systemd is free software; you can redistribute it and/or modify it
# under the terms of the GNU Lesser General Public License as published by
# the Free Software Foundation; either version 2.1 of the License, or
# (at your option) any later version.
ACTION=="remove", GOTO="power_switch_end"
SUBSYSTEM=="input", KERNEL=="event*", SUBSYSTEMS=="acpi", TAG+="power-switch"
SUBSYSTEM=="input", KERNEL=="event*", KERNELS=="thinkpad_acpi", TAG+="power-switch"
LABEL="power_switch_end"
$
</>hpiLO-> set node power off shutdown c3n2
c3: #Cartridge 3
c3n2: #Node 2 Shutting node down gracefully
hpiLO-> show node list
Slot ID Proc Manufacturer Architecture Memory Power Health
---- ----- ---------------------- -------------------- ------ ----- ------
3 c3n1 **** ARM Architecture 8 GB On OK
3 c3n2 **** ARM Architecture 8 GB On OK
3 c3n3 **** ARM Architecture 8 GB On OK
3 c3n4 **** ARM Architecture 8 GB Off OK
hpiLO->
== AFTER PATCH ==
hpiLO-> set node power off shutdown c3n1
c3: #Cartridge 3
c3n1: #Node 1 Shutting node down gracefully
hpiLO-> show node list
Slot ID Proc Manufacturer Architecture Memory Power Health
---- ----- ---------------------- -------------------- ------ ----- ------
3 c3n1 **** ARM Architecture 8 GB Off OK
3 c3n2 **** ARM Architecture 8 GB On OK
3 c3n3 **** ARM Architecture 8 GB On OK
3 c3n4 **** ARM Architecture 8 GB Off OK
hpiLO->
[Regression Potential]
None.
Note: Regarding the possibility of gpio_key.12 being used by other systems to map to some other trigger, I put in the check that the gpio_key.12 is associated with power control (keys=116). '116' is supposedly linux generic power control in DTS. |
|
| 2014-08-06 19:07:57 |
Kodamati Pradeep Vinesh Reddy |
tags |
bot-comment verification-needed |
bot-comment verification-done |
|
| 2014-08-07 11:16:50 |
Launchpad Janitor |
systemd (Ubuntu Utopic): status |
Fix Committed |
Fix Released |
|
| 2014-08-08 13:03:54 |
dann frazier |
bug watch added |
|
https://bugs.freedesktop.org/show_bug.cgi?id=82347 |
|
| 2014-08-08 13:03:54 |
dann frazier |
bug task added |
|
systemd |
|
| 2014-08-08 14:32:29 |
Bug Watch Updater |
systemd: status |
Unknown |
Confirmed |
|
| 2014-08-08 14:32:29 |
Bug Watch Updater |
systemd: importance |
Unknown |
Medium |
|
| 2014-08-14 12:13:04 |
Scott Kitterman |
removed subscriber Ubuntu Stable Release Updates Team |
|
|
|
| 2014-08-14 12:18:19 |
Launchpad Janitor |
systemd (Ubuntu Trusty): status |
Fix Committed |
Fix Released |
|
| 2015-12-05 00:13:52 |
Lucas Magasweran |
attachment added |
|
gpio-keys-polled-sysfs-keys.patch https://bugs.launchpad.net/ubuntu/+source/systemd/+bug/1347776/+attachment/4529893/+files/gpio-keys-polled-sysfs-keys.patch |
|
| 2016-02-15 21:04:03 |
Bug Watch Updater |
systemd: status |
Confirmed |
Fix Released |
|
