Update request: skiboot 5.1.9 for OpenPower machines

Bug #1512188 reported by Jeremy Kerr
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
skiboot (Ubuntu)
Fix Released
Undecided
Taco Screen team
Trusty
Fix Released
Undecided
Steve Langasek
Wily
Won't Fix
Undecided
Steve Langasek

Bug Description

Trusty through xenial currently have version 5.1.1 of the skiboot source package (producing opal-prd and opal-utils binary packages), while we've had a number of updates since, which introduce compatibility for newer hardware & firmware facilities.

Can we have this updated to a more recent skiboot version?

Jeremy Kerr (jk-ozlabs)
tags: added: taco-screen-team
tags: added: upgrade-software-version
Changed in skiboot (Ubuntu):
assignee: nobody → Taco Screen team (taco-screen-team)
Steve Langasek (vorlon)
Changed in skiboot (Ubuntu Trusty):
assignee: nobody → Steve Langasek (vorlon)
Revision history for this message
Steve Langasek (vorlon) wrote :

I've uploaded skiboot 5.1.13 to xenial, trusty, and wily. However, before it can be accepted for SRU into the stable releases, we would need a test plan for validating this update. How will we ensure that the new binary package hasn't regressed anything, vs. the 5.1.1 currently in the release?

The added hardware support is sufficient justification for the SRU, we just need to also be sure that we aren't regressing existing hardware support.

Changed in skiboot (Ubuntu Wily):
assignee: nobody → Steve Langasek (vorlon)
Changed in skiboot (Ubuntu Trusty):
status: New → Incomplete
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package skiboot - 5.1.13-0ubuntu1

---------------
skiboot (5.1.13-0ubuntu1) xenial; urgency=medium

  * New upstream release, adding support for newer hardware and firmware.
    LP: #1512188.
    - drop no longer needed parts of debian/patches/uninitialized_uses.patch.

 -- Steve Langasek <email address hidden> Thu, 04 Feb 2016 11:05:13 -0800

Changed in skiboot (Ubuntu):
status: New → Fix Released
Revision history for this message
Cédric Le Goater (clg) wrote :

Hi,

There is a small issue with the systemd opal-prd.service file :

    ExecStart=/usr/sbin/opal-prd

it should specify the mtd device, as done in the upstart and init scripts :

    ExecStart=/usr/sbin/opal-prd --pnor /dev/mtd0

I have a couple of openpower systems running xenial, so I can give
a hand with non regression.

Thanks,

C.

Revision history for this message
Steve Langasek (vorlon) wrote : Re: [Bug 1512188] Re: Update request: skiboot 5.1.9 for OpenPower machines

On Fri, Feb 05, 2016 at 04:28:18PM -0000, Cédric Le Goater wrote:
> There is a small issue with the systemd opal-prd.service file :

> ExecStart=/usr/sbin/opal-prd

> it should specify the mtd device, as done in the upstart and init
> scripts :

> ExecStart=/usr/sbin/opal-prd --pnor /dev/mtd0

Thanks, I've uploaded this fix.

> I have a couple of openpower systems running xenial, so I can give
> a hand with non regression.

Since this is a question of SRUs, it's not systems running xenial that are
of concern, but rather systems running trusty and wily. I also don't know
which systems are already supported by the version of opal-prd in trusty;
are the openpower systems the only ones we need to watch for regressions on,
or are there others?

Revision history for this message
Jeremy Kerr (jk-ozlabs) wrote :

Hi Steve,

> I also don't know
> which systems are already supported by the version of opal-prd in trusty;
> are the openpower systems the only ones we need to watch for regressions on,
> or are there others?

The former: opal-prd is only used on OpenPOWER machines, so that's all we'll need to watch for regressions on here.

Revision history for this message
Jeremy Kerr (jk-ozlabs) wrote :

Also, for completeness: running the PRD daemon is only required on machines that have the "diagnostics" OPAL firmware feature. At present (and this is unlikely to change), the set of these machines is equivalent to the set of OpenPOWER machines.

To be exact, this is indicated on a running system by the presence of a "diagnostics" device-tree node under the firmware one, which has a compatible value of "ibm,opal-prd".

Revision history for this message
Chris Halse Rogers (raof) wrote :

The most important part of Steve's questions seems to have been missed here - what testing needs to be done. Is it a simple matter of booting the machine and checking that it does indeed still boot, or does it require a specific workload, or series of testing steps?

Are there people ready and able to test this on trusty and wily?

Revision history for this message
Jeremy Kerr (jk-ozlabs) wrote :

For testing, a suitable check would be to ensure that the opal-prd daemon is running; just a successful boot, then `service opal-prd status` would be fine (and that also covers the --pnor argument too).

We can certainly test this on trusty and wily here.

Revision history for this message
Cédric Le Goater (clg) wrote :

I just installed a trusty on a OpenPOWER system (Habanero). Firmware is v1.8
and it is running a linux-image-generic-lts-xenial.

How do I pull the newer opal-prd to give it a try ?

Revision history for this message
Brian Murray (brian-murray) wrote : Please test proposed package

Hello Jeremy, or anyone else affected,

Accepted skiboot into wily-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/skiboot/5.1.13-0ubuntu1~15.10.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in skiboot (Ubuntu Wily):
status: New → Fix Committed
tags: added: verification-needed
Changed in skiboot (Ubuntu Trusty):
status: Incomplete → Fix Committed
Revision history for this message
Brian Murray (brian-murray) wrote :

Hello Jeremy, or anyone else affected,

Accepted skiboot into trusty-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/skiboot/5.1.13-0ubuntu1~14.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Revision history for this message
Ubuntu Foundations Team Bug Bot (crichton) wrote : [skiboot/wily] verification still needed

The fix for this bug has been awaiting testing feedback in the -proposed repository for wily for more than 90 days. Please test this fix and update the bug appropriately with the results. In the event that the fix for this bug is still not verified 15 days from now, the package will be removed from the -proposed repository.

tags: added: removal-candidate
Revision history for this message
Jeremy Kerr (jk-ozlabs) wrote :

Sorry - missed this one. The update is fine for xenial, testing with trusty now.

Revision history for this message
Jeremy Kerr (jk-ozlabs) wrote :

OK, all fine on trusty! Now checking wily.

tags: added: verification-done
removed: removal-candidate verification-needed
Revision history for this message
Jeremy Kerr (jk-ozlabs) wrote :

Wait, wily has EOLed now. So, I am removing the verification-needed tag, and adding verification-done.

If you need me to test on any particular version, please let me know which.

Steve Langasek (vorlon)
Changed in skiboot (Ubuntu Wily):
status: Fix Committed → Won't Fix
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package skiboot - 5.1.13-0ubuntu1~14.04.1

---------------
skiboot (5.1.13-0ubuntu1~14.04.1) trusty; urgency=medium

  * New upstream release, adding support for newer hardware and firmware.
    LP: #1512188.
    - drop no longer needed parts of debian/patches/uninitialized_uses.patch.

 -- Steve Langasek <email address hidden> Thu, 04 Feb 2016 11:05:13 -0800

Changed in skiboot (Ubuntu Trusty):
status: Fix Committed → Fix Released
Revision history for this message
Steve Langasek (vorlon) wrote : Update Released

The verification of the Stable Release Update for skiboot has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.