[FFE] ship skiboot (opal-prd) 5.1.1

[Frédéric Bonnard]

[Impact]
Users of ppc64el POWER8 hardware / OPAL firmwares

[Test case]
Testing this software requires real POWER8 hardware.
1) Run opal-prd on a POWER8 system
2) Verify that the daemon runs and is listening on /dev/opal-prd (which needs to be provided by the kernel)
3) *TBD* (see below, firmware-provided code may be executed depending on received events)

[Regression Potential]
Minimal. This is hardware enablement software, not previously available in Ubuntu, which is done in cooperation with and at the request of the hardware manufacturer.

---

This is a bug to track the inclusion of opal-prd package in Ubuntu. The plan is to add it initially for 15.10 and later backport it to 14.04 archive.

opal-prd is a daemon that listens for hardware diagnostic events (by listening on the /dev/opal-prd device), and executes firmware-providedexecutable code to handle these events.

For now, the code lives inside https://github.com/open-power/skiboot/tree/master/external/opal-prd.

opal-prd/skiboot is specific to ppc64el

[Frédéric Bonnard (frediz)]

Here is a packaging for opal-prd based on what Jeremy Kerr did with some improvements.
As I understand, we need opal-prd kernel headers which is tracked in https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1439562 .
For the time being, Jeremy provided me a -linux-libc-dev .deb for 14.10 so I tested everything on 14.10 so far.
Here are the files attached. debian/changelog should be changed otherwise there should be no lintian, just a pedantic one for debian-watch-may-check-gpg-signature .

[Breno Leitão (breno-leitao)]

Important to say that this is not going to be added in Debian ATM because Debian kernel package still miss the PRD patches (tracked at 1439562 for Ubuntu). This should be added to Debian when kernel 4.2 makes sid.

[Mathieu Trudel-Lapierre (cyphermox)]

For this we're still blocked on https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1464560 being fixed; we don't have the required uapi/asm/opal-prd.h filed shipped in the current 3.19 kernels.

[Breno Leitão (breno-leitao)]

Hi Mathieu,

We expect to have this bug fixed by 14.04.3 release. Isn't it possible to use kernel 4.1, which has this patch already according to 1464560 in order to fast the package inclusion process?

[Mathieu Trudel-Lapierre (cyphermox)]

I'm bundling the required header in the package now, should unblock it from bug 1464560

[Jeremy Kerr (jk-ozlabs)]

We've had a couple of bugfix changes go into upstream recently; I'd suggest picking up the current stable branch, at or beyond commit 14d4ffa7.

This should get a tag for 5.0.6 any day now.

[Jeremy Kerr (jk-ozlabs)]

OK, 5.1.1 has just been tagged, that would be a great place to base this on, as it has added support for future OpenPower platforms.

Ubuntu folks: do you need anything from IBM for this package?

[Frédéric Bonnard (frediz)]

Jeremy, is upgrade to 5.1.1 required ?
For trusty I guess canonical would prefer to change the version as less as possible.
So, do we require this right away, orshould we wait an upcoming version which will bundles more important stuff later ?
Thanks for your insight.

[Jeremy Kerr (jk-ozlabs)]

Hi Frédéric,

The upgrade gives us Firestone platform support, and will mean we'll be using code that has gone through IBM's own testing procedures.

Including 5.1.1 would mean fewer changes - there's no package in any Ubuntu release yet, so there should be no trouble starting from this version, and it means that we don't need an update for Firestone support.

[Breno Leitão (breno-leitao)]

On Mon, Aug 24, 2015 at 9:38 PM, Jeremy Kerr <email address hidden> wrote:

> Hi Frédéric,
>
> The upgrade gives us Firestone platform support, and will mean we'll be
> using code that has gone through IBM's own testing procedures.
>
> Including 5.1.1 would mean fewer changes - there's no package in any
> Ubuntu release yet, so there should be no trouble starting from this
> version, and it means that we don't need an update for Firestone
> support.
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1467542
>
> Title:
> Add new userspace package 'opal-prd'
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/ubuntu/+bug/1467542/+subscriptions
>

[Breno Leitão (breno-leitao)]

> there's no package in any

That is not true. Wily (15.10) has the inital 5.0.4 version. We just
need to backport it to 14.04.3 IMO, if no further package upgrade is
required.

$ apt-cache madison opal-prd
  opal-prd | 5.0.4-0ubuntu2 | http://ports.ubuntu.com/ubuntu-ports/
wily/universe ppc64el Packages
   skiboot | 5.0.4-0ubuntu2 | http://archive.ubuntu.com/ubuntu/
wily/universe Sources

[Mathieu Trudel-Lapierre (cyphermox)]

Reassigning to skiboot; so we can do a Feature Freeze Exception

[Mathieu Trudel-Lapierre (cyphermox)]

Changes for 5.0 to 5.1.0.

[Mathieu Trudel-Lapierre (cyphermox)]

Changes for 5.1.0 to 5.1.1

[Jeremy Kerr (jk-ozlabs)]

> > there's no package in any
>
> That is not true. Wily (15.10) has the inital 5.0.4 version.

You trimmed off the part where it said "Ubuntu release" - wily isn't released yet. :)

@mathieu-tl: looks good!

[Mathieu Trudel-Lapierre (cyphermox)]

$ sudo apt-get install opal-prd opal-utils
Reading package lists... Done
Building dependency tree
Reading state information... Done
The following packages will be upgraded:
  opal-prd opal-utils
2 upgraded, 0 newly installed, 0 to remove and 0 not upgraded.
Need to get 54.8 kB of archives.
After this operation, 0 B of additional disk space will be used.
Get:1 http://ppa.launchpad.net/mathieu-tl/installer-dev/ubuntu/ wily/main opal-prd ppc64el 5.1.1-0ubuntu1~mtrudel2 [31.3 kB]
Get:2 http://ppa.launchpad.net/mathieu-tl/installer-dev/ubuntu/ wily/main opal-utils ppc64el 5.1.1-0ubuntu1~mtrudel2 [23.5 kB]
Fetched 54.8 kB in 0s (66.7 kB/s)
(Reading database ... 49266 files and directories currently installed.)
Preparing to unpack .../opal-prd_5.1.1-0ubuntu1~mtrudel2_ppc64el.deb ...
Warning: Stopping opal-prd.service, but it can still be activated by:
  opal-prd.socket
Unpacking opal-prd (5.1.1-0ubuntu1~mtrudel2) over (5.0.4-0ubuntu2) ...
Preparing to unpack .../opal-utils_5.1.1-0ubuntu1~mtrudel2_ppc64el.deb ...
Unpacking opal-utils (5.1.1-0ubuntu1~mtrudel2) over (5.0.4-0ubuntu2) ...
Processing triggers for man-db (2.7.2-1) ...
Processing triggers for ureadahead (0.100.0-19) ...
Processing triggers for systemd (224-1ubuntu3) ...
Setting up opal-prd (5.1.1-0ubuntu1~mtrudel2) ...
Setting up opal-utils (5.1.1-0ubuntu1~mtrudel2) ...

[Breno Leitão (breno-leitao)]

On Tue, Aug 25, 2015 at 11:01 PM, Jeremy Kerr <email address hidden> wrote:
> You trimmed off the part where it said "Ubuntu release" - wily isn't
> released yet. :)
You are officially correct! :-)

Regarding to 5.1.1 release, Thanks Mathieu for pushing it. I
understand that the only missing thing here is 'backporting' this
package to 15.10 and, then, to 14.04 archive, Is it correctt?

[Mathieu Trudel-Lapierre (cyphermox)]

Well, yes. Once it's in 15.10 we can get it in 14.04.

[Breno Leitão (breno-leitao)]

Thank Mathieu!

On Wed, Aug 26, 2015 at 12:05 PM, Mathieu Trudel-Lapierre
<email address hidden> wrote:
> Well, yes. Once it's in 15.10 we can get it in 14.04.
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1467542
>
> Title:
> [FFE] ship skiboot (opal-prd) 5.1.1
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/ubuntu/+source/skiboot/+bug/1467542/+subscriptions

[Steve Langasek (vorlon)]

As this is a hardware support package (which as you say has not yet been in an Ubuntu release so no risk of regression), which is provided in cooperation with and at the request of the hardware manufacturer, and which we will want to include as an HWE update on 14.04: FFe granted.

[Mathieu Trudel-Lapierre (cyphermox)]

Jeremy, Frederick or Breno; I've updated the description to explain how testing can be done for this when making it available on 14.04, but what I could add was quite limited. Any other details you could share on how testing should be done for this?

[Mathieu Trudel-Lapierre (cyphermox)]

skiboot (5.1.1-0ubuntu1) wily; urgency=medium

  * New upstream release.
  * Dropped patches; applied upstream:
    - 0001-external-gard-add-Makefile-targets-to-make-debian-pa.patch
    - 0001-Honor-compilation-flags-passed-from-the-environment.patch
    - 0001-Fixes-for-compilation-with-Werror.patch
  * debian/patches/uninitialized_uses.patch: fix up uninitialized variables
    that make our build fail

[Frédéric Bonnard (frediz)]

Mathieu, thanks a bunch for this.
On the Debian side, it would be nice to push for it.
Do you have the possibility to sponsor that ?
Jeremy, I know that there are some needs on the kernel side, but there is a 4.2
in experimental, would it be enough ?

Fred

On Tue, 01 Sep 2015 17:14:37 -0000, Mathieu Trudel-Lapierre <email address hidden> wrote:
> skiboot (5.1.1-0ubuntu1) wily; urgency=medium
>
> * New upstream release.
> * Dropped patches; applied upstream:
> - 0001-external-gard-add-Makefile-targets-to-make-debian-pa.patch
> - 0001-Honor-compilation-flags-passed-from-the-environment.patch
> - 0001-Fixes-for-compilation-with-Werror.patch
> * debian/patches/uninitialized_uses.patch: fix up uninitialized variables
> that make our build fail
>
> ** Changed in: skiboot (Ubuntu)
> Status: In Progress => Fix Released
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1467542
>
> Title:
> [FFE] ship skiboot (opal-prd) 5.1.1
>
> Status in skiboot package in Ubuntu:
> Fix Released
> Status in skiboot source package in Trusty:
> In Progress
>
> Bug description:
> [Impact]
> Users of ppc64el POWER8 hardware / OPAL firmwares
>
> [Test case]
> Testing this software requires real POWER8 hardware.
> 1) Run opal-prd on a POWER8 system
> 2) Verify that the daemon runs and is listening on /dev/opal-prd (which needs to be provided by the kernel)
> 3) *TBD* (see below, firmware-provided code may be executed depending on received events)
>
> [Regression Potential]
> Minimal. This is hardware enablement software, not previously available in Ubuntu, which is done in cooperation with and at the request of the hardware manufacturer.
>
> ---
>
> This is a bug to track the inclusion of opal-prd package in Ubuntu.
> The plan is to add it initially for 15.10 and later backport it to
> 14.04 archive.
>
> opal-prd is a daemon that listens for hardware diagnostic events (by
> listening on the /dev/opal-prd device), and executes firmware-
> providedexecutable code to handle these events.
>
> For now, the code lives inside https://github.com/open-
> power/skiboot/tree/master/external/opal-prd.
>
> opal-prd/skiboot is specific to ppc64el
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/ubuntu/+source/skiboot/+bug/1467542/+subscriptions
>

[Mathieu Trudel-Lapierre (cyphermox)]

Sorry, I can't sponsor this in Debian, but I can probably find someone who could.

As for the backport to 14.04; the package is in the queue for Trusty, awaiting review by archive admins/SRU team.

[Jeremy Kerr (jk-ozlabs)]

> Jeremy, I know that there are some needs on the kernel side, but there is a 4.2
> in experimental, would it be enough ?

Yes, that has the headers required.

[Frédéric Bonnard (frediz)]

> Sorry, I can't sponsor this in Debian, but I can probably find someone
> who could.

That'd be nice ; give him/her my mail if I can be of any help in that process.
In addition, I opened an ITP on Debian :
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=797987

Jeremy said linux 4.2 should have everything.
I see it's in experimental but not in unstable ; is that ok to start ?

> As for the backport to 14.04; the package is in the queue for Trusty,
> awaiting review by archive admins/SRU team.

I saw that on https://launchpad.net/ubuntu/trusty/+queue
Thanks!

F.

>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1467542
>
> Title:
> [FFE] ship skiboot (opal-prd) 5.1.1
>
> Status in skiboot package in Ubuntu:
> Fix Released
> Status in skiboot source package in Trusty:
> In Progress
>
> Bug description:
> [Impact]
> Users of ppc64el POWER8 hardware / OPAL firmwares
>
> [Test case]
> Testing this software requires real POWER8 hardware.
> 1) Run opal-prd on a POWER8 system
> 2) Verify that the daemon runs and is listening on /dev/opal-prd (which needs to be provided by the kernel)
> 3) *TBD* (see below, firmware-provided code may be executed depending on received events)
>
> [Regression Potential]
> Minimal. This is hardware enablement software, not previously available in Ubuntu, which is done in cooperation with and at the request of the hardware manufacturer.
>
> ---
>
> This is a bug to track the inclusion of opal-prd package in Ubuntu.
> The plan is to add it initially for 15.10 and later backport it to
> 14.04 archive.
>
> opal-prd is a daemon that listens for hardware diagnostic events (by
> listening on the /dev/opal-prd device), and executes firmware-
> providedexecutable code to handle these events.
>
> For now, the code lives inside https://github.com/open-
> power/skiboot/tree/master/external/opal-prd.
>
> opal-prd/skiboot is specific to ppc64el
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/ubuntu/+source/skiboot/+bug/1467542/+subscriptions
>

[Adam Conrad (adconrad)]

Hello Frédéric, or anyone else affected,

Accepted skiboot into trusty-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/skiboot/5.1.1-0ubuntu1~14.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Adam Conrad (adconrad)]

Hello Frédéric, or anyone else affected,

Accepted skiboot into vivid-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/skiboot/5.1.1-0ubuntu1~15.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Stewart Smith (stewart-ibm)]

Just to make the timing fun, I just tagged skiboot-5.1.2 (full release notes here: https://github.com/open-power/skiboot/blob/skiboot-5.1.2/doc/release-notes/skiboot-5.1.2.txt ) with the following opal_prd fixes:

- opal_prd utility:
  - Add run command to pass through commands to HostBoot RunTime (HBRT)
    - this is for OpenPower firmware developers only.
  - Add htmght-passthru command.
    - this is for OpenPower firmware developers only.
  - Add override interface to pass attribute-override information to HBRT.
  - Server sends response in error path, so that client doesn't block forever

While none of these are likely urgent, they're all fairly minor improvements/bug fixes that may be useful to package.

- gard utility:
  - If gard tool detects the GUARD PNOR partition is corrupted, it will
    pro-actively re-initialize it.
    Modern Hostboot is more sensitive to the content of the GUARD partition
    in order to boot.
  - Update record clearing to match Hostboots expectations
    We now write ECC bytes throughout the whole partition.
    Without this fix, hostboot may not bring up the machine.
  - In the event of a corrupted GUARD partition so that even the first entry
    cannot be read, the gard utility now provides the user with the option
    to wipe the entirety of the GUARD partition to attempt recovery.

Which are fairly needed bug fixes to the opal-gard utility for more modern firmware builds.

From the 5.1.1 packaging, I see there's a small (obvious) patch to gard and libffs which I'd be happy to take - if someone could mail it to <email address hidden> with a signed-off-by line, I'd happily merge it.

[Mathieu Trudel-Lapierre (cyphermox)]

A new release of skiboot should have a new bug with the appropriate Feature Freeze Exception information for the request -- from what I see, it doesn't only contain bug fixes but also new features.

I'll send the patch now.

[Thierry FAUCK (thierry-j)]

Trying to access a system to validate the bug

[Thierry FAUCK (thierry-j)]

On VIVID, I get the following messages in /var/log/syslog - need to check why

Sep 15 09:37:55 abanb systemd[1]: Starting OPAL PRD daemon...
Sep 15 09:37:55 abanb opal-prd: I2C: Found Chip: 80000001 engine 0 port 0
Sep 15 09:37:55 abanb opal-prd: I2C: Found Chip: 80000001 engine 0 port 1
Sep 15 09:37:55 abanb opal-prd: I2C: Found Chip: 00000000 engine 0 port 0
Sep 15 09:37:55 abanb opal-prd: I2C: Found Chip: 00000000 engine 0 port 1
Sep 15 09:37:55 abanb opal-prd: I2C: Found Chip: 00000000 engine 1 port 2
Sep 15 09:37:55 abanb opal-prd: I2C: Found Chip: 80000004 engine 0 port 0
Sep 15 09:37:55 abanb opal-prd: I2C: Found Chip: 80000004 engine 0 port 1
Sep 15 09:37:55 abanb opal-prd: I2C: Found Chip: 80000000 engine 0 port 0
Sep 15 09:37:55 abanb opal-prd: I2C: Found Chip: 80000000 engine 0 port 1
Sep 15 09:37:55 abanb opal-prd: I2C: Found Chip: 80000005 engine 0 port 0
Sep 15 09:37:55 abanb opal-prd: I2C: Found Chip: 80000005 engine 0 port 1
Sep 15 09:37:55 abanb opal-prd: CTRL: Listening on control socket /run/opal-prd-control
Sep 15 09:37:55 abanb opal-prd: FW: Can't open PRD device /dev/opal-prd: No such file or directory
Sep 15 09:37:55 abanb opal-prd: FW: Error initialising PRD channel
Sep 15 09:37:55 abanb systemd[1]: opal-prd.service: main process exited, code=exited, status=1/FAILURE
Sep 15 09:37:55 abanb systemd[1]: Unit opal-prd.service entered failed state.
Sep 15 09:37:55 abanb systemd[1]: opal-prd.service failed.

[Thierry FAUCK (thierry-j)]

That was with kernel 3.16.0-44 which doesn't include module for opal-prd.
With kernel 3.19.0-28, /etc/init.d/opal-prd start --> OK
/dev/opal-prd exists
# opal-prd --debug --stdio
I2C: Found Chip: 80000001 engine 0 port 0
I2C: Found Chip: 80000001 engine 0 port 1
I2C: Found Chip: 00000000 engine 0 port 0
I2C: Found Chip: 00000000 engine 0 port 1
I2C: Found Chip: 00000000 engine 1 port 2
I2C: Found Chip: 80000004 engine 0 port 0
I2C: Found Chip: 80000004 engine 0 port 1
I2C: Found Chip: 80000000 engine 0 port 0
I2C: Found Chip: 80000000 engine 0 port 1
I2C: Found Chip: 80000005 engine 0 port 0
I2C: Found Chip: 80000005 engine 0 port 1
CTRL: Listening on control socket /run/opal-prd-control
FW: 5 PRD ranges, instances assigned by firmware
FW: 0000000ffd4b0000-0000000ffd6dffff ibm,hbrt-code-image
FW: 0000000ffd6e0000-0000000ffd6fffff ibm,hbrt-target-image
FW: 0000000ffd700000-0000000ffd7fffff ibm,hbrt-vpd-image
FW: 0000000ffd800000-0000000ffdbfffff ibm,homer-image [0]
FW: 0000000fff800000-0000000fffffffff ibm,occ-common-area
IMAGE: dumped HBRT binary to hbrt.bin
IMAGE: hbrt map at 0x3fff857b0000, size 0x230000
HBRT: calling hservices_init
IMAGE: code address: 0x3fff857b0000
IMAGE: calling ibm,hbrt_init()
HBRT: Starting Runtime Services....

HBRT: Initializing modules.

HBRT: Initing module libtrace_rt.so...
HBRT: done.

HBRT: Initing module liberrl_rt.so...
HBRT: done.

HBRT: Initing module libtargeting_rt.so...
IMAGE: hservice_get_reserved_mem: ibm,hbrt-target-image, 0
IMAGE: Mapping 0x0000000ffd6e0000 0x00020000 ibm,hbrt-target-image[0]
IMAGE: hservice_get_reserved_mem: ibm,hbrt-target-image[0](0x0000000ffd6e0000) address 0x3fff85790000
HBRT: TARG:Decoded Attribute Section: 0, 0x100000000, 0x3fff85790000, 0x14000
....
So on Vivid it is validated

[Thierry FAUCK (thierry-j)]

Validated on trusty from trusty-proposed - installation starts daemon and events can be found in /var/adm/syslog

[Launchpad Janitor (janitor)]

This bug was fixed in the package skiboot - 5.1.1-0ubuntu1~14.04.1

---------------
skiboot (5.1.1-0ubuntu1~14.04.1) trusty; urgency=medium

  * New upstream release. (LP: #1467542)
  * Dropped patches; applied upstream:
    - 0001-external-gard-add-Makefile-targets-to-make-debian-pa.patch
    - 0001-Honor-compilation-flags-passed-from-the-environment.patch
    - 0001-Fixes-for-compilation-with-Werror.patch
  * debian/patches/uninitialized_uses.patch: fix up uninitialized variables
    that make our build fail.

 -- Mathieu Trudel-Lapierre <email address hidden> Tue, 01 Sep 2015 12:37:57 -0400

[Chris J Arges (arges)]

The verification of the Stable Release Update for skiboot has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[Launchpad Janitor (janitor)]

This bug was fixed in the package skiboot - 5.1.1-0ubuntu1~15.04.1

---------------
skiboot (5.1.1-0ubuntu1~15.04.1) vivid; urgency=medium

  * New upstream release. (LP: #1467542)
  * Dropped patches; applied upstream:
    - 0001-external-gard-add-Makefile-targets-to-make-debian-pa.patch
    - 0001-Honor-compilation-flags-passed-from-the-environment.patch
    - 0001-Fixes-for-compilation-with-Werror.patch
  * debian/patches/uninitialized_uses.patch: fix up uninitialized variables
    that make our build fail.

 -- Mathieu Trudel-Lapierre <email address hidden> Tue, 01 Sep 2015 12:37:57 -0400