| 2017-11-24 02:00:23 |
Julien Langlois |
bug |
|
|
added bug |
| 2018-03-02 21:31:06 |
Launchpad Janitor |
samba (Ubuntu): status |
New |
Confirmed |
|
| 2018-03-11 22:29:30 |
Thomas Smith |
bug |
|
|
added subscriber Thomas Smith |
| 2018-03-21 12:33:02 |
Andreas Hasenack |
samba (Ubuntu): status |
Confirmed |
Triaged |
|
| 2018-03-21 12:33:05 |
Andreas Hasenack |
samba (Ubuntu): importance |
Undecided |
Low |
|
| 2018-03-21 12:33:13 |
Andreas Hasenack |
bug |
|
|
added subscriber Ubuntu Server |
| 2018-03-21 12:33:17 |
Andreas Hasenack |
tags |
ctdb |
ctdb server-next |
|
| 2018-03-21 12:33:43 |
Andreas Hasenack |
nominated for series |
|
Ubuntu Xenial |
|
| 2018-03-21 12:33:43 |
Andreas Hasenack |
nominated for series |
|
Ubuntu Trusty |
|
| 2018-03-21 14:26:32 |
David Britton |
bug task added |
|
samba (Ubuntu Trusty) |
|
| 2018-03-21 14:26:37 |
David Britton |
bug task added |
|
samba (Ubuntu Xenial) |
|
| 2018-03-21 14:26:47 |
Andreas Hasenack |
samba (Ubuntu Trusty): status |
New |
Triaged |
|
| 2018-03-21 14:26:50 |
Andreas Hasenack |
samba (Ubuntu Xenial): status |
New |
Triaged |
|
| 2018-03-21 14:26:53 |
Andreas Hasenack |
samba (Ubuntu Trusty): importance |
Undecided |
Low |
|
| 2018-03-21 14:26:55 |
Andreas Hasenack |
samba (Ubuntu Xenial): importance |
Undecided |
Low |
|
| 2018-03-21 14:26:58 |
Andreas Hasenack |
samba (Ubuntu): status |
Triaged |
Fix Released |
|
| 2018-03-21 16:45:25 |
C de-Avillez |
samba (Ubuntu Trusty): milestone |
|
trusty-updates |
|
| 2018-03-21 16:45:37 |
C de-Avillez |
samba (Ubuntu Xenial): milestone |
|
xenial-updates |
|
| 2018-11-09 14:16:10 |
Karl Stenerud |
samba (Ubuntu Xenial): assignee |
|
Karl Stenerud (kstenerud) |
|
| 2020-09-28 12:41:39 |
Christian Ehrhardt |
samba (Ubuntu Xenial): assignee |
Karl Stenerud (kstenerud) |
Christian Ehrhardt (paelzer) |
|
| 2020-09-28 12:41:46 |
Christian Ehrhardt |
samba (Ubuntu Trusty): status |
Triaged |
Won't Fix |
|
| 2020-09-28 12:47:47 |
Christian Ehrhardt |
description |
The CTDB deployed /etc/ctdb/events.d/50.samba script contain the following code to detect the smbd/nmbd service name:
---
case $CTDB_INIT_STYLE in
suse)
CTDB_SERVICE_SMB=${CTDB_SERVICE_SMB:-smb}
CTDB_SERVICE_NMB=${CTDB_SERVICE_NMB:-nmb}
;;
debian)
CTDB_SERVICE_SMB=${CTDB_SERVICE_SMB:-samba}
CTDB_SERVICE_NMB=${CTDB_SERVICE_NMB:-""}
;;
*)
# Use redhat style as default:
CTDB_SERVICE_SMB=${CTDB_SERVICE_SMB:-smb}
CTDB_SERVICE_NMB=${CTDB_SERVICE_NMB:-""}
;;
esac
---
It detects Ubuntu as Debian (/etc/ctdb/functions) and so define that the smb service is named "samba" and the nmb service does not exists.
That could be OK since Samba deploy an "samba" init script as well as smbd and nmbd. Except, this init script does not really work to start smbd and nmbd.
To make CTDB happy, the previous code must be modified:
--- 50.samba.orig 2017-11-23 23:34:35.146314429 +0000
+++ 50.samba 2017-11-23 23:35:08.161814684 +0000
@@ -14,8 +14,8 @@
CTDB_SERVICE_NMB=${CTDB_SERVICE_NMB:-nmb}
;;
debian)
- CTDB_SERVICE_SMB=${CTDB_SERVICE_SMB:-samba}
- CTDB_SERVICE_NMB=${CTDB_SERVICE_NMB:-""}
+ CTDB_SERVICE_SMB=smbd
+ CTDB_SERVICE_NMB=nmbd
;;
*)
# Use redhat style as default:
I reproduced this issue on both Ubuntu 16.04 and 14.04. But it does not exists on Debian Stretch (the 50.samba has been updated).
An easier workaround to avoid updating the 50.samba script is to set those 2 service name in the /etc/default/ctdb:
CTDB_SERVICE_SMB=smbd
CTDB_SERVICE_NMB=nmbd |
[Impact]
* samba/nmbd Service names as referenced by ctdb default config are wrong
* Due to that ctdb deployments start the wrong init script which is bad.
* Backport a later fix of >=4.5.2 to fix the issue
[Test Case]
1. install ctdb and samba
$ apt install ctdb samba
2. verify that the "correct" service names on xenial are smbd and nmbd
$ systemctl status smbd nmbd
while OTOH
$ systemctl status samba won't show an active service
3. check the config of ctbd
$ vim /etc/ctdb/events.d/50.samba
It should refer to smbd and nmbd for "debian" based systems
[Regression Potential]
* This doesn't work without the fix, so we can't regress people relying
on it. Much more likely we have people that tripped over it in the past
and fixed it themselves which now might be behavior-affected in some
way. But even that should be safe because:
a) user didn't care about the issue -> didn't change -> now gets the
fix as the conffile is the default
b) user did care about the issue -> adapted the .conf and will now get
an upgrade prompt
c) user did care about the issue -> adapted the variable in anotther
place -> this makes use of bash's "use this if not set" mechanism
so the overrides of those users should not be affected.
[Other Info]
* n/a
---
The CTDB deployed /etc/ctdb/events.d/50.samba script contain the following code to detect the smbd/nmbd service name:
---
case $CTDB_INIT_STYLE in
suse)
CTDB_SERVICE_SMB=${CTDB_SERVICE_SMB:-smb}
CTDB_SERVICE_NMB=${CTDB_SERVICE_NMB:-nmb}
;;
debian)
CTDB_SERVICE_SMB=${CTDB_SERVICE_SMB:-samba}
CTDB_SERVICE_NMB=${CTDB_SERVICE_NMB:-""}
;;
*)
# Use redhat style as default:
CTDB_SERVICE_SMB=${CTDB_SERVICE_SMB:-smb}
CTDB_SERVICE_NMB=${CTDB_SERVICE_NMB:-""}
;;
esac
---
It detects Ubuntu as Debian (/etc/ctdb/functions) and so define that the smb service is named "samba" and the nmb service does not exists.
That could be OK since Samba deploy an "samba" init script as well as smbd and nmbd. Except, this init script does not really work to start smbd and nmbd.
To make CTDB happy, the previous code must be modified:
--- 50.samba.orig 2017-11-23 23:34:35.146314429 +0000
+++ 50.samba 2017-11-23 23:35:08.161814684 +0000
@@ -14,8 +14,8 @@
CTDB_SERVICE_NMB=${CTDB_SERVICE_NMB:-nmb}
;;
debian)
- CTDB_SERVICE_SMB=${CTDB_SERVICE_SMB:-samba}
- CTDB_SERVICE_NMB=${CTDB_SERVICE_NMB:-""}
+ CTDB_SERVICE_SMB=smbd
+ CTDB_SERVICE_NMB=nmbd
;;
*)
# Use redhat style as default:
I reproduced this issue on both Ubuntu 16.04 and 14.04. But it does not exists on Debian Stretch (the 50.samba has been updated).
An easier workaround to avoid updating the 50.samba script is to set those 2 service name in the /etc/default/ctdb:
CTDB_SERVICE_SMB=smbd
CTDB_SERVICE_NMB=nmbd |
|
| 2020-09-28 14:10:05 |
Christian Ehrhardt |
tags |
ctdb server-next |
ctdb |
|
| 2021-12-08 16:56:23 |
Bryce Harrington |
samba (Ubuntu Xenial): status |
Triaged |
Won't Fix |
|
