proftpd service fails to restart (including via logrotate)
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
proftpd-dfsg (Debian) |
Fix Released
|
Unknown
|
|||
proftpd-dfsg (Ubuntu) |
Fix Released
|
Medium
|
Brian Morton | ||
Trusty |
Fix Released
|
Medium
|
Unassigned |
Bug Description
SRU request for Trusty
[Impact]
* ProFTPd exits with signal 15 when restarted via init script.
Worse yet, init script returns success.
* Since logrotate runs via cron and performs a restart, this causes
FTP service to stop and results in unexpected service downtime.
* Final version of upstream patch at https:/
* Only trusty and prior are affected
[Test Case]
* bmorton@maui:~$ sudo service proftpd restart
* Stopping ftp server proftpd [ OK ]
* Starting ftp server proftpd [ OK ]
bmorton@maui:~$ sudo service proftpd status
ProFTPD is started in standalone mode, currently not running.
* After a restart, status should say "currently running"
[Regression Potential]
* Failure to start/stop/restart proftpd service
* Patched package currently running on production host without issues
[Other Info]
* This is a very old bug affecting a substantial number of users
* Early AM nagios notifications about FTP service are undesirable
-------
proftpd-basic 1.3.5~rc3-2 from Ubuntu 13.10
proftpd-basic 1.3.5~rc3-
Init script from proftpd-basic package contains the BUG: when you run /etc/init.d/proftpd restart it fails because of there is the race between pidfile removal and start() which checks pidfile existency:
---
ProFTPD is started in standalone mode, currently running.
root@aa:~# /etc/init.d/proftpd restart
* Stopping ftp server proftpd [ OK ]
* Starting ftp server proftpd [ OK ]
root@aa:~# /etc/init.d/proftpd status
ProFTPD is started in standalone mode, currently not running.
---
the next workaround helps:
---
--- /etc/init.
+++ /etc/init.d/proftpd 2013-10-30 13:52:57.456265698 +0400
@@ -107,6 +107,7 @@
fi
if [ -f "$PIDFILE" ]; then
+ sleep 1
if [ $? = 0 ]; then
else
---
Please, fix.
description: | updated |
no longer affects: | proftpd-dfsg |
summary: |
- proftpd service failed to restart + proftpd service fails to restart (including via logrotate) |
Changed in proftpd-dfsg (Ubuntu): | |
assignee: | nobody → Brian Morton (rokclimb15) |
Changed in proftpd-dfsg (Ubuntu): | |
importance: | Undecided → Medium |
Changed in proftpd-dfsg (Ubuntu Trusty): | |
importance: | Undecided → Medium |
tags: | added: patch |
Changed in proftpd-dfsg (Ubuntu Trusty): | |
status: | New → Triaged |
Changed in proftpd-dfsg (Debian): | |
status: | Unknown → Fix Released |
Status changed to 'Confirmed' because the bug affects multiple users.