Ubuntu
notify-osd package

notify-osd loses pending bubble if append occurs when bubble is not yet visible

  1. Trusty (14.04)
  2. Bug #1319983
Bug #1319983 reported by Andy Whitcroft
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
notify-osd (Ubuntu)
In Progress
Undecided
Lars Karlitski
Trusty
New
Undecided
Unassigned

Bug Description

[Impact]
When a notification specifiying x-canonical-append:true is recieved and merges with a bubble the bubble will be lost if the bubble is not yet visible. We will also update times incorrectly on any synchronous bubble.

[Test Case]
Running the attached scripts (play.py and play2.py) show the issue: bubbles after the first one aren't shown, because they specify x-canonical-append. The attached branch fixes that.

[Regression Potential]
The patch only touches code that is concerned with updating an existing notification. This is currently broken anyway.

See original description

Related branches

lp:~larsu/notify-osd/lp1319983
Ready for review for merging into lp:notify-osd
PS Jenkins bot (community): Needs Fixing (continuous-integration)
Mirco Müller: Pending requested
Diff: 27 lines (+9/-7)
1 file modified
src/stack.c (+9/-7)
Revision history for this message
Andy Whitcroft (apw) wrote :
  • X Edit (1.5 KiB, text/plain)

The attached patch fixes this for me.

Revision history for this message
Andy Whitcroft (apw) wrote :

Attaching two test scripts. play.py triggers the primary bug, play2.py tests the "other case".

Revision history for this message
Andy Whitcroft (apw) wrote :
Lars Karlitski (larsu)
Changed in notify-osd (Ubuntu):
status: New → In Progress
assignee: nobody → Lars Uebernickel (larsu)
Lars Karlitski (larsu)
description: updated
Revision history for this message
Sebastien Bacher (seb128) wrote :

Is that still an issue for you? Running those scripts show the different bubbles displayed, which is weird because the code didn't change/the fix didn't get merged. Could you try again/describe exactly the behaviour you get if that's still buggy?

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.