Implement missing functionality to make location-service a trusted helper.
Bug #1219164 reported by
Thomas Voß
This bug affects 4 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| location-service |
Fix Released
|
High
|
Thomas Voß | ||
| location-service (Ubuntu) |
Fix Released
|
Critical
|
Thomas Voß | ||
Bug Description
Address FIXME in code and query the user if an app wants to access the location service:
if (credentials.pid != pid || credentials.uid != uid)
return Result::granted; // FIXME(tvoss): This should return rejected.
Related branches
lp:~thomas-voss/location-service/fix-1219164
- PS Jenkins bot: Needs Fixing (continuous-integration)
- Seth Arnold (community): Approve
- Jamie Strandboge: Pending requested
- Marc Deslauriers: Pending requested
- Manuel de la Peña: Pending requested
-
Diff: 1037 lines (+616/-37)20 files modifiedCMakeLists.txt (+7/-1)
data/CMakeLists.txt (+9/-0)
data/com.ubuntu.location.Service.conf (+5/-1)
data/ubuntu-location-service-trust-stored.conf.in (+13/-0)
debian/control (+4/-0)
debian/ubuntu-location-service-bin.install (+1/-0)
examples/service/service.cpp (+1/-1)
include/location_service/com/ubuntu/location/service/interface.h (+1/-1)
src/location_service/com/ubuntu/location/CMakeLists.txt (+7/-0)
src/location_service/com/ubuntu/location/service/config.h.in (+38/-0)
src/location_service/com/ubuntu/location/service/daemon.cpp (+11/-2)
src/location_service/com/ubuntu/location/service/default_configuration.cpp (+3/-10)
src/location_service/com/ubuntu/location/service/default_configuration.h (+18/-13)
src/location_service/com/ubuntu/location/service/session/skeleton.cpp (+3/-3)
src/location_service/com/ubuntu/location/service/trust_store_permission_manager.cpp (+176/-0)
src/location_service/com/ubuntu/location/service/trust_store_permission_manager.h (+85/-0)
tests/CMakeLists.txt (+1/-0)
tests/acceptance_tests.cpp (+26/-5)
tests/app_armor_testing_profile (+3/-0)
tests/trust_store_permission_manager_test.cpp (+204/-0)
| Changed in location-service (Ubuntu): | |
| importance: | Undecided → Critical |
| importance: | Critical → High |
Revision history for this message
| Launchpad Janitor (janitor) wrote | #1 |
| Changed in location-service (Ubuntu): | |
| status: | New → Confirmed |
| tags: | added: application-confinement |
| Changed in location-service (Ubuntu Saucy): | |
| status: | Confirmed → Won't Fix |
Revision history for this message
| Jamie Strandboge (jdstrand) wrote | #2 |
| Changed in location-service (Ubuntu Trusty): | |
| status: | Confirmed → Won't Fix |
| Changed in location-service (Ubuntu Utopic): | |
| status: | Confirmed → In Progress |
| assignee: | nobody → Thomas Voß (thomas-voss) |
| tags: | added: rtm14 |
| Changed in location-service: | |
| status: | Confirmed → In Progress |
Revision history for this message
| Jamie Strandboge (jdstrand) wrote | #3 |
| no longer affects: | location-service (Ubuntu Saucy) |
| no longer affects: | location-service (Ubuntu Trusty) |
| no longer affects: | location-service (Ubuntu Utopic) |
| Changed in location-service (Ubuntu): | |
| importance: | High → Critical |
| Changed in location-service: | |
| status: | In Progress → Fix Released |
| Changed in location-service (Ubuntu): | |
| status: | In Progress → Fix Released |
To post a comment you must log in.
Status changed to 'Confirmed' because the bug affects multiple users.