| 2017-04-20 02:32:04 |
Mathieu Trudel-Lapierre |
bug |
|
|
added bug |
| 2017-04-20 02:32:35 |
Mathieu Trudel-Lapierre |
summary |
EFI fallback binary should only be installed in removable path |
EFI fallback binary should only be installed in force-extra-removable |
|
| 2017-04-20 02:34:35 |
Mathieu Trudel-Lapierre |
grub2 (Ubuntu): status |
New |
Triaged |
|
| 2017-04-20 02:34:37 |
Mathieu Trudel-Lapierre |
grub2 (Ubuntu): importance |
Undecided |
Critical |
|
| 2017-04-20 02:34:41 |
Mathieu Trudel-Lapierre |
grub2 (Ubuntu): status |
Triaged |
In Progress |
|
| 2017-04-20 02:34:45 |
Mathieu Trudel-Lapierre |
grub2 (Ubuntu): assignee |
|
Mathieu Trudel-Lapierre (cyphermox) |
|
| 2017-04-20 02:34:49 |
Mathieu Trudel-Lapierre |
grub2 (Ubuntu): milestone |
|
ubuntu-17.05 |
|
| 2017-04-20 02:35:17 |
Mathieu Trudel-Lapierre |
nominated for series |
|
Ubuntu Zesty |
|
| 2017-04-20 02:35:17 |
Mathieu Trudel-Lapierre |
bug task added |
|
grub2 (Ubuntu Zesty) |
|
| 2017-04-20 02:35:17 |
Mathieu Trudel-Lapierre |
nominated for series |
|
Ubuntu Trusty |
|
| 2017-04-20 02:35:17 |
Mathieu Trudel-Lapierre |
bug task added |
|
grub2 (Ubuntu Trusty) |
|
| 2017-04-20 02:35:17 |
Mathieu Trudel-Lapierre |
nominated for series |
|
Ubuntu Yakkety |
|
| 2017-04-20 02:35:17 |
Mathieu Trudel-Lapierre |
bug task added |
|
grub2 (Ubuntu Yakkety) |
|
| 2017-04-20 02:35:17 |
Mathieu Trudel-Lapierre |
nominated for series |
|
Ubuntu Xenial |
|
| 2017-04-20 02:35:17 |
Mathieu Trudel-Lapierre |
bug task added |
|
grub2 (Ubuntu Xenial) |
|
| 2017-04-20 14:02:26 |
Mathieu Trudel-Lapierre |
description |
The patch I did to fix names for the new naming of shim binaries included the addition of fbx64.efi; but it was done wrong: fbx64.efi should only exist under \EFI\BOOT, it's not required in the "removable" path; except if we're trying to force installing to the removable path *too*.
In other words:
1) we normally don't want /EFI/ubuntu/fbx64.efi to exist;
and
a) on a desktop or server, we want /EFI/BOOT/fbx64.efi to exist (ie. installs without --removable, and with --force-extra-removable used when grub-install was called);
b) on removable media, we do not want /EFI/BOOT/fbx64.efi to exist (ie. when grub-installed is called with --removable).
Furthermore, the (a) case is probably not the typical case we want to run grub-install with. Calls to grub-install with --force-extra-removable probably should be limited to shim-signed's postinst.
In any case, let's move the fbx64.efi installation step to also_install_removable() in grub-installer to avoid installing it when it shouldn't be. |
[Impact]
Building some images depending on calling grub-install --removable still installs fbx64.efi; which we don't want on removable media.
[Test case]
On an EFI system, run 'grub-install --removable --target=x86_64-efi'. Observe whether fbx64.efi is installed to /boot/efi/EFI/BOOT. It should not.
[Regression potential]
If any system is depending on running grub-install with --removable, and on fbx64.efi being installed in /boot/efi/EFI/BOOT; this would cause this assumption to fail -- leading to incorrect fallback behavior when BootEntries are not present on a system.
Failures to boot with "System BootOrder not found" errors should be considered a possible regression.
Any missing files in /boot/efi/EFI/BOOT or /boot/efi/EFI/ubuntu after install should be considered a potential regression of this update.
----
The patch I did to fix names for the new naming of shim binaries included the addition of fbx64.efi; but it was done wrong: fbx64.efi should only exist under \EFI\BOOT, it's not required in the "removable" path; except if we're trying to force installing to the removable path *too*.
In other words:
1) we normally don't want /EFI/ubuntu/fbx64.efi to exist;
and
a) on a desktop or server, we want /EFI/BOOT/fbx64.efi to exist (ie. installs without --removable, and with --force-extra-removable used when grub-install was called);
b) on removable media, we do not want /EFI/BOOT/fbx64.efi to exist (ie. when grub-installed is called with --removable).
Furthermore, the (a) case is probably not the typical case we want to run grub-install with. Calls to grub-install with --force-extra-removable probably should be limited to shim-signed's postinst.
In any case, let's move the fbx64.efi installation step to also_install_removable() in grub-installer to avoid installing it when it shouldn't be. |
|
| 2017-04-21 17:42:00 |
Mathieu Trudel-Lapierre |
summary |
EFI fallback binary should only be installed in force-extra-removable |
EFI fallback binary should not be installed in --removable mode |
|
| 2017-04-28 02:27:05 |
Launchpad Janitor |
grub2 (Ubuntu): status |
In Progress |
Fix Released |
|
| 2017-05-11 19:51:33 |
Dan Watkins |
bug task added |
|
cloud-images |
|
| 2017-05-11 19:51:40 |
Dan Watkins |
cloud-images: importance |
Undecided |
High |
|
| 2017-05-11 19:51:44 |
Launchpad Janitor |
grub2 (Ubuntu Trusty): status |
New |
Confirmed |
|
| 2017-05-11 19:51:44 |
Launchpad Janitor |
grub2 (Ubuntu Xenial): status |
New |
Confirmed |
|
| 2017-05-11 19:51:44 |
Launchpad Janitor |
grub2 (Ubuntu Yakkety): status |
New |
Confirmed |
|
| 2017-05-20 00:41:06 |
Steve Langasek |
grub2 (Ubuntu Xenial): status |
Confirmed |
Fix Committed |
|
| 2017-05-20 00:41:10 |
Steve Langasek |
bug |
|
|
added subscriber Ubuntu Stable Release Updates Team |
| 2017-05-20 00:41:12 |
Steve Langasek |
bug |
|
|
added subscriber SRU Verification |
| 2017-05-20 00:41:16 |
Steve Langasek |
tags |
|
verification-needed |
|
| 2017-05-20 12:39:37 |
Simon Déziel |
bug |
|
|
added subscriber Simon Déziel |
| 2017-05-20 19:32:28 |
Ubuntu Foundations Team Bug Bot |
bug |
|
|
added subscriber Brian Murray |
| 2017-05-20 19:32:30 |
Ubuntu Foundations Team Bug Bot |
tags |
verification-needed |
verification-failed verification-needed |
|
| 2017-06-06 21:58:35 |
Łukasz Zemczak |
tags |
verification-failed verification-needed |
verification-needed |
|
| 2017-06-06 22:17:50 |
Łukasz Zemczak |
grub2 (Ubuntu Zesty): status |
In Progress |
Fix Committed |
|
| 2017-06-06 22:32:24 |
Łukasz Zemczak |
grub2 (Ubuntu Yakkety): status |
Confirmed |
Fix Committed |
|
| 2017-06-14 19:12:53 |
Mathieu Trudel-Lapierre |
tags |
verification-needed |
verification-done-xenial verification-needed |
|
| 2017-06-15 21:20:03 |
Launchpad Janitor |
grub2 (Ubuntu Xenial): status |
Fix Committed |
Fix Released |
|
| 2017-06-15 21:45:41 |
Mathieu Trudel-Lapierre |
tags |
verification-done-xenial verification-needed |
verification-done-xenial verification-done-yakkety verification-needed |
|
| 2017-06-16 17:14:53 |
Mathieu Trudel-Lapierre |
tags |
verification-done-xenial verification-done-yakkety verification-needed |
verification-done-xenial verification-done-yakkety verification-done-zesty verification-needed |
|
| 2017-06-19 10:53:42 |
Launchpad Janitor |
grub2 (Ubuntu Zesty): status |
Fix Committed |
Fix Released |
|
| 2017-06-19 10:57:42 |
Launchpad Janitor |
grub2 (Ubuntu Yakkety): status |
Fix Committed |
Fix Released |
|
| 2017-06-28 11:26:35 |
Scott Moser |
bug task deleted |
cloud-images |
|
|
