[SRU] git-review>=1.27 for updated opendev gerrit
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
git-review (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
Trusty |
Triaged
|
Low
|
Unassigned | ||
Xenial |
Triaged
|
Low
|
Unassigned | ||
Bionic |
Fix Released
|
High
|
Unassigned | ||
Focal |
Fix Released
|
Undecided
|
Unassigned | ||
Groovy |
Fix Released
|
Undecided
|
Unassigned | ||
Hirsute |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
[Impact]
OpenStack's gerrit, https:/
This is fixed in 1.27.0 and there is a small delta since 1.26.0.
$ git-pretty 1.26.0..1.27.0
- [3c46c33] Fix compare_review's use of fetch_review
- [6587639] Always print failure case when testing remotes
- [dcbfb32] Use new %topic=XXXX syntax for topic pushes
- [c7436f9] Start using reno for releasenotes
- [8236cdb] Use doc/requirements and openstackdocstheme
- [c9282ae] Update tox docs environment to use sphinx-build
- [694f532] Update default gerrit namespace
- [de0d271] tox: default envlist to supported python versions
- [7de9ffc] support review URLs as download arguments
- [ed3c79e] expand help for --download option
- [6f50b59] `work-in-progress` and `private` workflow in Gerrit 2.15
- [31c5e0b] Document usepushurl in the man page
- [aeeff97] Fix git review -d M,N with later gerrit
- [244731b] Testing getting specific patchset
- [b07a524] Add bindep.txt
[Test Case]
Run 'git review' on an openstack change it should successfully push changes to gerrit, and not fail with "prohibited by Gerrit: not permitted: create".
[Regression Potential]
'git-review' is used to proposed changes to opendev projects so any regressions would be found through the use of this CLI tool. As of now, the 1.26.0 version of git-review in bionic doesn't work with the upgraded gerrit. We've had version 1.27.0 in focal for 6-7 months now and regressions should be significantly minimized by that.
[Discussion]
Work-around for using 1.26.0: In chatting with clarkb he mentioned users can push directly using git push gerrit HEAD:refs/
Workaround: `pip install git-review` will give you 1.28 on bionic.