Activity log for bug #1373137

Date Who What changed Old value New value Message
2014-09-23 21:20:03 Scott Moser bug added bug
2014-09-23 21:20:14 Scott Moser bug task added curtin
2014-09-23 21:20:41 Scott Moser curtin (Ubuntu): status New Triaged
2014-09-23 21:20:43 Scott Moser curtin: status New Triaged
2014-09-23 21:20:46 Scott Moser curtin: importance Undecided Medium
2014-09-23 21:20:49 Scott Moser curtin: importance Medium High
2014-09-23 21:20:51 Scott Moser curtin (Ubuntu): importance Undecided High
2014-09-23 21:27:49 Launchpad Janitor branch linked lp:~smoser/curtin/ppc64-2
2014-09-23 21:28:51 Scott Moser attachment added patch: run update-grub when installing grub https://bugs.launchpad.net/curtin/+bug/1373137/+attachment/4212847/+files/out.diff
2014-09-23 21:29:16 Scott Moser bug added subscriber ashley
2014-09-24 00:23:47 Ubuntu Foundations Team Bug Bot tags patch
2014-09-24 12:42:20 Colin Watson bug added subscriber Colin Watson
2014-09-24 16:15:11 Launchpad Janitor branch linked lp:curtin
2014-09-27 12:37:46 Launchpad Janitor branch linked lp:ubuntu/utopic-proposed/curtin
2014-09-27 12:39:23 Launchpad Janitor curtin (Ubuntu): status Triaged Fix Released
2014-10-21 20:54:15 Launchpad Janitor branch linked lp:~smoser/ubuntu/trusty/curtin/sru-utopic-level
2014-10-21 20:58:28 Scott Moser nominated for series Ubuntu Trusty
2014-10-21 20:58:28 Scott Moser bug task added curtin (Ubuntu Trusty)
2014-10-21 21:02:49 Scott Moser curtin (Ubuntu Trusty): status New Confirmed
2014-10-21 21:02:51 Scott Moser curtin (Ubuntu Trusty): importance Undecided High
2014-10-24 17:54:05 Newell Jensen description I noticed this when installing ppc64el, as boot would fail. It would fail because no /boot/grub/grub.cfg existed. I'm not entirely sure when we need to run update-grub. I know that the 'install_grub' was choosing to *not* run update-grub because sometimes dpkg-reconfigure would do the same thing, and that was a slow operation. Its possible there are more complex symantics involved than I understood. But we were not running 'update-grub' in order to save some time. Basically, as input to 'install_grub', we have: * the target to install to (/dev/sda1 or /dev/sda) * the dpkg arch * the name of the package to 'dpkg-reconfigure' (derived from the dpkg arch and whether or not to use uefi). we dpkg-reconfigure because we may change the GRUB_CMDLINE_LINUX_DEFAULT to include additional options such as console= From my memory, it seemed like on amd64 and i386, running 'dpkg-reconfigure grub-pc' would end up running update-grub. I then chose not to run update-grub because it was slow. Colin, Is there some simple logic that I can use to determine when running update-grub is needed? I noticed this when installing ppc64el, as boot would fail. It would fail because no /boot/grub/grub.cfg existed. I'm not entirely sure when we need to run update-grub. I know that the 'install_grub' was choosing to *not* run update-grub because sometimes dpkg-reconfigure would do the same thing, and that was a slow operation. Its possible there are more complex symantics involved than I understood. But we were not running 'update-grub' in order to save some time. Basically, as input to 'install_grub', we have:   * the target to install to (/dev/sda1 or /dev/sda)   * the dpkg arch   * the name of the package to 'dpkg-reconfigure' (derived from the dpkg arch and whether or not to use uefi).     we dpkg-reconfigure because we may change the GRUB_CMDLINE_LINUX_DEFAULT to include additional options such as console= From my memory, it seemed like on amd64 and i386, running 'dpkg-reconfigure grub-pc' would end up running update-grub. I then chose not to run update-grub because it was slow. Colin, Is there some simple logic that I can use to determine when running update-grub is needed? SRU curtin ========== [Impact] This bug will make it so boot fails when installing ppc64el. It would fail because no /boot/grub/grub.cfg existed. This backport is needed so that we can install for ppc64el and any other architectures that were failing because update-grub was not being executed when doing grub-install. This upload fixes the bug by making sure that update-grub is executed when doing grub-install [Test Case] To reproduce this bug you would need to follow what was being done as outlined in the original bug report description. Namely, you would need to do a curtin install for ppc64el. [Regression Potential] update-grub can be run multiple times so even in the event that update-grub is executed a second time by some other package, like the original bug reporter mentions in the original bug report description, it is unlikely to cause any regressions.
2014-10-30 20:14:47 Brian Murray curtin (Ubuntu Trusty): status Confirmed Fix Committed
2014-10-30 20:14:50 Brian Murray bug added subscriber Ubuntu Stable Release Updates Team
2014-10-30 20:14:54 Brian Murray bug added subscriber SRU Verification
2014-10-30 20:14:57 Brian Murray tags patch patch verification-needed
2014-10-30 20:33:42 Launchpad Janitor branch linked lp:ubuntu/trusty-proposed/curtin
2014-12-01 17:29:10 Andres Rodriguez tags patch verification-needed patch verification-done
2015-01-05 18:03:59 Brian Murray removed subscriber Ubuntu Stable Release Updates Team
2015-01-05 18:09:12 Launchpad Janitor curtin (Ubuntu Trusty): status Fix Committed Fix Released
2015-07-23 20:56:09 Blake Rouse curtin: status Triaged Fix Released