| 2016-11-22 23:08:38 |
Julian Andres Klode |
bug |
|
|
added bug |
| 2016-11-22 23:08:38 |
Julian Andres Klode |
attachment added |
|
bash_4.3-7ubuntu1.7.patch https://bugs.launchpad.net/bugs/1644048/+attachment/4781776/+files/bash_4.3-7ubuntu1.7.patch |
|
| 2016-11-22 23:09:16 |
Julian Andres Klode |
nominated for series |
|
Ubuntu Trusty |
|
| 2016-11-22 23:09:16 |
Julian Andres Klode |
bug task added |
|
bash (Ubuntu Trusty) |
|
| 2016-11-22 23:29:08 |
Julian Andres Klode |
summary |
4.3-7ubuntu1.6 FTBFS on arm64 |
4.3-7ubuntu1.6 FTBFS on arm64 only with format-security error |
|
| 2016-11-23 00:31:31 |
Ubuntu Foundations Team Bug Bot |
tags |
regression-proposed |
patch regression-proposed |
|
| 2016-11-23 13:44:45 |
Sven Mueller |
bug |
|
|
added subscriber Sven Mueller |
| 2016-11-23 13:44:50 |
Launchpad Janitor |
bash (Ubuntu): status |
New |
Confirmed |
|
| 2016-11-23 13:44:50 |
Launchpad Janitor |
bash (Ubuntu Trusty): status |
New |
Confirmed |
|
| 2016-11-23 19:32:47 |
Julian Andres Klode |
description |
This weirdly only fails on arm64.
../.././builtins/../.././builtins/help.def:130:7: error: format not a string literal and no format arguments [-Werror=format-security]
The attached debdiff will be uploaded to trusty-proposed soon. |
[Impact]
Breaks build on arm64 in trusty:
../.././builtins/../.././builtins/help.def:130:7: error: format not a string literal and no format arguments [-Werror=format-security]
[Test case]
Check it builds
[Regression potential]
Indefinitely low.
[Other info]
The same code works fine on all other architectures and newer releases, but it seems broken anyway: We are passing the return value of ngettext() to printf() as the format string, which is unsafe.
We should evaluate why that works elsewhere and probably also do the same fix in other branches, but I'll leave that to someone else to decide. My intention here is to just get the trusty SRU for bug 1644048 building on all platforms. |
|
| 2016-11-23 19:34:19 |
Julian Andres Klode |
bash (Ubuntu Trusty): status |
Confirmed |
In Progress |
|
| 2016-11-23 19:46:53 |
Julian Andres Klode |
description |
[Impact]
Breaks build on arm64 in trusty:
../.././builtins/../.././builtins/help.def:130:7: error: format not a string literal and no format arguments [-Werror=format-security]
[Test case]
Check it builds
[Regression potential]
Indefinitely low.
[Other info]
The same code works fine on all other architectures and newer releases, but it seems broken anyway: We are passing the return value of ngettext() to printf() as the format string, which is unsafe.
We should evaluate why that works elsewhere and probably also do the same fix in other branches, but I'll leave that to someone else to decide. My intention here is to just get the trusty SRU for bug 1644048 building on all platforms. |
[Impact]
Breaks build on arm64 in trusty:
../.././builtins/../.././builtins/help.def:130:7: error: format not a string literal and no format arguments [-Werror=format-security]
[Test case]
Check it builds
[Regression potential]
Indefinitely low. All we do is add
"%s"
between printf( and ngettext(...
[Other info]
The same code works fine on all other architectures and newer releases, but it seems broken anyway: We are passing the return value of ngettext() to printf() as the format string, which is unsafe.
We should evaluate why that works elsewhere and probably also do the same fix in other branches, but I'll leave that to someone else to decide. My intention here is to just get the trusty SRU for bug 1644048 building on all platforms. |
|
| 2016-11-23 19:47:01 |
Julian Andres Klode |
description |
[Impact]
Breaks build on arm64 in trusty:
../.././builtins/../.././builtins/help.def:130:7: error: format not a string literal and no format arguments [-Werror=format-security]
[Test case]
Check it builds
[Regression potential]
Indefinitely low. All we do is add
"%s"
between printf( and ngettext(...
[Other info]
The same code works fine on all other architectures and newer releases, but it seems broken anyway: We are passing the return value of ngettext() to printf() as the format string, which is unsafe.
We should evaluate why that works elsewhere and probably also do the same fix in other branches, but I'll leave that to someone else to decide. My intention here is to just get the trusty SRU for bug 1644048 building on all platforms. |
[Impact]
Breaks build on arm64 in trusty:
../.././builtins/../.././builtins/help.def:130:7: error: format not a string literal and no format arguments [-Werror=format-security]
[Test case]
Check it builds
[Regression potential]
Indefinitely low. All we do is add
"%s",
between printf( and ngettext(...
[Other info]
The same code works fine on all other architectures and newer releases, but it seems broken anyway: We are passing the return value of ngettext() to printf() as the format string, which is unsafe.
We should evaluate why that works elsewhere and probably also do the same fix in other branches, but I'll leave that to someone else to decide. My intention here is to just get the trusty SRU for bug 1644048 building on all platforms. |
|
| 2016-11-23 23:30:48 |
Julian Andres Klode |
bash (Ubuntu Trusty): status |
In Progress |
Confirmed |
|
| 2016-11-23 23:31:21 |
Julian Andres Klode |
summary |
4.3-7ubuntu1.6 FTBFS on arm64 only with format-security error |
builtins/help.def: Passes ngettext() result to printf() as format string |
|
| 2016-12-20 23:44:13 |
Mathew Hodson |
tags |
patch regression-proposed |
ftbfs patch regression-proposed |
|
| 2016-12-20 23:44:22 |
Mathew Hodson |
bash (Ubuntu Trusty): importance |
Undecided |
High |
|
| 2016-12-20 23:44:24 |
Mathew Hodson |
bash (Ubuntu): importance |
Undecided |
High |
|
