unity-greeter crashed with SIGSEGV in gdk_window_get_type_hint()
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
unity-greeter (Ubuntu) |
Fix Released
|
High
|
Robert Ancell | ||
Precise |
Fix Released
|
Medium
|
Robert Ancell | ||
Quantal |
Won't Fix
|
Medium
|
Unassigned | ||
Saucy |
Won't Fix
|
Medium
|
Unassigned |
Bug Description
[Impact]
Unity Greeter can crash when X clients create X windows. This results in Ubuntu going to failsafe mode.
When an X window appears Unity Greeter receives a Map event. Unity Greeter attempts to get a GdkWindow object for the window in the event. If the window was destroyed before it does this it gets a NULL pointer. Unity Greeter did not check for this case.
[Test Case]
This is a bug that only occurs if windows rapidly appear and disappear. Can be verified on machines that are exhibiting the problem (perhaps linked to indicators failing to start). Check errors.ubuntu.com shows problem does not occur when fix applied.
[Errors Bucket]
https:/
[Regression Potential]
Low, the change just checks for the NULL pointer and ignores the map event.
Related branches
- Robert Ancell: Approve
- PS Jenkins bot (community): Approve (continuous-integration)
-
Diff: 36 lines (+13/-11)1 file modifiedsrc/unity-greeter.vala (+13/-11)
visibility: | private → public |
tags: | added: rls-q-incoming |
tags: | added: saucy |
Changed in unity-greeter (Ubuntu): | |
status: | Confirmed → Triaged |
importance: | Medium → High |
tags: | added: ubuntu-desktop-trusty |
no longer affects: | unity-greeter (Ubuntu Raring) |
Changed in unity-greeter (Ubuntu Quantal): | |
status: | Won't Fix → New |
Changed in unity-greeter (Ubuntu Precise): | |
importance: | Undecided → Medium |
Changed in unity-greeter (Ubuntu Quantal): | |
status: | New → Won't Fix |
description: | updated |
Changed in unity-greeter (Ubuntu): | |
assignee: | nobody → Robert Ancell (robert-ancell) |
Changed in unity-greeter (Ubuntu Saucy): | |
importance: | Undecided → Medium |
Changed in unity-greeter (Ubuntu Precise): | |
status: | Confirmed → In Progress |
Changed in unity-greeter (Ubuntu): | |
status: | Triaged → In Progress |
Changed in unity-greeter (Ubuntu Precise): | |
assignee: | nobody → Robert Ancell (robert-ancell) |
Changed in unity-greeter (Ubuntu Quantal): | |
status: | Won't Fix → Triaged |
Changed in unity-greeter (Ubuntu Saucy): | |
status: | New → Triaged |
StacktraceTop: get_type_ hint (window=0x0) at /build/ buildd/ gtk+3.0- 3.5.16/ ./gdk/gdkwindow .c:10210 greeter_ focus_upon_ map (event=<optimized out>, gxevent=<optimized out>) at unity-greeter.c:715 greeter_ focus_upon_ map_gdk_ filter_ func (xevent=<optimized out>, event=<optimized out>, self=<optimized out>) at unity-greeter.c:757 apply_filters (xevent= xevent@ entry=0x7fff5d0 f6e60, event=event@ entry=0xb1d9d0, window= window@ entry=0x827000) at /build/ buildd/ gtk+3.0- 3.5.16/ ./gdk/x11/ gdkeventsource. c:81 source_ translate_ event (xevent= 0x7fff5d0f6e60, event_source= 0x8301a0) at /build/ buildd/ gtk+3.0- 3.5.16/ ./gdk/x11/ gdkeventsource. c:202
gdk_window_
unity_
_unity_
gdk_event_
gdk_event_