restart broken - Regression Caused by LP: #600941
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
nagios-nrpe (Debian) |
Fix Released
|
Unknown
|
|||
nagios-nrpe (Ubuntu) |
Fix Released
|
Medium
|
Stéphane Graber | ||
Hardy |
Fix Released
|
Undecided
|
Stéphane Graber | ||
Lucid |
Fix Released
|
Undecided
|
Stéphane Graber | ||
Maverick |
Won't Fix
|
Undecided
|
Unassigned | ||
Natty |
Fix Released
|
Undecided
|
Stéphane Graber | ||
Oneiric |
Fix Released
|
Undecided
|
Stéphane Graber | ||
Precise |
Fix Released
|
Medium
|
Stéphane Graber | ||
Quantal |
Fix Released
|
Medium
|
Stéphane Graber |
Bug Description
After LP: #600941 was pushed out all of our systems started experiencing Nagios nrpe restart failures.
Commands like /etc/init.
would cause nrpe to stop but not restart.
I tracked this down to the way that the /etc/init.
The issue is that the "stop" stanza in the /etc/init.
If nrpe has not exited by that time the pid file will still exist and the /etc/init.
Worse if /etc/init.
The attempt to start under those circumstances will fail because nrpe will still be bound to a socket and the second attempt at binding will cause the nrpe startup to abort.
They should have wondered why there was a comment about "sometimes the pid file does not get removed".
They should have tested on systems that have a heavy load and therefore slow nrpe response times.
The fix is to add --retry 10 or such to the invocation of start-stop-daemon ... --stop ...
Patch forthcoming, see
See also
https:/
ProblemType: Bug
DistroRelease: Ubuntu 12.04
Package: nagios-nrpe-server (not installed)
ProcVersionSign
Uname: Linux 3.2.0-1-generic i686
ApportVersion: 1.90-0ubuntu1
Architecture: i386
Date: Fri Nov 25 14:38:05 2011
InstallationMedia: Ubuntu 11.10 "Oneiric Ocelot" - Release i386 (20111011)
ProcEnviron:
PATH=(custom, no user)
LANG=en_US.UTF-8
SHELL=/bin/bash
SourcePackage: nagios-nrpe
UpgradeStatus: No upgrade log present (probably fresh install)
Related branches
- Ubuntu branches: Pending requested
-
Diff: 34 lines (+8/-4)2 files modifieddebian/changelog (+6/-0)
debian/nagios-nrpe-server.init (+2/-4)
- Ubuntu branches: Pending requested
-
Diff: 86 lines (+29/-14)5 files modifieddebian/TODO (+5/-0)
debian/changelog (+21/-0)
debian/control (+1/-1)
debian/nagios-nrpe-server.init (+2/-4)
debian/nagios-nrpe-server.postrm (+0/-9)
description: | updated |
tags: | added: regression-update |
summary: |
- Fix Regression Caused by LP: #600941 + restart broken - Regression Caused by LP: #600941 |
Changed in nagios-nrpe (Debian): | |
status: | Unknown → New |
Changed in nagios-nrpe (Debian): | |
status: | New → Fix Released |
Changed in nagios-nrpe (Ubuntu Maverick): | |
status: | Confirmed → Won't Fix |
Changed in nagios-nrpe (Ubuntu Hardy): | |
assignee: | nobody → Stéphane Graber (stgraber) |
Changed in nagios-nrpe (Ubuntu Lucid): | |
assignee: | nobody → Stéphane Graber (stgraber) |
Changed in nagios-nrpe (Ubuntu Natty): | |
assignee: | nobody → Stéphane Graber (stgraber) |
Changed in nagios-nrpe (Ubuntu Oneiric): | |
assignee: | nobody → Stéphane Graber (stgraber) |
Changed in nagios-nrpe (Ubuntu Hardy): | |
status: | Confirmed → In Progress |
Changed in nagios-nrpe (Ubuntu Lucid): | |
status: | Confirmed → In Progress |
Changed in nagios-nrpe (Ubuntu Natty): | |
status: | Confirmed → In Progress |
Changed in nagios-nrpe (Ubuntu Oneiric): | |
status: | Confirmed → In Progress |
Changed in nagios-nrpe (Ubuntu Precise): | |
status: | Confirmed → In Progress |
Changed in nagios-nrpe (Ubuntu Precise): | |
status: | In Progress → Fix Committed |
Changed in nagios-nrpe (Ubuntu Oneiric): | |
status: | In Progress → Fix Committed |
Changed in nagios-nrpe (Ubuntu Natty): | |
status: | In Progress → Fix Committed |
Changed in nagios-nrpe (Ubuntu Lucid): | |
status: | In Progress → Fix Committed |
Changed in nagios-nrpe (Ubuntu Hardy): | |
status: | In Progress → Fix Committed |
I'm unfortunately in a bit of a rush with alpha-1 being released next week so don't expect to have time to work on this for the next week or so.
In the mean time, could you forward that bug and fix to Debian? it'd make the process on Ubuntu's side much easier if it gets fixed in Debian first.
Our current init script (the one included in the SRU) is a perfect copy/paste from Debian's, so your bug most likely affects them too and so it'd be the right place to get the fix included.
Thanks