Dash - Sources filter shouldn't be shown if there's just one item
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ayatana Design |
Fix Released
|
Medium
|
John Lea | ||
Unity |
Fix Released
|
Undecided
|
Unassigned | ||
libunity |
Fix Released
|
Low
|
Michal Hruby | ||
libunity (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
Precise |
Fix Released
|
Undecided
|
Unassigned | ||
unity (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
Precise |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
Test case:
1. Make sure that your system has only Banshee or Rhythmbox installed - only one of the two
2. Open the dash
3. Switch to the music lens
4. Open the filters
-> There should be no 'Sources' filter category visible
===
Currently we display the Sources filter as soon as there's at least one item, but that doesn't make sense, cause you can't disable just that one item.
We should be showing the filter only when there are at least two items and moreover the default lenses that do not export any sources (files + music) need to export at least one, so that when extra scopes for these are installed, everything will be showing up properly.
-------
Desired Solution:
- Only display the source filter when there are two or more sources.
- The default Lenses should all include a "Local files/music/videos" source (of course if this is the only source it should not be displayed).
Related branches
- Mikkel Kamstrup Erlandsen (community): Approve
-
Diff: 15 lines (+3/-1)1 file modifiedsrc/unity-lens-private.vala (+3/-1)
tags: | added: needs-design |
Changed in unity: | |
status: | New → Incomplete |
Changed in unity-lens-files: | |
status: | New → Incomplete |
Changed in unity-lens-music: | |
status: | New → Incomplete |
Changed in libunity: | |
status: | New → Incomplete |
description: | updated |
tags: |
added: udp removed: needs-design |
Changed in ayatana-design: | |
status: | New → Triaged |
Changed in unity-lens-music: | |
status: | Incomplete → Confirmed |
Changed in unity: | |
milestone: | none → backlog |
status: | Incomplete → Confirmed |
Changed in libunity: | |
status: | Incomplete → Confirmed |
Changed in unity-lens-files: | |
status: | Incomplete → Confirmed |
Changed in ayatana-design: | |
assignee: | nobody → John Lea (johnlea) |
importance: | Undecided → Medium |
Changed in libunity: | |
status: | Confirmed → In Progress |
assignee: | nobody → Michal Hruby (mhr3) |
milestone: | none → 5.12.0 |
importance: | Undecided → Low |
Changed in libunity: | |
status: | In Progress → Fix Committed |
Changed in ayatana-design: | |
status: | Triaged → Fix Committed |
Changed in unity: | |
status: | Confirmed → Invalid |
Changed in unity: | |
status: | Invalid → Fix Committed |
description: | updated |
Changed in unity: | |
milestone: | backlog → 5.12.0 |
no longer affects: | unity-lens-files |
no longer affects: | unity-lens-music |
no longer affects: | unity-lens-files (Ubuntu) |
no longer affects: | unity-lens-music (Ubuntu) |
Changed in libunity: | |
status: | Fix Committed → Fix Released |
Changed in unity: | |
status: | Fix Committed → Fix Released |
tags: |
added: verification-done removed: verification-needed |
tags: |
added: verification-failed removed: verification-done |
Changed in libunity (Ubuntu Precise): | |
status: | Fix Committed → Fix Released |
summary: |
- Sources filter shouldn't be shown if there's just one item + Dash - Sources filter shouldn't be shown if there's just one item |
Changed in ayatana-design: | |
status: | Fix Committed → Fix Released |
tags: |
added: reviewedbydesignq removed: udp |
no longer affects: | libunity (Ubuntu Quantal) |
Hello Michal, or anyone else affected,
Accepted libunity into precise-proposed. The package will build now and be available in a few hours. Please test and give feedback here. See https:/ /wiki.ubuntu. com/Testing/ EnableProposed for documentation how to enable and use -proposed. Thank you in advance!