[SRU] regression: walinuxagent incorrectly sets unsupported dhcp parameter

[Ben Howard]

SRU Justification

Impact: The fix for bug #1268050 on 12.04 switches the dhcpclient.conf configuration from "<hostname>" to gethostname(). This fix, while valid for later versions of isc-dhcp-client, in invalid for 12.04. Therefore, this fix should be reverted and remediated.

Fix: Revert previous patch

Test case:
- Launch new Azure instance with serial of 20140408
- Install new package
- Confirm that /etc/dhcp/dhclient.conf has 'send hostname "<hostname>"'

[Ben Howard (darkmuggle-deactivatedaccount)]

Tested patch, and confirmed it removes the regression.

[Ben Howard (darkmuggle-deactivatedaccount)]

Upload fix, pending SRU.

[Stephen A. Zarkos (stevez)]

Hi Ben,

Is it necessary to revert the patch to /usr/sbin/waagent itself rather than just the packaging? The original issue was about users calling 'waagent -deprovision', so my concern is that this issue might pop up again if we revert that patch.

As far as I can tell the fix to waagent is working as expected. The agent currently calls UpdateAndPublishHostName()->UpdateAndPublishHostNameCommon() only if "Provisioning.MonitorHostName=y" in waagent.conf (it is set to 'n' on 12.04), or if we run -deprovision. If it sees ether send '<hostname>' or 'gethostname()' it will not touch the dhclient.conf file. The problem here is that dhclient.conf is misconfigured after even the first provision.

Thanks,
Steve

[Ben Howard (darkmuggle-deactivatedaccount)]

Confirmed Stephen's comment with packaging changes. The attached debdiff fixes the problem.

I've confirmed Stephen's assessment and confirmed the fix via packaging changes. Uploaded new version for SRU.

[Robert C Jennings (rcj)]

Verified with version 1.3.2-0ubuntu4~12.04.7 on Azure. Installation of package resulted in 'send host-name "<hostname>";' in /etc/dhcp/dhclient.conf.

[Launchpad Janitor (janitor)]

This bug was fixed in the package walinuxagent - 1.3.2-0ubuntu4~12.04.7

---------------
walinuxagent (1.3.2-0ubuntu4~12.04.7) precise; urgency=medium

  * Revert of regression introduced with LP: #1268050: use compatible
    DHCP send hostname (LP: #1308974)
 -- Ben Howard <email address hidden> Thu, 17 Apr 2014 11:51:14 -0600

[Chris J Arges (arges)]

The verification of the Stable Release Update for walinuxagent has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regresssions.