Ubuntu

Dash - Sources filter shouldn't be shown if there's just one item

Reported by Michal Hruby on 2012-02-24
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ayatana Design
Medium
John Lea
Unity
Undecided
Unassigned
libunity
Low
Michal Hruby
libunity (Ubuntu)
Undecided
Unassigned
Precise
Undecided
Unassigned
Quantal
Undecided
Unassigned
unity (Ubuntu)
Undecided
Unassigned
Precise
Undecided
Unassigned

Bug Description

Test case:
1. Make sure that your system has only Banshee or Rhythmbox installed - only one of the two
2. Open the dash
3. Switch to the music lens
4. Open the filters
   -> There should be no 'Sources' filter category visible

===

Currently we display the Sources filter as soon as there's at least one item, but that doesn't make sense, cause you can't disable just that one item.

We should be showing the filter only when there are at least two items and moreover the default lenses that do not export any sources (files + music) need to export at least one, so that when extra scopes for these are installed, everything will be showing up properly.

-----------------------------------------------
Desired Solution:

- Only display the source filter when there are two or more sources.

- The default Lenses should all include a "Local files/music/videos" source (of course if this is the only source it should not be displayed).

tags: added: needs-design
Changed in unity:
status: New → Incomplete
Changed in unity-lens-files:
status: New → Incomplete
Changed in unity-lens-music:
status: New → Incomplete
Changed in libunity:
status: New → Incomplete
John Lea (johnlea) on 2012-04-19
description: updated
tags: added: udp
removed: needs-design
Changed in ayatana-design:
status: New → Triaged
Changed in unity-lens-music:
status: Incomplete → Confirmed
Changed in unity:
milestone: none → backlog
status: Incomplete → Confirmed
Changed in libunity:
status: Incomplete → Confirmed
John Lea (johnlea) on 2012-04-19
Changed in unity-lens-files:
status: Incomplete → Confirmed
Changed in ayatana-design:
assignee: nobody → John Lea (johnlea)
importance: Undecided → Medium
Michal Hruby (mhr3) on 2012-04-20
Changed in libunity:
status: Confirmed → In Progress
assignee: nobody → Michal Hruby (mhr3)
milestone: none → 5.12.0
importance: Undecided → Low
Changed in libunity:
status: In Progress → Fix Committed
Tim Penhey (thumper) on 2012-04-23
Changed in ayatana-design:
status: Triaged → Fix Committed
Changed in unity:
status: Confirmed → Invalid
Changed in unity:
status: Invalid → Fix Committed
description: updated
Didier Roche (didrocks) on 2012-04-27
Changed in unity:
milestone: backlog → 5.12.0
no longer affects: unity-lens-files
no longer affects: unity-lens-music
Didier Roche (didrocks) on 2012-04-27
no longer affects: unity-lens-files (Ubuntu)
no longer affects: unity-lens-music (Ubuntu)
Didier Roche (didrocks) on 2012-04-27
Changed in libunity:
status: Fix Committed → Fix Released
Changed in unity:
status: Fix Committed → Fix Released

Hello Michal, or anyone else affected,

Accepted libunity into precise-proposed. The package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

Changed in libunity (Ubuntu Precise):
status: New → Fix Committed
tags: added: verification-needed
Martin Pitt (pitti) wrote :

Hello Michal, or anyone else affected,

Accepted unity into precise-proposed. The package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

Changed in unity (Ubuntu Precise):
status: New → Fix Committed
Omer Akram (om26er) on 2012-04-27
tags: added: verification-done
removed: verification-needed
Launchpad Janitor (janitor) wrote :
Download full text (6.0 KiB)

This bug was fixed in the package unity - 5.12-0ubuntu1

---------------
unity (5.12-0ubuntu1) precise-proposed; urgency=low

  * New upstream release.
    - Launcher, Alt-Tab - clicking on launcher item or selecting a app in Alt-
      Tab raises all app windows, not just most recently focused (LP: #959339)
    - [heap corruption?] compiz crashed with SIGSEGV in _int_malloc() from
      g_realloc() from ... from g_dbus_connection_send_message_with_reply()
      from g_object_unref() from unity::dash::HomeLens::Impl::~Impl() from
      unity::dash::HomeLens::~HomeLens() (LP: #931201)
    - compiz crashed with SIGSEGV in _int_malloc() from __libc_calloc() from
      XOpenDisplay() from nux::WindowThread::ThreadCtor() (LP: #947844)
    - Regression: Installing apps causes a terrible visual glitch-- have to
      restart X.org. (LP: #981168)
    - Window management - unity doesn't realise when applications bring their
      windows to the front (LP: #802816)
    - Dash - Clicking on the desktop dash border should do nothing, *NOT*
      close the dash (LP: #839472)
    - [FFe, UIFe] HUD - The HUD does not respect launcher icon size settings
      in autohide mode (LP: #921506)
    - compiz crashed with SIGSEGV in g_volume_get_mount() (LP: #918548)
    - multiple instances or double icons of application detected on bamfdaemon
      respawn (LP: #928912)
    - Panel is transparent when Dash is open; no blur no average BG color
      (LP: #965323)
    - Unity crashes with SIGSEGV when hitting debug DBus interface hard
      (LP: #979429)
    - compiz crashed with SIGSEGV in _int_malloc() from g_object_unref() from
      unity::dash::Model<unity::dash::FilterAdaptor>::~Model() (LP: #941750)
    - indicators menu are sometimes cut off at screen edge (LP: #883317)
    - the shortcut keys in workspace section of the shortcut overlay aren't
      translated (LP: #980828)
    - [regression] Dash keeps repainting unnecessarily (LP: #980924)
    - compiz crashed with SIGSEGV in nux::NTextureData::ClearData() from
      nux::NTextureData::~NTextureData() from nux::Texture2D::~Texture2D()
      (LP: #952378)
    - compiz crashed with SIGSEGV in g_object_unref() from
      unity::dash::Settings::~Settings() from
      unity::UnityScreen::~UnityScreen() (LP: #981764)
    - compiz crashed with SIGSEGV in unity::dash::ResultView::~ResultView()
      from unity::dash::ResultViewGrid::~ResultViewGrid() from
      nux::Object::Destroy() from nux::Object::UnReference() (LP: #942286)
    - compiz crashed with SIGSEGV in
      ends_with_iter_select<__gnu_cxx::__normal_iterator<char const*,
      std::basic_string<char> >, char const*, boost::algorithm::is_iequal>()
      from unity::ui::PointerBarrierWrapper::EmitCurrentData() (LP: #983268)
    - Chinese can't be shown completely in dash filter (LP: #984583)
    - [Unity 5.10] compiz crashed with SIGSEGV in
      unity::hud::HudIconTextureSource::ColorForIcon() from
      unity::hud::Icon::Icon() from emit from unity::IconTexture::IconLoaded
      (LP: #983646)
    - [regression] Close button does not close the dash/HUD (LP: #986264)
    - compiz crashed with SIGSEGV in g_volume_eject_with_operation_finish()
      fro...

Read more...

Changed in unity (Ubuntu):
status: New → Fix Released
Changed in unity (Ubuntu Precise):
status: Fix Committed → Fix Released
tags: added: verification-failed
removed: verification-done
Nekhelesh Ramananthan (nik90) wrote :

This bug is not fixed. Please see the attached screenshot at http://ubuntuone.com/243IUP3enCO4f1K6rRZPRM . Hence adding the verification-failed tag.

The output of apt-cache policy unity

Installed: 5.12-0ubuntu1
  Candidate: 5.12-0ubuntu1
  Version table:
 *** 5.12-0ubuntu1 0
        500 http://nl.archive.ubuntu.com/ubuntu/ precise-updates/main i386 Packages
        100 /var/lib/dpkg/status
     5.10.0-0ubuntu6 0
        500 http://nl.archive.ubuntu.com/ubuntu/ precise/main i386 Packages

Michal Hruby (mhr3) wrote :

The fix works fine, you need to log out after installing the upgrade.

tags: added: verification-done
removed: verification-failed
Michal Hruby (mhr3) wrote :

Perhaps the confusion came from the package, this is actually fixed in:

libunity9:
  Installed: 5.12.0-0ubuntu1
  Candidate: 5.12.0-0ubuntu1

Launchpad Janitor (janitor) wrote :

This bug was fixed in the package libunity - 5.12.0-0ubuntu1

---------------
libunity (5.12.0-0ubuntu1) precise-proposed; urgency=low

  * New upstream release.
    - Remote scopes are not restarted after crash (LP: #984760)
    - Sources filter shouldn't be shown if there's just one item (LP: #940161)
    - hash tables, strings, and variants leaked in LauncherEntry.serialize()
      (LP: #981309)
  * debian/libunity9.symbols:
    - adding an internal symbol
 -- Didier Roche <email address hidden> Fri, 27 Apr 2012 11:00:23 +0200

Changed in libunity (Ubuntu):
status: New → Fix Released
Changed in libunity (Ubuntu Precise):
status: Fix Committed → Fix Released
John Lea (johnlea) on 2012-09-03
summary: - Sources filter shouldn't be shown if there's just one item
+ Dash - Sources filter shouldn't be shown if there's just one item
Changed in ayatana-design:
status: Fix Committed → Fix Released
tags: added: reviewedbydesignq
removed: udp
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers