cps_ plugin autodetection is broken
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
munin (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
Precise |
Won't Fix
|
Medium
|
Unassigned |
Bug Description
Summary: Please apply https:/
I'm using these packages:
ii munin-common 1.4.6-3ubuntu3.1 network-wide graphing framework (common)
ii munin-node 1.4.6-3ubuntu3.1 network-wide graphing framework (node)
On 12.04.1 (precise).
The problem is with the cps_ plugin. It suggests the following plugins:
# /usr/share/
cps_1.1.1.1_21
cps_1.1.1.1_80
cps_1.1.1.1_873
cps_2.2.2.2_21
cps_2.2.2.2_80
cps_2.2.2.2_873
When these get created by munin-node-
# ls -la /etc/munin/
lrwxrwxrwx 1 root root 29 Aug 18 18:37 /etc/munin/
lrwxrwxrwx 1 root root 29 Aug 18 18:37 /etc/munin/
lrwxrwxrwx 1 root root 29 Aug 18 18:37 /etc/munin/
lrwxrwxrwx 1 root root 29 Oct 15 16:26 /etc/munin/
lrwxrwxrwx 1 root root 29 Aug 18 18:37 /etc/munin/
lrwxrwxrwx 1 root root 29 Oct 15 16:26 /etc/munin/
The code in cps_ parses $0:
unless ($0 =~ /cps(?:
die "Could not parse name $0.\n";
}
my $vip = $1;
my $port = $2;
As you can see, the cps_cps_ should be cps_. It's doubling this up which breaks the regex and therefore breaks the plugin.
The fix is quite simple:
--- cps_.orig 2012-10-15 16:14:14.580595524 +0100
+++ cps_ 2012-10-15 16:14:25.092431645 +0100
@@ -103,7 +103,7 @@
foreach my $vip (sort keys %{$ipvs}) {
foreach my $port (sort keys %{$ipvs->{$vip}}) {
- print "cps_${
+ print "${vip}_$port\n";
}
}
exit 0;
This creates the plugins with a single cps_ at the start and then everything works as expected.
The fix can also be seen upstream here:
https:/
It'd be great if this fix could be applied.
Related branches
- Brian Murray: Approve
-
Diff: 44 lines (+24/-0)3 files modifieddebian/changelog (+7/-0)
debian/patches/lp_1066942_cps_plugin_autodetection.patch (+16/-0)
debian/patches/series (+1/-0)
Changed in munin (Ubuntu): | |
importance: | Undecided → Medium |
status: | New → Triaged |
This is fixed in the trusty and utopic versions already. Therefore this patch needs to go through the SRU process as defined here: /wiki.ubuntu. com/StableRelea seUpdates
https:/
The patch looks pretty good, all that's needed to do is fill out the SRU template; and someone can sponsor that into precise.
Thanks!