Fix CVE-2016-9839 & CVE-2017-5522

[Johan Van de Wauw]

In MapServer before 7.0.3, OGR driver error messages are too verbose and may leak sensitive information if data connection fails.

https://people.canonical.com/~ubuntu-security/cve/2016/CVE-2016-9839.html

Packages for Debian have been updated - we should apply the same in Ubuntu.

[Emily Ratliff (emilyr)]

Thanks for taking the time to report this bug and helping to make Ubuntu better. Since the package referred to in this bug is in universe or multiverse, it is community maintained. If you are able, I suggest coordinating with upstream and posting a debdiff for this issue. When a debdiff is available, members of the security team will review it and publish the package. See the following link for more information: https://wiki.ubuntu.com/SecurityTeam/UpdateProcedures

[Bas Couwenberg (sebastic)]

In the mean time MapServer 7.0.4 has been released fixing CVE-2017-5522.

The packages in Debian have been updated to include the fix, as have the packages in the UbuntuGIS PPA.

I've also prepared updates for Ubuntu fixing both CVE-2016-9839 & CVE-2017-5522:

 https://anonscm.debian.org/cgit/pkg-grass/mapserver.git/log/?h=ubuntu-precise
 https://anonscm.debian.org/cgit/pkg-grass/mapserver.git/log/?h=ubuntu-trusty
 https://anonscm.debian.org/cgit/pkg-grass/mapserver.git/log/?h=ubuntu-vivid
 https://anonscm.debian.org/cgit/pkg-grass/mapserver.git/log/?h=ubuntu-xenial
 https://anonscm.debian.org/cgit/pkg-grass/mapserver.git/log/?h=ubuntu-yakkety

[Marc Deslauriers (mdeslaur)]

ACK on the trees in comment #2. I've uploaded packages for building with a couple of small changes:

- LP tag in changelog needs a "#" for it to be automatically picked up, as in LP: #1234
- CVE-2016-9839 patch was a bit broken on xenial and yakkety, which I've fixed, it was adding the following to the build log:

/<<PKGBUILDDIR>>/mapogr.cpp: In function ‘int msOGRFileWhichShapes(layerObj*, rectObj, msOGRFileInfo*)’:
/<<PKGBUILDDIR>>/mapogr.cpp:1671:74: warning: too many arguments for format [-Wformat-extra-args]
                  layer->filter.string+6, layer->name?layer->name:"(null)");
                                                                          ^

Once packages are built, I will release them as security updates. Thanks! :)

[Launchpad Janitor (janitor)]

This bug was fixed in the package mapserver - 7.0.1-3ubuntu0.1

---------------
mapserver (7.0.1-3ubuntu0.1) yakkety-security; urgency=medium

  * Add upstream patches to fix CVE-2016-9839 & CVE-2017-5522.
    (LP: #1648998)

 -- Bas Couwenberg <email address hidden> Wed, 18 Jan 2017 23:41:26 +0100

[Launchpad Janitor (janitor)]

This bug was fixed in the package mapserver - 6.4.1-2ubuntu0.1

---------------
mapserver (6.4.1-2ubuntu0.1) trusty-security; urgency=medium

  * Non-maintainer upload.
  * Add upstream patches to fix CVE-2016-9839 & CVE-2017-5522.
    (LP: #1648998)

 -- Bas Couwenberg <email address hidden> Wed, 18 Jan 2017 23:18:47 +0100

[Launchpad Janitor (janitor)]

This bug was fixed in the package mapserver - 7.0.0-9ubuntu3.1

---------------
mapserver (7.0.0-9ubuntu3.1) xenial-security; urgency=medium

  * Add upstream patches to fix CVE-2016-9839 & CVE-2017-5522.
    (LP: #1648998)

 -- Bas Couwenberg <email address hidden> Wed, 18 Jan 2017 23:38:33 +0100

[Launchpad Janitor (janitor)]

This bug was fixed in the package mapserver - 6.0.1-2ubuntu1.2

---------------
mapserver (6.0.1-2ubuntu1.2) precise-security; urgency=medium

  * Non-maintainer upload.
  * Add upstream patches to fix CVE-2016-9839 & CVE-2017-5522.
    (LP: #1648998)

 -- Bas Couwenberg <email address hidden> Wed, 18 Jan 2017 23:18:10 +0100