[12.04] thinkpad_acpi module does not load on V series thinkpad

[Manoj Iyer]

hotkeys do no work because thinkpad_acpi module fails to load.

[Manoj Iyer (manjo)]

SRU JUSTIFICATION
================

EFFECT
=====
Hotkeys do not work because thinkpad_acpi module does not load.

FIX
===
The newer V series bios reports product version as 'Lenovo' instead of 'ThinkPad'. Recoginze this new string so that the module can load.

TEST
====
This fix was tested by James Ferguson, Dennis Chua and Ike Pan and reported to work.

[Manoj Iyer (manjo)]

commit 23b0531641c72c6a2f410af1c593293fa353884b
Author: Manoj Iyer <email address hidden>
Date: Fri Mar 9 17:32:24 2012 -0600

    thinkpad-acpi: recognize Lenovo as version string in newer V-series BIOS

    The newer V series bios reports product version as 'Lenovo'
    instead of 'ThinkPad'. Recoginze this new string so that
    the module can load.

    Signed-off-by: Manoj Iyer <email address hidden>
    Signed-off-by: Matthew Garrett <email address hidden>
    Tested-by: James Ferguson <email address hidden>
    Tested-by: Dennis Chua <email address hidden>
    Tested-by: Ike Pan <email address hidden>
    Acked-by: Henrique de Moraes Holschuh <email address hidden>

[madbiologist (me-again)]

This fix is included in Ubuntu kernel 3.2.0-25.40, which is currently in precise-proposed. For instructions on how to enable and use -proposed, see https://wiki.ubuntu.com/Testing/EnableProposed

Looking at the names in this bug report I think you'll already know how to use -proposed, but I though it was worth mentioning in case someone else comes across this bug report before the fix is released to -updates.

[Luis Henriques (henrix)]

This bug is awaiting verification that the kernel for precise in -proposed solves the problem (3.2.0-25.40). Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-precise' to 'verification-done-precise'.

If verification is not done by one week from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

[Luis Henriques (henrix)]

Manoj Iyer, would it be possible for you (or someone else) to verify this bug?

[Manoj Iyer (manjo)]

Luis,

Sorry I am unable to disclose the model number so I masked it manually below. The new proposed kernel works on the V series machines.

== Before proposed kernel ==
u@u-Lenovo-VXXXs:~$ sudo modprobe thinkpad_acpi
[sudo] password for u:
FATAL: Error inserting thinkpad_acpi (/lib/modules/3.2.0-24-generic/kernel/drivers/platform/x86/thinkpad_acpi.ko): No such device

== After proposed kernel ==
u@u-Lenovo-VXXXs:~$ uname -a
Linux u-Lenovo-VXXXs 3.2.0-25-generic #40-Ubuntu SMP Wed May 23 20:30:51 UTC 2012 x86_64 x86_64 x86_64 GNU/Linux
u@u-Lenovo-VXXXs:~$ lsmod | grep think
thinkpad_acpi 81819 0
snd 78855 17 snd_hda_codec_hdmi,snd_hda_codec_realtek,snd_hda_intel,snd_hda_codec,snd_hwdep,thinkpad_acpi,snd_pcm,snd_rawmidi,snd_seq,snd_timer,snd_seq_device
nvram 14413 1 thinkpad_acpi
u@u-Lenovo-VXXXs:~$

[Herton R. Krzesinski (herton)]

Given feedback on comment #6, marking as verified for Precise

[Launchpad Janitor (janitor)]

This bug was fixed in the package linux - 3.2.0-25.40

---------------
linux (3.2.0-25.40) precise-proposed; urgency=low

  [Luis Henriques]

  * Release Tracking Bug
    - LP: #1003534

  [ Andy Whitcroft ]

  * [Config] control.stub is an intermediate product not a dependancy
    - LP: #992414
  * [Config] include include/generated/compile.h
    - LP: #942569

  [ Dave Martin ]

  * SAUCE: rtc: pl031: Enable module alias autogeneration for AMBA drivers
    - LP: #1000831

  [ Herton Ronaldo Krzesinski ]

  * Revert "SAUCE: ite-cir: postpone ISR registration"
    - LP: #1002484
  * SAUCE: async_populate_rootfs: fix build warnings
    - LP: #1003417

  [ Ike Panhc ]

  * [Config] add highbank flavour
    - LP: #1000831

  [ John Johansen ]

  * SAUCE: apparmor: fix long path failure due to disconnected path
    - LP: #955892
  * SAUCE: apparmor: fix profile lookup for unconfined
    - LP: #978038, #987371

  [ Mark Langsdorf ]

  * SAUCE: arm highbank: add support for pl320-ipc driver
    - LP: #1000831

  [ Rob Herring ]

  * SAUCE: input: add a key driver for highbank
    - LP: #1000831
  * SAUCE: ARM: highbank: Add smc calls to enable/disable the L2
    - LP: #1000831
  * SAUCE: force DMA buffers to non-bufferable on highbank
    - LP: #1000831
  * SAUCE: net: calxedaxgmac: fix net timeout recovery
    - LP: #1000831

  [ Tim Gardner ]

  * [Config] perarch and indep tools builds need separate build directories
  * [Config] CONFIG_XEN_ACPI_PROCESSOR=y
    - LP: #898112

  [ Upstream Kernel Changes ]

  * Revert "autofs: work around unhappy compat problem on x86-64"
    - LP: #1002482
  * Input: wacom - cleanup feature report for bamboos
    - LP: #568064
  * Input: wacom - remove unused bamboo HID parsing
    - LP: #568064
  * Input: wacom - add some comments to wacom_parse_hid
    - LP: #568064
  * Input: wacom - relax Bamboo stylus ID check
    - LP: #568064
  * Input: wacom - read 3rd gen Bamboo Touch HID data
    - LP: #568064
  * Input: wacom - 3rd gen Bamboo P&Touch packet support
    - LP: #568064
  * Input: wacom - ignore unwanted bamboo packets
    - LP: #568064
  * HID: wacom: Move parsing to a separate function
    - LP: #568064
  * HID: wacom: Initial driver for Wacom Intuos4 Wireless (Bluetooth)
    - LP: #568064
  * Input: wacom - add support for Cintiq 24HD
    - LP: #568064
  * Input: wacom - add LED support for Cintiq 24HD
    - LP: #568064
  * Input: wacom - add missing LEDS_CLASS to Kconfig
    - LP: #568064
  * Input: wacom - fix 3rd-gen Bamboo MT when 4+ fingers are in use
    - LP: #568064
  * power_supply: allow a power supply to explicitly point to powered
    device
    - LP: #568064
  * power_supply: add "powers" links to self-powered HID devices
    - LP: #568064
  * HID: wiimote: fix invalid power_supply_powers call
    - LP: #568064
  * HID: wacom: Fix invalid power_supply_powers calls
    - LP: #568064
  * ARM: 7178/1: fault.c: Port OOM changes into do_page_fault
    - LP: #951043
  * ARM: 7368/1: fault.c: correct how the tsk->[maj|min]_flt gets
    incremented
    - LP: #951043
  * hugepages: fix use after free bug in "quota" handling
    - LP: #990368
    - CVE-2012-2133
  * provide disable_cpufreq() functio...

[Adam Conrad (adconrad)]

The verification of this Stable Release Update has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regresssions.