Support smart formatting for relation-ids command
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
pyjuju |
Fix Released
|
High
|
Jim Baker | ||
juju (Ubuntu) |
Fix Released
|
High
|
Unassigned | ||
Precise |
Fix Released
|
High
|
Unassigned |
Bug Description
== SRU Justification ==
=== Impact ===
Charms written in shell, which is the bulk of charms, cannot make use of the output of this command. Also charms written using the documentation as a guide will not work because the docs say it works this way.
=== Test Case ===
1. juju bootstrap
2. juju deploy --repository /usr/share/
3. juju deploy --repository /usr/share/
4. juju debug-hooks wordpress/0 db
5. juju add-relation mysql wordpress
6. When the db-relation-joined hook window opens up run 'relation-ids'. Affected versions will print out json, while fixed versions will print out a list, something like "db:0\n"
=== Dev fix ===
Fixed in upstream commit 532
=== Regression Potential ===
Medium. Charms may have already been written that are using the broken behavior. They will have to add --format=json but other than that will work fine. This is mitigated by the fact that the official PPA version is already fixed, and many users, including the charm store automated testing suite use that version.
== Original Bug Description ==
Adds format_smart method for RelationIdsCli, which outputs whitespace separated (to be precise, per line) relation idents.
Related branches
- Juju Engineering: Pending requested
-
Diff: 53 lines (+31/-1)2 files modifiedjuju/hooks/commands.py (+4/-0)
juju/hooks/tests/test_invoker.py (+27/-1)
Changed in juju: | |
assignee: | nobody → Jim Baker (jimbaker) |
milestone: | none → honolulu |
status: | New → In Progress |
Changed in juju: | |
status: | In Progress → Fix Released |
Changed in juju: | |
importance: | Undecided → High |
description: | updated |
Changed in juju (Ubuntu): | |
status: | New → Fix Released |
Changed in juju (Ubuntu Precise): | |
status: | New → Triaged |
Changed in juju (Ubuntu): | |
importance: | Undecided → High |
Changed in juju (Ubuntu Precise): | |
importance: | Undecided → High |
Changed in juju (Ubuntu Precise): | |
milestone: | none → ubuntu-12.04.1 |
How serious is this bug? Worth updating juju in precise?