fbautostart fails to handle XDG paths correctly

[Paul Tagliamonte]

This has been fixed upstream. This bug is to track it's status in ubuntu.

Paths such as "/etc/foo:/etc/bar" will result in fbautostart trying to find a literal path of that name, rather then splitting on the ":".

[Impact]
XDG_CONFIG_DIRS on Ubuntu has this by default now, so this affects all installs.

[Test Case]
export XDG_CONFIG_HOME=$TESTROOT/testdirl1
export XDG_CONFIG_DIRS=$TESTROOT/testdirg1:$TESTROOT/testdirg2:$TESTROOT/testdirg3
fbautostart

Where testdir[l|g]\d is a proper XDG autostart directory. Notice that it doesn't autostart correctly. Upstream git has a directory that is set up in such a way.

[Regression Potential]
Low. Since there's already been a regression, it's unlikely this is any less stable then the version currently in -P.

[Paul Tagliamonte (paultag)]

Ubuntu's default will break OTB with -P series.

[Paul Tagliamonte (paultag)]

Fixed in 2.718281828 -- Debian upload pending.

[Paul Tagliamonte (paultag)]

debdiff attached. ACK'd fix.

[tag@chayot:~/dev/local/fbautostart/maintainer][master]$ dpkg -l | grep fbautostart | awk '{print $3}'w
2.718281-1
[tag@chayot:~/dev/local/fbautostart/maintainer][master]$ ./runtests
tdg1.1 OK
tdg1.2 OK
ERROR! FILE DNE: tdg2.1
[tag@chayot:~/dev/local/fbautostart/maintainer][master]$ dpkg -l | grep fbautostart | awk '{print $3}'w
2.718281-1ubuntu1
[tag@chayot:~/dev/local/fbautostart/maintainer][master]$ ./runtests
tdg1.1 OK
tdg1.2 OK
tdg2.1 OK
tdg2.2 OK
tdg3.1 OK
tdg3.2 OK
tdl1.1 OK
tdl1.2 OK
Stage one OK
/home/tag/dev/local/fbautostart/maintainer
tdg1.1 OK (DNE)
tdg1.2 OK (DNE)
/home/tag/dev/local/fbautostart/maintainer
[tag@chayot:~/dev/local/fbautostart/maintainer][master]$

[Paul Tagliamonte (paultag)]

Q- series sync filed as #1014807

[Nathan Handler (nhandler)]

Can you pleas e fix the version in your debdiff? You can follow the scheme that the Security Team describes at https://wiki.ubuntu.com/SecurityTeam/UpdatePreparation#Update_the_packaging . If you need more examples, you can look at http://people.canonical.com/~ubuntu-archive/pending-sru.html

[Paul Tagliamonte (paultag)]

Debdiff attached with a new version string.

Thanks!

[Paul Tagliamonte (paultag)]

The "tests" can be run as follows:

[tag@chayot:~/reviews/debian][03:51 PM]$ git clone git://github.com/paultag/fbautostart.git
Cloning into 'fbautostart'...
remote: Counting objects: 644, done.
remote: Compressing objects: 100% (338/338), done.
remote: Total 644 (delta 366), reused 547 (delta 275)
Receiving objects: 100% (644/644), 219.55 KiB, done.
Resolving deltas: 100% (366/366), done.
[tag@chayot:~/reviews/debian][03:51 PM]$ cd fbautostart/
[tag@chayot:~/reviews/debian/fbautostart][master]$ cd maintainer/
[tag@chayot:~/reviews/debian/fbautostart/maintainer][master]$ ./runtests

The first time it's run, it'll complain about a directory not being there. It's a harmless error that doesn't affect the "tests".

[Nathan Handler (nhandler)]

Package built in a precise ppa (https://launchpad.net/~nhandler/+archive/ppa/+sourcepub/2516755/+listing-archive-extra). I was also able to reproduce the test results that Paul posted in this bug report.

[Devid Antonio Filoni (d.filoni)]

ubuntu-sru ACK!

[Chris Halse Rogers (raof)]

Hello Paul, or anyone else affected,

Accepted fbautostart into precise-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/fbautostart/2.718281-1ubuntu0.1 in a few hours and then in the -proposed repository. Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you please change the bug tag from verification-needed to verification-done. If it does not, change the tag to verification-failed. In either case details of your testing will help us make a better decision. Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Paul Tagliamonte (paultag)]

ACK, will test tonight.

Thanks raof & d.filoni!

[Nathan Handler (nhandler)]

I was able to confirm that the package in precise-proposed allows the tests that Paul posted to pass when run in a minimal precise chroot environment. These tests likewise fail when run against the version of fbautostart current in precise.

[Paul Tagliamonte (paultag)]

I also confirm nhandler's results from a clean precise machine

[Steve Langasek (vorlon)]

The Precise Pangolin has reached end of life, so this bug will not be fixed for that release