| 2012-01-05 11:01:24 |
Paolo Pisati |
description |
Per email discussion, we shouldn't carry any of SAUCE patch to properly detect Beagle XM revision since 3.0, so these should go:
2446424 UBUNTU: SAUCE: omap3: beagle: if rev unknown, assume xM revision C
0f3ba04 UBUNTU: SAUCE: omap3: beagle: detect new xM revision B
ea13e9e UBUNTU: SAUCE: omap3: beaglexm: fix DVI initialization |
Per email discussion, we shouldn't carry any of SAUCE patch to properly detect Beagle XM revision since 3.0, so these should go:
3d45106 UBUNTU: SAUCE: omap3: beagle: if rev unknown, assume xM revision C
72bc65c UBUNTU: SAUCE: omap3: beagle: detect new xM revision B
46153cc UBUNTU: SAUCE: omap3: beaglexm: fix DVI initialization |
|
| 2012-01-05 11:17:05 |
Paolo Pisati |
description |
Per email discussion, we shouldn't carry any of SAUCE patch to properly detect Beagle XM revision since 3.0, so these should go:
3d45106 UBUNTU: SAUCE: omap3: beagle: if rev unknown, assume xM revision C
72bc65c UBUNTU: SAUCE: omap3: beagle: detect new xM revision B
46153cc UBUNTU: SAUCE: omap3: beaglexm: fix DVI initialization |
Per email discussion, we shouldn't carry any of SAUCE patch to properly detect Beagle XM revision since 3.0, so these should go:
3d45106 UBUNTU: SAUCE: omap3: beagle: if rev unknown, assume xM revision C
72bc65c UBUNTU: SAUCE: omap3: beagle: detect new xM revision B
46153cc UBUNTU: SAUCE: omap3: beaglexm: fix DVI initialization
-----
some details about the problem:
[snip]
>> there is an issue with commit 750dfba493ae205b21de78b60d85f42fd5992894 in
>> ubuntu-precise.git:
>>
>> arch/arm/mach-omap2/board-omap3beagle.c
>> @@ -60,7 +60,8 @@
>> * AXBX = GPIO173, GPIO172, GPIO171: 1 1 1
>> * C1_3 = GPIO173, GPIO172, GPIO171: 1 1 0
>> * C4 = GPIO173, GPIO172, GPIO171: 1 0 1
>> - * XMA/XMB = GPIO173, GPIO172, GPIO171: 0 0 0
>> + * XMA = GPIO173, GPIO172, GPIO171: 0 0 0
>> + * XMB = GPIO173, GPIO172, GPIO171: 0 0 1
>> * XMC = GPIO173, GPIO172, GPIO171: 0 1 0
>> @@ -142,10 +143,14 @@ static void __init omap3_beagle_init_rev(void)
>> beagle_config.usr_button_gpio = 7;
>> break;
>> case 0:
>> - printk(KERN_INFO "OMAP3 Beagle Rev: xM Ax/Bx\n");
>> + printk(KERN_INFO "OMAP3 Beagle Rev: xM A\n");
>> omap3_beagle_version = OMAP3BEAGLE_BOARD_XM;
>> beagle_config.usb_pwr_level = GPIOF_OUT_INIT_HIGH;
>> break;
>> + case 1:
>> + printk(KERN_INFO "OMAP3 Beagle Rev: xM B\n");
>> + omap3_beagle_version = OMAP3BEAGLE_BOARD_XM;
>> + break;
>> case 2:
>> printk(KERN_INFO "OMAP3 Beagle Rev: xM C\n");
>> omap3_beagle_version = OMAP3BEAGLE_BOARD_XMC;
>>
>>
>> I do own a beagle-xm rev B and the GPIOs are all zero, so beagle-xm rev A
>> and rev B is indistinguishible (the beaglebord reference does not give
>> GPIOs for rev B, AFAIK)
>>
>> in case there would a rev B would be detected as such, the line
>> beagle_config.usb_pwr_level = GPIOF_OUT_INIT_HIGH;
>> is missing for the case 1 (for rev B) -- only rev C changed the USB power
>> initialization, not rev. B
> Yeah, patches for xM B's can be dropped. When Gerald/CircuitCo first
> announced the "rev B" all the docs/spreadsheets showed a gpio hi/low
> change for detection.. During "production" this change was
> forgotten.. All xm B's are xM A's. (Personally confirmed many times
> with Gerald/CircuitCo). (the only real difference was a revision bump
> on the dm3730..)
>
> As of mainline kernel 3.0, ubuntu shouldn't have to carry any "xM"
> detection related patches...
>
Actually looking at:
http://git.linaro.org/gitweb?p=ubuntu/linux-linaro-precise.git;a=history;f=arch/arm/mach-omap2/board-omap3beagle.c;h=541c8262c6fd005d92d471922050c91fa1de2bc2;hb=HEAD
2011-11-16 Robert Nelson UBUNTU: SAUCE: omap3: beagle: if rev unknown, assume
2011-11-16 Robert Nelson UBUNTU: SAUCE: omap3: beagle: detect new xM revision B
2011-11-16 Ricardo Salveti... UBUNTU: SAUCE: omap3: beaglexm: fix DVI
initialization
should be dropped as:
Joel's commit:
http://git.linaro.org/gitweb?p=ubuntu/linux-linaro-precise.git;a=commit;h=5fe8b4c19dc24e3bb873daf9e96a2439a83bbd79
fixed all those.. |
|
