mount.ecryptfs_private is broken on arm
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
ecryptfs-utils (Ubuntu) |
Fix Released
|
Low
|
Unassigned | ||
Oneiric |
Fix Released
|
Low
|
Unassigned | ||
Precise |
Fix Released
|
Low
|
Unassigned |
Bug Description
=======
SRU Justification:
1. Impact: mount.ecryptfs_
2. Development fix: the infinite loop happens because an unsigned char is being compared to -1 as a condition to end the loop
3. Stable fix: same as development fix
4. Test case: run 'mount.
5. Regression potential: I used this updated code (on arm) for a week with no issues. If there were a regression it should have been seen (at argument parsing time) during regular use of mount.ecryptfs_
=======
char is unsigned on arm (signed on x86).
fetch_sig compares the result of fgetc to EOF (-1), which of course never succeeds, causing an infinite loop.
Related branches
description: | updated |
tags: |
added: verification-done removed: verification-needed |
The mount.ecryptfs_ private. c changes look good to me.