Activity log for bug #2039172

Date Who What changed Old value New value Message
2023-10-12 11:55:08 Julian Andres Klode bug added bug
2023-10-12 11:55:18 Julian Andres Klode bug watch added https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1051543
2023-10-12 11:55:18 Julian Andres Klode bug task added grub2 (Debian)
2023-10-12 11:56:04 Julian Andres Klode description [Impact] Multi-extent directories are not parsed correctly by grub's XFS code in 2.12~rc1, preventing it from loading files from directories with too many entries, such as the grub module directory [Test plan] TBD [Where problems could occur] TBD [Impact] Multi-extent directories are not parsed correctly by grub's XFS code in 2.12~rc1, preventing it from loading files from directories with too many entries, such as the grub module directory. This should only affect BIOS systems as they need to load the core grub modules from the module directory, whereas UEFI systems have them embedded in the ESP EFI image. [Test plan] TBD [Where problems could occur] TBD
2023-10-12 11:58:00 Brian Murray grub2 (Ubuntu): status New Triaged
2023-10-12 11:58:06 Brian Murray grub2 (Ubuntu): importance Undecided High
2023-10-12 15:20:49 Bug Watch Updater grub2 (Debian): status Unknown Confirmed
2023-10-27 18:32:39 Steve Langasek bug task added ubuntu-release-upgrader (Ubuntu)
2023-10-27 18:33:58 Steve Langasek nominated for series Ubuntu Mantic
2023-10-27 18:33:58 Steve Langasek bug task added grub2 (Ubuntu Mantic)
2023-10-27 18:33:58 Steve Langasek bug task added ubuntu-release-upgrader (Ubuntu Mantic)
2023-10-27 18:33:58 Steve Langasek nominated for series Ubuntu Noble
2023-10-27 18:33:58 Steve Langasek bug task added grub2 (Ubuntu Noble)
2023-10-27 18:33:58 Steve Langasek bug task added ubuntu-release-upgrader (Ubuntu Noble)
2023-10-27 18:34:09 Steve Langasek tags foundations-todo
2023-10-27 18:42:19 Brian Murray ubuntu-release-upgrader (Ubuntu Noble): importance Undecided High
2023-10-27 18:42:22 Brian Murray ubuntu-release-upgrader (Ubuntu Noble): status New Triaged
2023-10-27 18:42:26 Brian Murray ubuntu-release-upgrader (Ubuntu Noble): milestone noble-updates
2023-10-27 18:42:32 Brian Murray ubuntu-release-upgrader (Ubuntu Mantic): status New Triaged
2023-10-27 18:42:35 Brian Murray ubuntu-release-upgrader (Ubuntu Mantic): importance Undecided High
2023-10-27 18:42:37 Brian Murray ubuntu-release-upgrader (Ubuntu Mantic): milestone mantic-updates
2023-11-02 16:02:53 Launchpad Janitor merge proposal linked https://code.launchpad.net/~enr0n/ubuntu-release-upgrader/+git/ubuntu-release-upgrader/+merge/455067
2023-11-04 20:45:53 Nick Rosbrook description [Impact] Multi-extent directories are not parsed correctly by grub's XFS code in 2.12~rc1, preventing it from loading files from directories with too many entries, such as the grub module directory. This should only affect BIOS systems as they need to load the core grub modules from the module directory, whereas UEFI systems have them embedded in the ESP EFI image. [Test plan] TBD [Where problems could occur] TBD [Impact] Multi-extent directories are not parsed correctly by grub's XFS code in 2.12~rc1, preventing it from loading files from directories with too many entries, such as the grub module directory. This should only affect BIOS systems as they need to load the core grub modules from the module directory, whereas UEFI systems have them embedded in the ESP EFI image. [Test plan] There are three scenarios we should test: (1) BIOS system with XFS /boot (2) UEFI arm64 with grub and XFS /boot (3) A "normal" system that should not hit this bug Test upgrades from Lunar to Mantic for the above scenarios. On systems that match (1) or (2), the upgrade should be prevented early on with a message linking to this bug report. For (3), the upgrade should proceed as normal. [Where problems could occur] The two risks here are (1) missing a case where we should block upgrade, and (2) preventing an upgrade in a case where we should not. The unit tests included in the patch attempt to mitigate this risk. Any issues would probably come from logic errors in the code that parses /proc/mounts, or in the arm64 case, the logic for checking if grub is installed.
2023-11-04 21:42:42 Ubuntu Archive Robot bug added subscriber Nick Rosbrook
2023-11-05 07:11:01 Nick Rosbrook description [Impact] Multi-extent directories are not parsed correctly by grub's XFS code in 2.12~rc1, preventing it from loading files from directories with too many entries, such as the grub module directory. This should only affect BIOS systems as they need to load the core grub modules from the module directory, whereas UEFI systems have them embedded in the ESP EFI image. [Test plan] There are three scenarios we should test: (1) BIOS system with XFS /boot (2) UEFI arm64 with grub and XFS /boot (3) A "normal" system that should not hit this bug Test upgrades from Lunar to Mantic for the above scenarios. On systems that match (1) or (2), the upgrade should be prevented early on with a message linking to this bug report. For (3), the upgrade should proceed as normal. [Where problems could occur] The two risks here are (1) missing a case where we should block upgrade, and (2) preventing an upgrade in a case where we should not. The unit tests included in the patch attempt to mitigate this risk. Any issues would probably come from logic errors in the code that parses /proc/mounts, or in the arm64 case, the logic for checking if grub is installed. [Impact] Multi-extent directories are not parsed correctly by grub's XFS code in 2.12~rc1, preventing it from loading files from directories with too many entries, such as the grub module directory. This should only affect BIOS systems as they need to load the core grub modules from the module directory, whereas UEFI systems have them embedded in the ESP EFI image. [Test plan] On systems BIOS systems with XFS /boot, or XFS / and no separate boot partition, the upgrade should be prevented early on with a message linking to this bug report. We should also test upgrades on "normal"/unaffected system to make sure it is not unnecessarily prevented. [Where problems could occur] The two risks here are (1) missing a case where we should block upgrade, and (2) preventing an upgrade in a case where we should not. The unit tests included in the patch attempt to mitigate this risk. Any issues would probably come from logic errors in the code that parses /proc/mounts.
2023-11-05 14:32:02 Steve Langasek ubuntu-release-upgrader (Ubuntu Mantic): status Triaged Fix Committed
2023-11-05 14:32:05 Steve Langasek bug added subscriber Ubuntu Stable Release Updates Team
2023-11-05 14:32:07 Steve Langasek bug added subscriber SRU Verification
2023-11-05 14:32:09 Steve Langasek tags foundations-todo foundations-todo verification-needed verification-needed-mantic
2023-11-09 13:07:07 Launchpad Janitor merge proposal linked https://code.launchpad.net/~mkukri/grub/+git/grub/+merge/455401
2023-11-09 15:55:28 Bug Watch Updater grub2 (Debian): status Confirmed Fix Released
2023-11-14 15:15:13 Launchpad Janitor grub2 (Ubuntu Noble): status Triaged Fix Released
2023-11-14 15:15:13 Launchpad Janitor cve linked 2023-4692
2023-11-14 15:15:13 Launchpad Janitor cve linked 2023-4693
2023-11-14 17:04:17 Launchpad Janitor ubuntu-release-upgrader (Ubuntu Noble): status Triaged Fix Released
2023-11-15 17:05:30 Nick Rosbrook tags foundations-todo verification-needed verification-needed-mantic foundations-todo verification-done verification-done-mantic
2023-11-24 04:49:53 Rene Verdugo bug added subscriber Rene Verdugo
2023-11-26 23:39:46 Steve Langasek grub2 (Ubuntu Mantic): status New Incomplete
2023-11-27 12:34:17 Julian Andres Klode description [Impact] Multi-extent directories are not parsed correctly by grub's XFS code in 2.12~rc1, preventing it from loading files from directories with too many entries, such as the grub module directory. This should only affect BIOS systems as they need to load the core grub modules from the module directory, whereas UEFI systems have them embedded in the ESP EFI image. [Test plan] On systems BIOS systems with XFS /boot, or XFS / and no separate boot partition, the upgrade should be prevented early on with a message linking to this bug report. We should also test upgrades on "normal"/unaffected system to make sure it is not unnecessarily prevented. [Where problems could occur] The two risks here are (1) missing a case where we should block upgrade, and (2) preventing an upgrade in a case where we should not. The unit tests included in the patch attempt to mitigate this risk. Any issues would probably come from logic errors in the code that parses /proc/mounts. [Impact] Multi-extent directories are not parsed correctly by grub's XFS code in 2.12~rc1, preventing it from loading files from directories with too many entries, such as the grub module directory. This should only affect BIOS systems as they need to load the core grub modules from the module directory, whereas UEFI systems have them embedded in the ESP EFI image. [Test plan] [[ubuntu-release-upgrader]] On systems BIOS systems with XFS /boot, or XFS / and no separate boot partition, the upgrade should be prevented early on with a message linking to this bug report. We should also test upgrades on "normal"/unaffected system to make sure it is not unnecessarily prevented. [[grub2, grub2-unsigned]] TBD [Where problems could occur] The two risks here are (1) missing a case where we should block upgrade, and (2) preventing an upgrade in a case where we should not. The unit tests included in the patch attempt to mitigate this risk. Any issues would probably come from logic errors in the code that parses /proc/mounts.
2023-11-27 12:35:05 Julian Andres Klode description [Impact] Multi-extent directories are not parsed correctly by grub's XFS code in 2.12~rc1, preventing it from loading files from directories with too many entries, such as the grub module directory. This should only affect BIOS systems as they need to load the core grub modules from the module directory, whereas UEFI systems have them embedded in the ESP EFI image. [Test plan] [[ubuntu-release-upgrader]] On systems BIOS systems with XFS /boot, or XFS / and no separate boot partition, the upgrade should be prevented early on with a message linking to this bug report. We should also test upgrades on "normal"/unaffected system to make sure it is not unnecessarily prevented. [[grub2, grub2-unsigned]] TBD [Where problems could occur] The two risks here are (1) missing a case where we should block upgrade, and (2) preventing an upgrade in a case where we should not. The unit tests included in the patch attempt to mitigate this risk. Any issues would probably come from logic errors in the code that parses /proc/mounts. [Impact] Multi-extent directories are not parsed correctly by grub's XFS code in 2.12~rc1, preventing it from loading files from directories with too many entries, such as the grub module directory. This should only affect BIOS systems as they need to load the core grub modules from the module directory, whereas UEFI systems have them embedded in the ESP EFI image. [Test plan: ubuntu-release-upgrader] On systems BIOS systems with XFS /boot, or XFS / and no separate boot partition, the upgrade should be prevented early on with a message linking to this bug report. We should also test upgrades on "normal"/unaffected system to make sure it is not unnecessarily prevented. [Where problems could occur: ubuntu-release-upgrader] The two risks here are (1) missing a case where we should block upgrade, and (2) preventing an upgrade in a case where we should not. The unit tests included in the patch attempt to mitigate this risk. Any issues would probably come from logic errors in the code that parses /proc/mounts. [Test plan: grub2, grub2-unsigned] [Where problems could occur: grub2, grub2-unsigned]
2023-11-27 12:38:32 Julian Andres Klode description [Impact] Multi-extent directories are not parsed correctly by grub's XFS code in 2.12~rc1, preventing it from loading files from directories with too many entries, such as the grub module directory. This should only affect BIOS systems as they need to load the core grub modules from the module directory, whereas UEFI systems have them embedded in the ESP EFI image. [Test plan: ubuntu-release-upgrader] On systems BIOS systems with XFS /boot, or XFS / and no separate boot partition, the upgrade should be prevented early on with a message linking to this bug report. We should also test upgrades on "normal"/unaffected system to make sure it is not unnecessarily prevented. [Where problems could occur: ubuntu-release-upgrader] The two risks here are (1) missing a case where we should block upgrade, and (2) preventing an upgrade in a case where we should not. The unit tests included in the patch attempt to mitigate this risk. Any issues would probably come from logic errors in the code that parses /proc/mounts. [Test plan: grub2, grub2-unsigned] [Where problems could occur: grub2, grub2-unsigned] [Impact] Multi-extent directories are not parsed correctly by grub's XFS code in 2.12~rc1, preventing it from loading files from directories with too many entries, such as the grub module directory. This should only affect BIOS systems as they need to load the core grub modules from the module directory, whereas UEFI systems have them embedded in the ESP EFI image. [Test plan: ubuntu-release-upgrader] On systems BIOS systems with XFS /boot, or XFS / and no separate boot partition, the upgrade should be prevented early on with a message linking to this bug report. We should also test upgrades on "normal"/unaffected system to make sure it is not unnecessarily prevented. [Where problems could occur: ubuntu-release-upgrader] The two risks here are (1) missing a case where we should block upgrade, and (2) preventing an upgrade in a case where we should not. The unit tests included in the patch attempt to mitigate this risk. Any issues would probably come from logic errors in the code that parses /proc/mounts. [Test plan: grub2, grub2-unsigned] We'll do both grub2 on BIOS and UEFI. - Install system with separate /boot on ext4. - Upgrade to new grub. Run grub-install to actually apply bios-upgrade - Reboot (this ensures ext4 still works) - Take a backup of /boot - Format /boot as xfs and restore backup - Reboot (this ensures xfs works) [Where problems could occur: grub2, grub2-unsigned]
2023-11-27 12:39:21 Julian Andres Klode description [Impact] Multi-extent directories are not parsed correctly by grub's XFS code in 2.12~rc1, preventing it from loading files from directories with too many entries, such as the grub module directory. This should only affect BIOS systems as they need to load the core grub modules from the module directory, whereas UEFI systems have them embedded in the ESP EFI image. [Test plan: ubuntu-release-upgrader] On systems BIOS systems with XFS /boot, or XFS / and no separate boot partition, the upgrade should be prevented early on with a message linking to this bug report. We should also test upgrades on "normal"/unaffected system to make sure it is not unnecessarily prevented. [Where problems could occur: ubuntu-release-upgrader] The two risks here are (1) missing a case where we should block upgrade, and (2) preventing an upgrade in a case where we should not. The unit tests included in the patch attempt to mitigate this risk. Any issues would probably come from logic errors in the code that parses /proc/mounts. [Test plan: grub2, grub2-unsigned] We'll do both grub2 on BIOS and UEFI. - Install system with separate /boot on ext4. - Upgrade to new grub. Run grub-install to actually apply bios-upgrade - Reboot (this ensures ext4 still works) - Take a backup of /boot - Format /boot as xfs and restore backup - Reboot (this ensures xfs works) [Where problems could occur: grub2, grub2-unsigned] [Impact] Multi-extent directories are not parsed correctly by grub's XFS code in 2.12~rc1, preventing it from loading files from directories with too many entries, such as the grub module directory. This should only affect BIOS systems as they need to load the core grub modules from the module directory, whereas UEFI systems have them embedded in the ESP EFI image. [Test plan: ubuntu-release-upgrader] On systems BIOS systems with XFS /boot, or XFS / and no separate boot partition, the upgrade should be prevented early on with a message linking to this bug report. We should also test upgrades on "normal"/unaffected system to make sure it is not unnecessarily prevented. [Where problems could occur: ubuntu-release-upgrader] The two risks here are (1) missing a case where we should block upgrade, and (2) preventing an upgrade in a case where we should not. The unit tests included in the patch attempt to mitigate this risk. Any issues would probably come from logic errors in the code that parses /proc/mounts. [Test plan: grub2, grub2-unsigned] We'll do both grub2 on BIOS and UEFI. - Install system with separate /boot on ext4. - Upgrade to new grub. Run grub-install to actually apply bios-upgrade - Reboot (this ensures ext4 still works) - Take a backup of /boot - Format /boot as xfs and restore backup - Reboot (this ensures xfs works) [Where problems could occur: grub2, grub2-unsigned] We could be introducing other XFS parsing bugs including security vulnerabilities.
2023-11-28 04:33:56 Steve Langasek bug task added grub2-unsigned (Ubuntu)
2023-11-28 04:35:27 Steve Langasek grub2-unsigned (Ubuntu Noble): status New Fix Released
2023-11-28 04:35:44 Steve Langasek grub2-unsigned (Ubuntu Mantic): status New Fix Committed
2023-11-28 04:35:50 Steve Langasek tags foundations-todo verification-done verification-done-mantic foundations-todo verification-needed verification-needed-mantic
2023-11-28 04:39:40 Launchpad Janitor ubuntu-release-upgrader (Ubuntu Mantic): status Fix Committed Fix Released
2023-11-28 04:41:57 Steve Langasek grub2 (Ubuntu Mantic): status Incomplete Fix Committed
2023-12-01 11:25:30 Mate Kukri tags foundations-todo verification-needed verification-needed-mantic foundations-todo verification-done verification-done-mantic
2024-04-15 02:19:20 str bug added subscriber str
2024-05-29 18:48:46 Václav Haisman bug added subscriber Václav Haisman
2024-06-12 10:11:56 Mantas Kriaučiūnas bug added subscriber Mantas Kriaučiūnas
2024-06-12 10:12:02 Mantas Kriaučiūnas bug added subscriber Baltix GNU/Linux system developers