[SRU] minifycss fails to run

[Sudip Mukherjee]

[ Impact ]

minifycss and minifyjs is completely unusable and will fail immediately on execution with the error:

$ minifycss
PHP Warning: require_once(/usr/bin/../src/Minify.php): Failed to open stream: No such file or directory in /usr/bin/minifycss on line 10
PHP Fatal error: Uncaught Error: Failed opening required '/usr/bin/../src/Minify.php' (include_path='.:/usr/share/php') in /usr/bin/minifycss:10
Stack trace:
#0 {main}
  thrown in /usr/bin/minifycss on line 10

$ minifyjs
PHP Warning: require_once(/usr/bin/../src/Minify.php): Failed to open stream: No such file or directory in /usr/bin/minifyjs on line 10
PHP Fatal error: Uncaught Error: Failed opening required '/usr/bin/../src/Minify.php' (include_path='.:/usr/share/php') in /usr/bin/minifyjs:10
Stack trace:
#0 {main}
  thrown in /usr/bin/minifyjs on line 10

[ Test Plan ]

1. install php-matthiasmullie-minify
2. copy the sample test files from tests folder of the source

test minifycss:
minifycss tests/css/sample/bom/bom.css

test minifyjs:
minifyjs tests/js/sample/bugs/227/original.js

If the package is not fixed it will result in the above error.
With the fixed package it will display the minified versions.

[ Where problems could occur ]

The fix is including autoload.php which has been autogenerated as part of the build and is adding all the required paths. It is not changing any part of the code and there should not be any regression due to this change.

[ Other Info ]

Oracular, Noble and Mantic were affected. Oracular now has synced and the Debian fix is in it now.

[ Original Bug Description ]

minifycss fails to run with the error:

$ minifycss
PHP Warning: require_once(/usr/bin/../src/Minify.php): Failed to open stream: No such file or directory in /usr/bin/minifycss on line 10
PHP Fatal error: Uncaught Error: Failed opening required '/usr/bin/../src/Minify.php' (include_path='.:/usr/share/php') in /usr/bin/minifycss:10
Stack trace:
#0 {main}
  thrown in /usr/bin/minifycss on line 10

[Sudip Mukherjee (sudipmuk)]

debdiff for Noble attached. Mantic is also affected, will add debdiff for Mantic after Noble is fixed,

[Andreas Hasenack (ahasenack)]

diff -Nru matthiasmullie-minify-1.3.68/debian/patches/fix-path.patch matthiasmullie-minify-1.3.68/debian/patches/fix-path.patch
--- matthiasmullie-minify-1.3.68/debian/patches/fix-path.patch 1970-01-01 01:00:00.000000000 +0100
+++ matthiasmullie-minify-1.3.68/debian/patches/fix-path.patch 2024-04-10 18:48:17.000000000 +0100
@@ -0,0 +1,37 @@
+Description: Fix paths of the files minify required
+Author: Sudip Mukherjee <email address hidden>
+Bug-Ubuntu: https://launchpad.net/bugs/2060848
+Forwarded: not-needed
+Last-Update: 2024-04-10

You could also add the debian bug to this header:
Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1068767

I wouldn't block the upload on this, though. But I have another question.

Are there more fixes needed? I just quickly tried to run it with a random css file that is in the same package, and it failed:

$ minifycss ./tests/css/sample/convert_relative_path/source/absolute.css
PHP Fatal error: Uncaught Error: Class "MatthiasMullie\PathConverter\Converter" not found in /usr/share/php/MatthiasMullie/Minify/CSS.php:788
Stack trace:
#0 /usr/share/php/MatthiasMullie/Minify/CSS.php(339): MatthiasMullie\Minify\CSS->getPathConverter()
#1 /usr/share/php/MatthiasMullie/Minify/Minify.php(149): MatthiasMullie\Minify\CSS->execute()
#2 /usr/bin/minifycss(41): MatthiasMullie\Minify\Minify->minify()
#3 {main}
  thrown in /usr/share/php/MatthiasMullie/Minify/CSS.php on line 788

The DEP8 tests also seems to be failing, at least locally:
$ AUTOPKGTEST_TMP=$(mktemp -d) sh debian/tests/upstream
phpab %development% - Copyright (C) 2009 - 2024 by Arne Blankerts and Contributors

Scanning directory ./tests

Autoload file ./vendor/autoload.php generated.

Proceeding without a composer.json file.PHPUnit 9.6.17 by Sebastian Bergmann and contributors.

Warning: Incorrect filter configuration, code coverage will not be processed

............................................................... 63 / 343 ( 18%)
............................................................... 126 / 343 ( 36%)
..............................F....E........................... 189 / 343 ( 55%)
............................................................... 252 / 343 ( 73%)
............................................................... 315 / 343 ( 91%)
............................ 343 / 343 (100%)

Time: 00:00.091, Memory: 12.00 MB

There was 1 error:

1) MatthiasMullie\Minify\Test\AbstractTest::testCache
Error: Class "MatthiasMullie\Scrapbook\Adapters\MemoryStore" not found

/tmp/tmp.w3M8gzyBuN/tests/js/AbstractTest.php:218

--

There was ...

[Sudip Mukherjee (sudipmuk)]

debdiff updated. the new error you noticed was caused as upstream has split "PathConverter" in a separate repo and is now a separate package.

[Paride Legovini (paride)]

Next steps:

- wait for Oracular to Open
- sync the fixed version from Debian
- evaluate a SRU of the Debian fix, which AIUI is [1].
  Note: that's different from the proposed debdiff.

[1] https://salsa.debian.org/php-team/pear/matthiasmullie-minify/-/commit/0fabfdfb710ccb12cc31eddbc7c541464fcb8a05

[Sudip Mukherjee (sudipmuk)]

The Debian fix has synced with Oracular now.

Adding modified debdiff for Noble. And, just to reply about Paride's comment about difference between the Debian fix and the previous proposed SRU patch, the previopus proposed SRU debdiff for Noble was made before Noble was released and Debian fix was not done at that time.

The Noble and Mantic packages with the SRU fix are built in a PPA and are available at https://launchpad.net/~sudipmuk/+archive/ubuntu/test-ppa/+packages

[Sudip Mukherjee (sudipmuk)]

Debdiff for Mantic attached.

[Paride Legovini (paride)]

This LGTM, I just have a nit. For noble you prepared this d/changelog entry:

matthiasmullie-minify (1.3.68-4ubuntu0.24.04.1) noble; urgency=medium

while for Mantic:

matthiasmullie-minify (1.3.68-4ubuntu0.1) mantic; urgency=medium

Can you please make them consistent (always ubuntu0.XX.YY.n)?

Thanks!

[Sudip Mukherjee (sudipmuk)]

Updated debdiff for Mantic (though I do not see why that was required technically, apart from being consistent in versions).

[Benjamin Drung (bdrung)]

Unsubscribing ~ubuntu-sponsors since Sudip is a MOTU now.

[Timo Aaltonen (tjaalton)]

Hello Sudip, or anyone else affected,

Accepted matthiasmullie-minify into noble-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/matthiasmullie-minify/1.3.68-4ubuntu0.24.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-noble to verification-done-noble. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-noble. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Timo Aaltonen (tjaalton)]

An upload of matthiasmullie-minify to mantic-proposed has been rejected from the upload queue for the following reason: "mantic is EOL in less than a week".