GNOME Shell qrcode generator may create invalid QR code images

[Marco Trevisan (Treviño)]

[ Impact ]

When creating QR Code images for long(er) URIs we may end up creating qr codes whose size isn't matching the expected one and this may lead to a wrongly generated texture (and potential memory access errors).

An example: https://i.imgur.com/x3P4dzQ.png

[ Test case ]

In order to test this from GNOME shell, many components have to be set up that are harder to check so this can be easily simulated using a simple test program that replicates what the shell does to generate the image: https://www.pastery.net/uyzeca/

0. Install mutter compositor (prerequisite, remove it afterwards):
   $ sudo apt install mutter
1. Download and run the test script:
   $ wget -O /tmp/shell-qrcode-tester.py https://www.pastery.net/uyzeca/raw
2. Run it with:
   $ python3 /tmp/shell-qrcode-tester.py
3. The qrcode should open in a new window and display correctly as
   https://imgur.com/dddTL6u.png (pointing to https://bugs.launchpad.net/ubuntu/+source/gnome-shell)

[ Regression potential ]

QrCodes are used only during web authentication that is not something that is generally exposed to users, but this may potentially lead to wrong or missing qr codes textures.

[Launchpad Janitor (janitor)]

This bug was fixed in the package gnome-shell - 46.2-1ubuntu1

---------------
gnome-shell (46.2-1ubuntu1) oracular; urgency=medium

  [ Jeremy Bícha ]
  * Merge with Debian
  * Refresh patches

  [ Marco Trevisan (Treviño) ]
  * debian/patches/ubuntu-authd: Properly draw qr-codes for longer URIs
    (LP: #2067610)
  * debian/patches/ubuntu-authd: Fix dialog text color when using light theme
    (LP: #2067661)
  * debian/patches/ubuntu-authd: Use right colors to draw the QR code in
    light mode (LP: #2067661)

gnome-shell (46.2-1) experimental; urgency=medium

  * New upstream release
  * Drop screencast patch applied in new release
  * Drop revert tecla patch: no longer needed
  * Add Depends: tecla. Drop Recommends: gkbd-capplet

 -- Jeremy Bícha <email address hidden> Fri, 31 May 2024 07:14:43 -0400

[Łukasz Zemczak (sil2100)]

Hello Marco, or anyone else affected,

Accepted gnome-shell into noble-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/gnome-shell/46.0-0ubuntu6~24.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-noble to verification-done-noble. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-noble. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Marco Trevisan (Treviño) (3v1n0)]

Qrcode is prperly generated for various URIs

gnome-shell:
  Installato: 46.3.1-1ubuntu1~24.04.1
  Candidato: 46.3.1-1ubuntu1~24.04.1
  Tabella versione:
 *** 46.0-0ubuntu6~24.04.1 400
        400 http://archive.ubuntu.com/ubuntu noble-proposed/main amd64 Packages
     46.0-0ubuntu5.1 500
        500 http://archive.ubuntu.com/ubuntu noble-updates/main amd64 Packages
        500 http://security.ubuntu.com/ubuntu noble-security/main amd64 Packages
     46.0-0ubuntu5 500
        500 http://archive.ubuntu.com/ubuntu noble/main amd64 Packages

[Launchpad Janitor (janitor)]

This bug was fixed in the package gnome-shell - 46.0-0ubuntu6~24.04.1

---------------
gnome-shell (46.0-0ubuntu6~24.04.1) noble; urgency=medium

  * debian: Prepare for noble branching
  * d/p/ubuntu-authd: Revert unwanted change causing ibus not to launch
    (LP: #2069381)
  * d/p: Do not allocate memory or call async-signal-unsafe code on spawn
  * d/p/ubuntu-authd: Properly draw qr-codes for longer URIs (LP: #2067610)
  * d/p/ubuntu-authd: Fix dialog text color when using light theme
    (LP: #2067661)
  * d/p/ubuntu-authd: Use right colors to draw the qr code in light mode
    (LP: #2067661)
  * d/p/ubuntu-authd: Properly handle new-password messages requests
    (LP: #2068080)
  * d/p/ubuntu-authd: Add translatable js files to POTFILES.in (LP: #2068912)
  * d/p: Resize tray icon windows to respect their actor representation
    (LP: #2012388)
  * d/p: Do not make tray icons to take any input event directly.
    This is all handled through their actor proxy representation (LP: #2012388)

 -- Marco Trevisan (Treviño) <email address hidden> Fri, 14 Jun 2024 08:04:48 +0200

[Andreas Hasenack (ahasenack)]

The verification of the Stable Release Update for gnome-shell has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[Robie Basak (racb)]

An upload of gnome-shell to noble-proposed has been rejected from the upload queue for the following reason: "GNOME MRE not valid for gnome-shell as discussed in bug".