Fixes and improvements for 'new user creation'

[Sebastien Bacher]

* Impact

We aren't using gnome-initial-setup to create users in Ubuntu today, since our desktop installer is handling the user creation, but that's wanted feature for oem installation to replace oem-setup which doesn't exist in the new installer

There is a specification document with details on the change on https://docs.google.com/document/d/1BORpilOnHZRLQFK5gx2PLe6vzytLtSIARD0m_LtsWPQ/edit

The work has been validated by the Canonical OEM team which tested ppa candidate builds of the changes before we uploaded

* Test Case

We added a new section for 'new user mode' to the existing testplan to cover that feature

https://wiki.ubuntu.com/DesktopTeam/TestPlans/GnomeInitialSetup

* Regression potential

As described, neither Ubuntu nor any of the flavors are using gnome-initial-setup in 'user creation' mode today, so the regression potential is limited. Theoretically there could be users with custom setup triggering that mode today but we also found integration issue with the way the gnome-initial-user account is set up on Debian/Ubuntu which makes the mode not work today, which we are also fixing as part of that upload.

Things that could go wrong though:
- the user creation GUI could be triggered when it shouldn't (on an normal desktop installation where the user is create by the installer)
- the 'first login' mode could change by side effect of some of the other changes

We should focus on verifying those, especially that the 'existing user' mode is unchanged.

The patches also add some new translatable strings, the launchpad template was updated manually already and translator notified
https://lists.ubuntu.com/archives/ubuntu-translators/2024-June/007922.html
Which should allow us to get translations before the langpack refresh of .1

[Sebastien Bacher (seb128)]

The changes are already in Oracular

[Timo Aaltonen (tjaalton)]

Hello Sebastien, or anyone else affected,

Accepted gnome-initial-setup into noble-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/gnome-initial-setup/46.2-1ubuntu0.24.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-noble to verification-done-noble. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-noble. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Yao Wei (medicalwei)]

New user feature is verified according to https://wiki.ubuntu.com/DesktopTeam/TestPlans/GnomeInitialSetup

[Andreas Hasenack (ahasenack)]

> New user feature is verified according to https://wiki.ubuntu.com/DesktopTeam/TestPlans/GnomeInitialSetup

Thanks for your verification, but it's not clear which packages you used for yout test. Given that "ppas" were mentioned in the bug description as having been used before for testing, prior to upload, I feel that this information is important.

It's also requested in the "accepted" bug comment #2:

"If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, (...)"

[Yao Wei (medicalwei)]

> Given that "ppas" were mentioned in the bug description as having been used before for testing, prior to upload, I feel that this information is important.

The test was independent than the "ppa" one mentioned in the description. This is done using stock Ubuntu image, then installed gnome-initial-setup 46.2-1ubuntu0.24.04.1 from noble-proposed.

Should I redo the tests again?

[Andreas Hasenack (ahasenack)]

> This is done using stock Ubuntu image, then installed gnome-initial-setup 46.2-1ubuntu0.24.04.1 from
> noble-proposed.

Excellent, this is what was missing.

> Should I redo the tests again?

No need, thanks for the update.

[Launchpad Janitor (janitor)]

This bug was fixed in the package gnome-initial-setup - 46.2-1ubuntu0.24.04.1

---------------
gnome-initial-setup (46.2-1ubuntu0.24.04.1) noble; urgency=medium

  * New upstream version (lp: #2071447)
  * d/p/0001-Add-Ubuntu-mode-with-special-pages.patch:
    - improve the keyboard navigation on the pro page (lp: #2069375)

  * Fixes and improvements to the 'create initial user' mode. We aren't
    using gnome-initial-setup to create users in Ubuntu today, since our
    desktop installer is handling the user creation, but that's wanted
    feature for oem installation to replace oem-setup which doesn't exist
    in the new installer (lp: #2071449).
    - debian/vendor.conf: do not hide language page
    - d/p/0001-Add-Ubuntu-mode-with-special-pages.patch:
      - fix segfault when selecting language
      - code comment on is_desktop for when setting up the first user
    - d/p/Update-style-to-the-same-than-flutter-installer.patch:
      - update user creation icons to ones matching more the ubuntu style.
      - update some icon sizes as those icons are more detailed.
    - d/p/Do-not-skip-g-i-s-first-login-mode-after-user-creation.patch:
      - g-i-s first login experience has different screens from user creation.
        Do not skip it.
    - d/p/Adding-EULA-page-for-OEMs.patch:
      - Add optional EULA page for showing OEMs documents during user creation.
    - d/p/Allow-setting-hostname-to-local-account-page.patch:
      - Allow an user to edit their hostname on the local account creation page.
    - d/p/Skip-privacy-page-in-user-creation-setup.patch :
      - The button doesn’t open any browsers and this setting was not in
        oem-config.
    - debian/control:
      - Add libpoppler-glib-dev build-dep.

 -- Sebastien Bacher <email address hidden> Fri, 28 Jun 2024 16:29:30 +0200

[Andreas Hasenack (ahasenack)]

The verification of the Stable Release Update for gnome-initial-setup has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.