[SRU] enable cs42l43 and cs35l56 audio on Intel LNL

Bug #2106394 reported by AaronMa
14
This bug affects 1 person
Affects Status Importance Assigned to Milestone
HWE Next
New
Undecided
Unassigned
alsa-ucm-conf (Ubuntu)
Fix Released
Undecided
Atlas Yu
Noble
Fix Released
Undecided
Unassigned
Oracular
Fix Released
Undecided
Unassigned
Plucky
Fix Released
Undecided
Unassigned
firmware-sof (Ubuntu)
Fix Released
Undecided
Chris Chiu
Noble
Fix Released
Undecided
Unassigned
Oracular
Fix Released
Undecided
Unassigned
Plucky
Fix Released
Undecided
Unassigned
linux (Ubuntu)
New
Undecided
Unassigned
Noble
Won't Fix
Undecided
Unassigned
Oracular
Fix Released
Medium
AaronMa
Plucky
Fix Released
Undecided
Unassigned
linux-firmware (Ubuntu)
Fix Released
Medium
AaronMa
Noble
Fix Released
Undecided
Unassigned
Oracular
Fix Released
Undecided
Unassigned
Plucky
Fix Released
Undecided
Unassigned

Bug Description

[Impact]
No audio input/output for cs42l43 and cs35l56 on Intel LNL of ThinkPad.

[Fix]
Add the firmware of cs35l56 and sof-lnl-cs42l43-l0-2ch.tplg
to enable audio support;
update alsa-ucm-conf to gain the control of mic/speaker mute LED.

linux-fimware commit:
9c46d10f8 cirrus: cs35l56: Add and update firmware for various Cirrus CS35L54 and CS35L56 laptops

sof-bin commit:
e8604e4 Add 2.12 topology binaries for Intel targets

sof-bin file:
v2.12.x/sof-ipc4-tplg-v2.12/sof-lnl-cs42l43-l0-2ch.tplg

alsa-ucm-conf commits:
9e946d4 sof-soundwire: Add LED support for cs35l56 amplifiers
79c9e8f sof-soundwire: cs42l43: Drop headset mic from mic mute LED
UPDATE: many more are actually needed, check https://bugs.launchpad.net/ubuntu/+source/alsa-ucm-conf/+bug/2106394/comments/32 and later comments

[Test]
Tested on Intel LNL:
1, hear the sound from
$ speaker-test -c 2
2, make sound and recorded, replay the file:
$ arecord -f cd test.wav
$ aplay test.wav
3, press speaker-mute and mic-mute key, the OSD are shown,
and the LED is on when it's muted.
4, plugin headset and restest the steps above for sound input and output.
sound ctl led is not controlled by headset, it's by design:
please refer to:
https://github.com/alsa-project/alsa-ucm-conf/blob/master/ucm2/common/ctl/led.conf

[Where problems could occur]
It may break cirrus audio support.

Noble/Oracular/Plucky support this platform, Plucky already got the firmware.

Related branches

CVE References

AaronMa (mapengyu)
tags: added: jira-sutton-471 oem-priority
tags: added: jira-sutton-473
Changed in linux-firmware (Ubuntu):
assignee: nobody → AaronMa (mapengyu)
importance: Undecided → Medium
Changed in linux-firmware (Ubuntu Noble):
status: New → In Progress
Changed in linux-firmware (Ubuntu):
status: New → In Progress
AaronMa (mapengyu)
description: updated
AaronMa (mapengyu)
Changed in firmware-sof (Ubuntu):
assignee: nobody → Chris Chiu (mschiu77)
Changed in alsa-ucm-conf (Ubuntu):
assignee: nobody → Atlas Yu (pseudoc)
AaronMa (mapengyu)
description: updated
Revision history for this message
Atlas Yu (pseudoc) wrote :

alsa-ucm-conf/noble 1.2.10-1ubuntu5.5

Changed in alsa-ucm-conf (Ubuntu):
status: New → Fix Committed
status: Fix Committed → In Progress
Revision history for this message
Atlas Yu (pseudoc) wrote :

alsa-ucm-conf/plucky 1.2.12-1ubuntu2

Revision history for this message
Chris Chiu (mschiu77) wrote :
Revision history for this message
Sebastien Bacher (seb128) wrote :

Thanks Atlas.

I see the oem team has 3 conflicting SRU proposal of alsa-ucm-conf

https://bugs.launchpad.net/ubuntu/+source/alsa-ucm-conf/+bug/2106464
https://bugs.launchpad.net/ubuntu/+source/alsa-ucm-conf/+bug/2106394
https://bugs.launchpad.net/ubuntu/+source/alsa-ucm-conf/+bug/2100732

Could you work together to consolidate on one upload/debdiff addressing the 3 reports?

Also a note for next time, if you need something sponsored to Ubuntu (which I assume is the case there), you need to subscribe the "ubuntu-sponsors" team to the report

Revision history for this message
Bin Li (binli) wrote :

I've merged one upload/debdiff for the 3 reports.

https://bugs.launchpad.net/ubuntu/+source/alsa-ucm-conf/+bug/2100732

Revision history for this message
Sebastien Bacher (seb128) wrote :

Thanks

Changed in alsa-ucm-conf (Ubuntu):
status: In Progress → Fix Committed
AaronMa (mapengyu)
Changed in linux-firmware (Ubuntu Oracular):
status: New → In Progress
description: updated
AaronMa (mapengyu)
Changed in linux (Ubuntu Noble):
status: New → Won't Fix
Changed in linux (Ubuntu Oracular):
status: New → In Progress
Juerg Haefliger (juergh)
Changed in linux-firmware (Ubuntu Oracular):
status: In Progress → Fix Committed
Changed in linux-firmware (Ubuntu Noble):
status: In Progress → Fix Committed
Revision history for this message
Christian Ehrhardt (paelzer) wrote :

I discussed this with Seb, it is not release critical in a way to stall/stop the release so we won't accept it from unapproved into plucky before release.
But we will leave it in -unapproved for post-release processing by the SRU team.

Changed in alsa-ucm-conf (Ubuntu Noble):
assignee: nobody → Atlas Yu (pseudoc)
status: New → Fix Committed
Changed in alsa-ucm-conf (Ubuntu Oracular):
assignee: nobody → Atlas Yu (pseudoc)
status: New → Fix Committed
Chris Chiu (mschiu77)
Changed in firmware-sof (Ubuntu Noble):
status: New → In Progress
Changed in firmware-sof (Ubuntu Oracular):
status: New → In Progress
Revision history for this message
Chris Chiu (mschiu77) wrote :
Edoardo Canepa (ecanepa)
Changed in linux (Ubuntu Oracular):
assignee: nobody → AaronMa (mapengyu)
Stefan Bader (smb)
Changed in linux (Ubuntu Oracular):
importance: Undecided → Medium
status: In Progress → Fix Committed
Revision history for this message
Timo Aaltonen (tjaalton) wrote :

the test case doesn't actually say how to test..

Revision history for this message
Andreas Hasenack (ahasenack) wrote :

> Noble/Oracular/Plucky support this platform, Plucky already got the firmware.

After doing a check in plucky for a random topology file (I used sof-adl-cs42l43-l0-cs35l56-l23.tplg) and verifying it's there, and given the comment above, marking firmware-sof main and plucky tasks as "fix released".

Changed in firmware-sof (Ubuntu Plucky):
status: New → Fix Released
Changed in firmware-sof (Ubuntu):
status: New → Fix Released
Revision history for this message
Andreas Hasenack (ahasenack) wrote (last edit ):

As requested in comment #9, please provide a better elaborated test plan. See [1] for a reference/explanation.

Also, this SRU has many package tasks, are all of them required to fix the bug? Which packages need to be released into updates together?

1. https://documentation.ubuntu.com/sru/en/latest/reference/requirements/#test-plan

Revision history for this message
Andreas Hasenack (ahasenack) wrote :

> sof-bin commit:
> e8604e4 Add 2.12 topology binaries for Intel targets

> sof-bin file:
> v2.12.x/sof-ipc4-tplg-v2.12/sof-lnl-cs42l43-l0-2ch.tplg

Your patch is adding tons of tplg files, not just that one.

$ head -n 109 debian/patches/0008-Add-2.12-topology-binaries-for-Intel-targets.patch | grep \\.tplg | wc -l
94

Why do we need the dozens of other tplg files in this SRU? What bug are they fixing?

Changed in firmware-sof (Ubuntu Oracular):
status: In Progress → Incomplete
Changed in firmware-sof (Ubuntu Noble):
status: In Progress → Incomplete
Revision history for this message
AaronMa (mapengyu) wrote :

Added the test plan.

description: updated
Revision history for this message
Chris Chiu (mschiu77) wrote :

The upstream commit of a newer version usually include the topology files for the new platforms or missing configuration on old platforms. It would be better to catch up with upstream to have these configuration which can support more configurations we could be missing in the future. This firmware-sof patch includes the New DSP topologies added in v.2.12 which is formally released in https://github.com/thesofproject/sof-bin/releases and signed by Intel.

Although there're lots of new tplg files added, but they are mostly for missing configuration on old platforms or newly added for next-gen Intel platform. And they are specified for particular soundwire configurations which can hardly affect the existing machines. It should help reduce our efforts to support different audio configurations coming from more vendors and machines.

Revision history for this message
Andreas Hasenack (ahasenack) wrote :

firmware-sof doesn't have an SRU exception[1] that allows it to add such bulk changes without a specific process.

This bug here claims to be enabling just "cs42l43 and cs35l56 audio on Intel LNL", but the commit is far more reaching than that claim.

If I look at the previous update[2], only one topology file was added[3]: sof-tplg-v2.2.13/sof-rpl-cs42l43-l0.tplg

> It would be better to catch up with upstream to have these configuration which can support more
> configurations we could be missing in the future.

This rationale is not always true. Such a type of update can also bring with it other bugs, which would mean a regression for ubuntu stable release users. See [4] for some examples and arguments in favor of minimal changes.

Why do you claim that bringing in all those other 90+ topology files is better and less risky than updating just the one we need to fix this bug? I'm definitely not the expert in this package, but I see a huge amount of changes, to other pieces of hardware, and I have to wonder:
- how can we be sure we are not regressing all those other sound cards?
- we are testing just "intel NL", what about all the other changes?
- Why can you claim that this update will not affect other hardware? You state, in the bug description: "It may break cirrus audio support.". But I see many topology files that don't seem to be limited to "cirrus audio".

What is the risk in updating/adding just the files we need for "cs42l43 and cs35l56 audio on Intel LNL"?

1. https://wiki.ubuntu.com/StableReleaseUpdates#Documentation_for_Special_Cases
2. https://launchpad.net/ubuntu/+source/firmware-sof/2023.12.1-1ubuntu1.4
3. https://git.launchpad.net/ubuntu/+source/firmware-sof/commit/?h=ubuntu/noble-devel
4. https://documentation.ubuntu.com/sru/en/latest/explanation/requirements/#explanation-minimal

Revision history for this message
AaronMa (mapengyu) wrote (last edit ):

Reply #11:

SOF tplg and alsa-ucm-conf should be the updated together to make audio work.

The supported kernel is target to oem-6.11-1020.
6.13+ kernel include plucky should support.
oracular SRU had been sent to kernel maillist.

Changed in linux (Ubuntu Plucky):
status: New → Fix Released
Revision history for this message
Chris Chiu (mschiu77) wrote :

While I understand Ubuntu's Stable Release Updates (SRU) policy emphasizes minimal changes to reduce risks, fix high-impact issues while minimizing user disruption, and should be as minimal as possible to reduce regression risks, but the nature of firmware-sof and the benefits of comprehensive updates which we believe these topology files for particular Intel platform (ex. sof-lnl/arl/mtl/...-$(codec_name)-xxxx) are signed and verified by Intel and would be advantageous in the long run.

The development of firmware-sof follows the standards of the upstream Linux community. It ensures firmware-sof package aligns with the broader Linux ecosystem to avoids compatibility issues. Updating only part of the files would require multiple SRUs, testing and verification cycles for the new/existing audio configurations which are also expected to be supported by Ubuntu.

You're right that we can't guarantee this approach is less risky. However, by including a comprehensive set of topology files, we can predictably reduce the need for additional testing and verification that would otherwise be required to support new machines or new audio configurations which are not on HWE's radar. This update aligns with community practices and helps maintain consistency with upstream developments. I'd expect it to handle a wider range of hardware configurations, thereby enhancing overall user experience and system compatibility.

Revision history for this message
Timo Aaltonen (tjaalton) wrote : Please test proposed package

Hello AaronMa, or anyone else affected,

Accepted linux-firmware into oracular-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/linux-firmware/20240913.gita34e7a5f-0ubuntu2.7 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-oracular to verification-done-oracular. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-oracular. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Revision history for this message
Timo Aaltonen (tjaalton) wrote :

Hello AaronMa, or anyone else affected,

Accepted linux-firmware into noble-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/linux-firmware/20240318.git3b128b60-0ubuntu2.12 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-noble to verification-done-noble. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-noble. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Revision history for this message
Andreas Hasenack (ahasenack) wrote :

> SOF tplg and alsa-ucm-conf should be the updated together to make audio work.

Ok

> 6.13+ kernel include plucky should support.

Ok, plucky is good then.

> oracular SRU had been sent to kernel maillist.

What does this mean for this SRU here? It sounds like we can only test it when the oracular kernel SRU is in proposed as well, is that it?

Revision history for this message
Andreas Hasenack (ahasenack) wrote :

> the benefits of comprehensive updates which we believe these topology files for particular Intel platform
> (ex. sof-lnl/arl/mtl/...-$(codec_name)-xxxx) are signed and verified by Intel and would be advantageous
> in the long run.

While I can appreciate that, it's not the topic of this SRU. In this SRU, you are enabling "cs42l43 and cs35l56 audio on Intel LNL". But there are dozens and dozens of other changes.

Furthermore, you are still claiming in the bug description that only cirrus audio could regress:

"""
  It may break cirrus audio support.
"""

Is that really true, given all the other topology files you are updating?

And:

> The development of firmware-sof follows the standards of the upstream Linux community. It ensures
> firmware-sof package aligns with the broader Linux ecosystem to avoids compatibility issues. Updating
> only part of the files would require multiple SRUs, testing and verification cycles for the
> new/existing audio configurations which are also expected to be supported by Ubuntu.

If you want to update all those other binary files, then your bug description must reflect that. As it is now, your bug is:
- asking to update two specific hardware devices
- testing just those two hardware devices
- stating that only cirrus audio (presumably those two hardware devices) could regress

It was fine so far. But then you:
- include 90+ topology files for other devices not mentioned even once in the bug.

Do you see the discrepancy and why I'm alarmed? What is in the actual bits of code that was uploaded is NOT what is stated in this bug. Your bug is requesting one thing, but doing something else much larger.

Revision history for this message
Chris Chiu (mschiu77) wrote :

I force-push the MR which only update related topologies

.../sof-lnl-cs42l43-l0-2ch.tplg | Bin 0 -> 71775 bytes
.../sof-lnl-cs42l43-l0-4ch.tplg | Bin 0 -> 71159 bytes
.../sof-lnl-cs42l43-l0-cs35l56-l23.tplg | Bin 0 -> 61382 bytes
.../sof-lnl-cs42l43-l0-cs35l56-l3-2ch.tplg | Bin 0 -> 71775 bytes
.../sof-lnl-cs42l43-l0-cs35l56-l3.tplg | Bin 0 -> 59994 bytes
.../sof-lnl-cs42l43-l0.tplg | Bin 0 -> 59994 bytes

oracular: https://code.launchpad.net/~mschiu77/ubuntu/+source/firmware-sof/+git/firmware-sof/+merge/484546
noble: https://code.launchpad.net/~mschiu77/ubuntu/+source/firmware-sof/+git/firmware-sof/+merge/484012

PPA uploaded here for testing: https://launchpad.net/~canonical-hwe-team/+archive/ubuntu/staging-kernels

Revision history for this message
AaronMa (mapengyu) wrote :

Reply to #20:

We can test 6.11.0-1020-oem and 6.14-15 kernel versions which are already released.

Oracular already merges the patches which will be in 6.11.0-27.

Revision history for this message
Andreas Hasenack (ahasenack) wrote :

Hello AaronMa, or anyone else affected,

Accepted alsa-ucm-conf into plucky-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/alsa-ucm-conf/1.2.12-1ubuntu1.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-plucky to verification-done-plucky. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-plucky. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in alsa-ucm-conf (Ubuntu Plucky):
status: New → Fix Committed
tags: added: verification-needed verification-needed-plucky
tags: added: verification-needed-oracular
Revision history for this message
Andreas Hasenack (ahasenack) wrote :

Hello AaronMa, or anyone else affected,

Accepted alsa-ucm-conf into oracular-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/alsa-ucm-conf/1.2.10-1ubuntu6.4 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-oracular to verification-done-oracular. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-oracular. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

tags: added: verification-needed-noble
Revision history for this message
Andreas Hasenack (ahasenack) wrote :

Hello AaronMa, or anyone else affected,

Accepted alsa-ucm-conf into noble-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/alsa-ucm-conf/1.2.10-1ubuntu5.5 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-noble to verification-done-noble. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-noble. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in firmware-sof (Ubuntu Oracular):
status: Incomplete → Fix Committed
Revision history for this message
Andreas Hasenack (ahasenack) wrote :

Hello AaronMa, or anyone else affected,

Accepted firmware-sof into oracular-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/firmware-sof/2024.06-1ubuntu1.4 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-oracular to verification-done-oracular. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-oracular. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in firmware-sof (Ubuntu Noble):
status: Incomplete → Fix Committed
Revision history for this message
Andreas Hasenack (ahasenack) wrote :

Hello AaronMa, or anyone else affected,

Accepted firmware-sof into noble-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/firmware-sof/2023.12.1-1ubuntu1.5 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-noble to verification-done-noble. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-noble. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Revision history for this message
AaronMa (mapengyu) wrote :

After installed firmware-sof-signed=2023.12.1-1ubuntu1.5/2024.06-1ubuntu1.4 and linux-firmware=20240318.git3b128b60-0ubuntu2.12/20240913.gita34e7a5f-0ubuntu2.7

With the lasted upstream version of alsa-ucm-conf, the audio works fine.

tags: added: verification-done verification-done-noble verification-done-oracular
removed: verification-needed verification-needed-noble verification-needed-oracular
Changed in linux-firmware (Ubuntu Plucky):
status: New → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package alsa-ucm-conf - 1.2.12-1ubuntu2

---------------
alsa-ucm-conf (1.2.12-1ubuntu2) questing; urgency=medium

  [ Atlas Yu ]
  * Add LED support for cs42l43 and cs35l56 (LP: #2106394)
    Upstream commits got dropped/modified due to contextual changes.
    - d/p/0001-sof-soundwire-Add-LED-support-for-cs35l56-amplifiers.patch

  [ Bin Li ]
  * Add rt713 & rt1318 LED control (LP: #2100732)
    - d/p/0001-Turn-speaker-LED-accroding-to-rt1318-speaker-status.patch
    - d/p/0002-sof-soundwire-rt1318-add-playback-control-switch.patch

  [ Chris Chiu ]
  * Change the default output volume of headphone for rt722 (LP: #2106464)
    - d/p/0001-rt722-change-output-volume-of-headphone-to-0dB.patch

 -- Bin Li <email address hidden> Tue, 06 May 2025 16:03:09 +0200

Changed in alsa-ucm-conf (Ubuntu):
status: Fix Committed → Fix Released
Revision history for this message
Atlas Yu (pseudoc) wrote :

The firmwares from firmware-sof and linux-firmware are corrected loaded on tow ThinkPad X9 laptops, but the alsa-ucm-conf does not work.

tags: added: verification-failed-noble verification-needed verification-needed-oracular
removed: verification-done verification-done-noble verification-done-oracular
Atlas Yu (pseudoc)
Changed in alsa-ucm-conf (Ubuntu Noble):
assignee: Atlas Yu (pseudoc) → nobody
status: Fix Committed → New
Changed in alsa-ucm-conf (Ubuntu Oracular):
assignee: Atlas Yu (pseudoc) → nobody
status: Fix Committed → New
Changed in alsa-ucm-conf (Ubuntu Plucky):
status: Fix Committed → New
Revision history for this message
Atlas Yu (pseudoc) wrote (last edit ):

> alsa-ucm-conf commits:
> 9e946d4 sof-soundwire: Add LED support for cs35l56 amplifiers
> 79c9e8f sof-soundwire: cs42l43: Drop headset mic from mic mute LED

These 2 commits depend on a number of commits, need to apply them as well to get the audio and led work, tested on 2 ThinkPad X9 laptops (noble).

Revision history for this message
Atlas Yu (pseudoc) wrote :

re-upload debdiff

alsa-ucm-conf/noble 1.2.10-1ubuntu5.6

Revision history for this message
Atlas Yu (pseudoc) wrote :

alsa-ucm-conf/oracular 1.2.10-1ubuntu6.5

Revision history for this message
Atlas Yu (pseudoc) wrote (last edit ):

Patches applied to noble/oracular do not take effect on plucky because alsa-ucm-conf/plucky did not carry over the patches from alsa-ucm-conf/oracular on its initial upload, need extra time to apply them as well.

Revision history for this message
Atlas Yu (pseudoc) wrote :

alsa-ucm-conf/plucky 1.2.12-1ubuntu1.2

Revision history for this message
Atlas Yu (pseudoc) wrote :

Main difference between plucky and other releases:

Import patches that have already been applied to noble and oracular, but not yet to plucky. This and previous uploads are dependent on these patches.
- d/p/0001-sof-soundwire-Add-missing-match-for-cs42l43-speakers.patch
- d/p/0002-sof-soundwire-Add-support-for-cs42l43-cs35l56-bridge.patch
- d/p/0001-sof-soundwire-Change-map-control-names-to-make-them-.patch
- d/p/0002-sof-soundwire-Add-sequence-for-controlling-Mic-Mute-.patch
- d/p/0004-rt722-add-mic-led-support.patch

Verified on the next-gen ThinkPad X1 Carbon as well on plucky, now the LED works fine.
https://bugs.launchpad.net/ubuntu/+source/alsa-ucm-conf/+bug/2100732/comments/24

Revision history for this message
Sebastien Bacher (seb128) wrote :

I've sponsored the new N/O/P series uploads now

Revision history for this message
Ubuntu Kernel Bot (ubuntu-kernel-bot) wrote :

This bug is awaiting verification that the linux/6.11.0-28.28 kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-oracular-linux' to 'verification-done-oracular-linux'. If the problem still exists, change the tag 'verification-needed-oracular-linux' to 'verification-failed-oracular-linux'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

tags: added: kernel-spammed-oracular-linux-v2 verification-needed-oracular-linux
Revision history for this message
AaronMa (mapengyu) wrote :

The audio output and mic work fine on 6.11.0-28:

u@Alloy-1:~$ arecord -l
**** List of CAPTURE Hardware Devices ****
card 0: sofsoundwire [sof-soundwire], device 1: Jack In (*) []
  Subdevices: 1/1
  Subdevice #0: subdevice #0
card 0: sofsoundwire [sof-soundwire], device 10: DMIC Raw (*) []
  Subdevices: 1/1
  Subdevice #0: subdevice #0
u@Alloy-1:~$ uname -a
Linux Alloy-1 6.11.0-28-generic #28-Ubuntu SMP PREEMPT_DYNAMIC Mon May 19 14:45:34 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

tags: added: verification-done-oracular-linux
removed: verification-needed-oracular-linux
description: updated
Revision history for this message
Andreas Hasenack (ahasenack) wrote :

0006-common-add-led.conf-with-SetLED-macro-to-hide-implem.patch adds a new setled macro, and 0007-ucm2-use-new-SetLED-macro-to-hide-the-implementation.patch starts using it for many chipsets, not just cs42l43 and cs35l56.

This introduces a chance of regression for other hardware, not just the one intended for this SRU. I suppose that change isn't really needed, and was pulled in just to make the follow-up patches apply. I.e., the fix for LED support in cs42l43 and cs35l56 is using the new macro, as can be seen in 0009-sof-soundwire-Add-LED-support-for-cs35l56-amplifiers.patch

Have you considered only making cs42l43 and cs35l56 use the new macro? Patch 0007-ucm2-use-new-SetLED-macro-to-hide-the-implementation.patch is currently also making rt5640, rt5672, rt715, rt722 use it, from what I could see.

Revision history for this message
Andreas Hasenack (ahasenack) wrote :

Alternatively, would you be able to test that the led functionality hasn't regressed, at least on some of the changed hardware?

Revision history for this message
Atlas Yu (pseudoc) wrote :

I am not able to test the led functionality hasn't regressed, no laptop nor AIO whose info is stored in our database is using neither of those chipsets.
But I do test that cs42l43 using the old way would work, to me, I don't see there would be a regression issue, the SetLED macro is doing the identical staff than before but a little bit optimized that only `modprobe snd_ctl_led` once. It's quite safe to apply SetLED macro to all chipsets.
And it will make us easier to apply in the future if upstream lands fixes on rt5640, rt5672, rt715, rt722.

Revision history for this message
Atlas Yu (pseudoc) wrote :

> [ Chris Chiu ]
> * Change the default output volume of headphone for rt722 (LP: #2106464)
> - d/p/0001-rt722-change-output-volume-of-headphone-to-0dB.patch

Hi Chris, do you have machine using the rt722? Please help to verify the led functionality as Andreas has the concern (#42 & #43), thanks.

Revision history for this message
Chris Chiu (mschiu77) wrote :

Verified with 1.2.10-1ubuntu5.6/1.2.10-1ubuntu6.5/1.2.12-1ubuntu1.2 on Tarako Delta SKU07_C03 by playing sound with headphone plugged, the default volume is expected.

The `amixer -c 0` output for `rt722 FU05 Playback Volume` is as follows
```
Simple mixer control 'rt722 FU05 Playback Volume', 0
Front Left: Playback 87
Front Right: Playback 87
```

Revision history for this message
Andreas Hasenack (ahasenack) wrote :

Hello AaronMa, or anyone else affected,

Accepted alsa-ucm-conf into plucky-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/alsa-ucm-conf/1.2.12-1ubuntu1.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-plucky to verification-done-plucky. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-plucky. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in alsa-ucm-conf (Ubuntu Plucky):
status: New → Fix Committed
Changed in alsa-ucm-conf (Ubuntu Oracular):
status: New → Fix Committed
Revision history for this message
Andreas Hasenack (ahasenack) wrote :

Hello AaronMa, or anyone else affected,

Accepted alsa-ucm-conf into oracular-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/alsa-ucm-conf/1.2.10-1ubuntu6.5 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-oracular to verification-done-oracular. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-oracular. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in alsa-ucm-conf (Ubuntu Noble):
status: New → Fix Committed
tags: added: verification-needed-noble
removed: verification-failed-noble
Revision history for this message
Andreas Hasenack (ahasenack) wrote :

Hello AaronMa, or anyone else affected,

Accepted alsa-ucm-conf into noble-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/alsa-ucm-conf/1.2.10-1ubuntu5.6 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-noble to verification-done-noble. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-noble. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Revision history for this message
Atlas Yu (pseudoc) wrote :

arecord + aplay works fine with packages from noble-proposed.

alsa-ucm-conf/1.2.10-1ubuntu5.6
firmware-sof-signed/2023.12.1-1ubuntu1.5
linux-firmware/20240318.git3b128b60-0ubuntu2.12

tags: added: verification-done-noble
removed: verification-needed-noble
Revision history for this message
Atlas Yu (pseudoc) wrote :

also works fine on oracular-proposed.

alsa-ucm-conf/1.2.10-1ubuntu6.5
firmware-sof-signed/2024.06-1ubuntu1.4
linux-firmware/20240913.gita34e7a5f-0ubuntu2.7

tags: added: verification-done-oracular
removed: verification-needed-oracular
Revision history for this message
Atlas Yu (pseudoc) wrote :

also works fine on plucky-proposed.

alsa-ucm-conf/1.2.12-1ubuntu1.2

tags: added: verification-done verification-done-plucky
removed: verification-needed verification-needed-plucky
Revision history for this message
Andreas Hasenack (ahasenack) wrote : Update Released

The verification of the Stable Release Update for linux-firmware has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package linux-firmware - 20240913.gita34e7a5f-0ubuntu2.7

---------------
linux-firmware (20240913.gita34e7a5f-0ubuntu2.7) oracular; urgency=medium

  * Support wifi 6GHz for Philippines on Qualcomm WCN6856 (LP: #2102200)
    - SAUCE: WCN6855 hw2.0: update board-2.bin
  * [SRU] enable cs42l43 and cs35l56 audio on Intel LNL (LP: #2106394)
    - cirrus: cs35l56: Add firmware for Cirrus CS35L56 for a Lenovo Laptop
    - cirrus: cs35l56: Add and update firmware for various Cirrus CS35L54 and CS35L56 laptops
  * Add support for QAT Gen5 device with the 420xx (CPM2.2) firmware (LP: #2106436)
    - linux-firmware: add firmware for qat_420xx devices
  * Fix amplifier cs35l56 dsp fw name for HP LAPZ platform (LP: #2106802)
    - cirrus: cs35l56: Correct filenames of SSID 103c8e1b and 103c8e1c

 -- Juerg Haefliger <email address hidden> Thu, 17 Apr 2025 08:11:10 +0200

Changed in linux-firmware (Ubuntu Oracular):
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package linux-firmware - 20240318.git3b128b60-0ubuntu2.12

---------------
linux-firmware (20240318.git3b128b60-0ubuntu2.12) noble; urgency=medium

  * Add support for Realtek 8852BE-VT[10ec:b520] (LP: #2103768)
    - rtw89: 8852bt: add firmware 0.29.91.0
    - rtw89: 8852bt: update fw to v0.29.110.0
    - rtw89: 8852bt: update fw to v0.29.122.0 and BB parameter to 07
  * Support wifi 6GHz for Philippines on Qualcomm WCN6856 (LP: #2102200)
    - ath11k: WCN6855 hw2.0: update board-2.bin
    - SAUCE: WCN6855 hw2.0: update board-2.bin
  * Support GPU driver on Qualcomm QCS6490 / SA8775 (LP: #2105425)
    - qcom: add gpu firmwares for sa8775p chipset
    - qcom: update gpu firmwares for qcm6490 chipset
    - qcom: Add link for QCS6490 GPU firmware
  * [SRU] enable cs42l43 and cs35l56 audio on Intel LNL (LP: #2106394)
    - cirrus: cs35l56: Add firmware for Cirrus CS35L56 for a Lenovo Laptop
    - cirrus: cs35l56: Update firmware for Cirrus CS35L56 for various ASUS laptops
    - cirrus: cs35l56: Update firmware for Cirrus CS35L56 for ASUS UM5606 laptop
    - cirrus: cs35l56: Add and update firmware for various Cirrus CS35L54 and CS35L56 laptops
  * Add support for QAT Gen5 device with the 420xx (CPM2.2) firmware (LP: #2106436)
    - linux-firmware: add firmware for qat_420xx devices
  * Fix amplifier cs35l56 dsp fw name for HP LAPZ platform (LP: #2106802)
    - cirrus: cs35l56: Correct filenames of SSID 103c8e1b and 103c8e1c
  * /sys/power/suspend_stats/total_hw_sleep not increased after suspend/resume on AMD GPU of DCN 3.5 (LP: #2103582)
    - amdgpu: DMCUB updates for various AMDGPU ASICs
    - amdgpu: update DMCUB to v0.0.224.0 for Various AMDGPU Asics
    - amdgpu: update DMCUB to v0.0.225.0 for Various AMDGPU Asics
    - amdgpu: update DMCUB to v0.0.227.0 for DCN35 and DCN351
    - amdgpu: DMCUB updates for various AMDGPU ASICs
    - amdgpu: DMCUB updates forvarious AMDGPU ASICs
    - amdgpu: DMCUB DCN35 update
    - amdgpu: DMCUB updates forvarious AMDGPU ASICs
    - amdgpu: DMCUB updates for various AMDGPU ASICs
    - amdgpu: update dmcub 0.0.246.0 firmware
    - amdgpu: DMCUB updates for various AMDGPU ASICs
    - amdgpu: DMCUB updates for various ASICs
    - amdgpu: DMCUB updates for various ASICs

 -- Juerg Haefliger <email address hidden> Thu, 17 Apr 2025 08:14:44 +0200

Changed in linux-firmware (Ubuntu Noble):
status: Fix Committed → Fix Released
Revision history for this message
Chris Halse Rogers (raof) wrote :

Has the complete test plan been followed for these verifications? Comment #50 only talks about aplay + arecord, but the test plan also covers:

3, press speaker-mute and mic-mute key, the OSD are shown,
and the LED is on when it's muted.
4, plugin headset and restest the steps above.

Have the full set of steps been tested?

Revision history for this message
Kai-Chuan Hsieh (kchsieh) wrote (last edit ):

I try the alsa-ucm-conf 1.2.10-1ubuntu5.6 on AMD Krakan Point with amd-soundwire sound card support.
I got below error when I try to execute $ sudo alsactl init. The audio on that platform is broken.

Found hardware: "HDA-Intel" "ATI R6xx HDMI" "HDA:1002aa01,00aa0100,00100900" "0x1002" "0x1640"
Hardware is initialized using a generic method
alsa-lib parser.c:427:(evaluate_macro1) Macro 'SetLED' is not defined
alsa-lib main.c:1554:(snd_use_case_mgr_open) error: failed to import hw:1 use case configuration -2
Found hardware: "amd-soundwire" "" " cfg-amp:1 hs:rt722 mic:rt722 spk:rt1320" "" ""
Hardware is initialized using a generic method

tags: added: verification-failed-noble
removed: verification-done-noble
Revision history for this message
Atlas Yu (pseudoc) wrote (last edit ):

Hi @KC, could please help to verify the fix? I think it works fine now, but I cannot verify the LED also performs as expected.

https://certification.canonical.com/hardware/202503-36529/

$ cat alsa-ucm-conf-1.2.10/debian/alsa-ucm-conf.links
/usr/share/alsa/ucm2/conf.d/sof-soundwire/sof-soundwire.conf /usr/share/alsa/ucm2/conf.d/amd-soundwire/amd-soundwire.conf

$ ssh ubuntu@10.102.180.42

ubuntu@localhost:~$ sudo alsactl init
Found hardware: "HDA-Intel" "ATI R6xx HDMI" "HDA:1002aa01,00aa0100,00100900" "0x1002" "0x1640"
Hardware is initialized using a generic method

ubuntu@localhost:~$ apt policy alsa-ucm-conf
alsa-ucm-conf:
  Installed: 1.2.10-1ubuntu5.7~fixup1
  Candidate: 1.2.10-1ubuntu5.7~fixup1
  Version table:
 *** 1.2.10-1ubuntu5.7~fixup1 100
        100 /var/lib/dpkg/status
     1.2.10-1ubuntu5.6 100
        100 http://archive.ubuntu.com/ubuntu noble-proposed/main amd64 Packages
        100 http://archive.ubuntu.com/ubuntu noble-proposed/main i386 Packages
     1.2.10-1ubuntu5.4 500
        500 http://archive.ubuntu.com/ubuntu noble-updates/main amd64 Packages
        500 http://archive.ubuntu.com/ubuntu noble-updates/main i386 Packages
     1.2.10-1ubuntu5 500
        500 http://archive.ubuntu.com/ubuntu noble/main amd64 Packages
        500 http://archive.ubuntu.com/ubuntu noble/main i386 Packages

Revision history for this message
Atlas Yu (pseudoc) wrote :

Chatted with KC, the fix up package for testing works fine:
https://launchpad.net/~pseudoc/+archive/ubuntu/mercury/+files/alsa-ucm-conf_1.2.10-1ubuntu5.7~fixup1_all.deb

ucm2/conf.d/amd-soundwire/amd-soundwire.conf should be a symlink to ucm2/conf.d/sof-soundwire/sof-soundwire.conf instead of being a concrete file, so SetLED macro is not defined on 'amd-soundwire'.

This patch uses dh_links by defining the symlink in debian/alsa-ucm-conf.links to create it.

alsa-ucm-conf/noble 1.2.10-1ubuntu5.7

Revision history for this message
Atlas Yu (pseudoc) wrote :

alsa-ucm-conf/oracular 1.2.10-1ubuntu6.6

Revision history for this message
Atlas Yu (pseudoc) wrote :

alsa-ucm-conf/plucky 1.2.12-1ubuntu1.3

Revision history for this message
Atlas Yu (pseudoc) wrote :

Chris Halse Rogers (raof) wrote on 2025-06-03: #56

> Has the complete test plan been followed for these verifications? Comment #50 only talks about aplay + arecord, but the test plan also covers:
>
> 3, press speaker-mute and mic-mute key, the OSD are shown,
> and the LED is on when it's muted.
> 4, plugin headset and restest the steps above.
>
> Have the full set of steps been tested?

[3] were also tested on n/o/p, [4] weren't. I'll test all of them on the next update.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package alsa-ucm-conf - 1.2.12-1ubuntu1.2

---------------
alsa-ucm-conf (1.2.12-1ubuntu1.2) plucky; urgency=medium

  * Import patches that have already been applied to noble and oracular,
    but not yet to plucky. This and previous uploads are dependent on
    these patches.
    - d/p/0001-sof-soundwire-Add-missing-match-for-cs42l43-speakers.patch
    - d/p/0002-sof-soundwire-Add-support-for-cs42l43-cs35l56-bridge.patch
    - d/p/0001-sof-soundwire-Change-map-control-names-to-make-them-.patch
    - d/p/0002-sof-soundwire-Add-sequence-for-controlling-Mic-Mute-.patch
    - d/p/0004-rt722-add-mic-led-support.patch

  * Add LED support for cs42l43 and cs35l56 (LP: #2106394)
    Some inapplicable patches were dropped in the previous upload. Now
    we include all its dependencies to make it work.

    Drop:
    - d/p/0001-sof-soundwire-Add-LED-support-for-cs35l56-amplifiers.patch

    Some upstream commits got modified due to contextual changes.
    Add:
    - d/p/0001-sof-soundwire-cs42l43-spk-Correct-PlaybackPCM-and-ro.patch
    - d/p/0002-sof-soundwire-cs42l43-Correct-CapturePCM-and-routing.patch
    - d/p/0003-ucm2-sof-soundwire-Correct-FixedBootSequence-for-dmi.patch
    - d/p/0004-sof-soundwire-Split-cs42l43-dmic-initialisation.patch
    - d/p/0005-sof-soundwire-Fix-cs42l43-dmic-initialisation.patch
    - d/p/0006-common-add-led.conf-with-SetLED-macro-to-hide-implem.patch
    - d/p/0007-ucm2-use-new-SetLED-macro-to-hide-the-implementation.patch
    - d/p/0008-sof-soundwire-cs42l43-Drop-headset-mic-from-mic-mute.patch
    - d/p/0009-sof-soundwire-Add-LED-support-for-cs35l56-amplifiers.patch
    - d/p/0010-sof-soundwire-cs42l43-Switch-mixer-based-on-output-v.patch

alsa-ucm-conf (1.2.12-1ubuntu1.1) plucky; urgency=medium

  [ Atlas Yu ]
  * Add LED support for cs42l43 and cs35l56 (LP: #2106394)
    Upstream commits got dropped/modified due to contextual changes.
    - d/p/0001-sof-soundwire-Add-LED-support-for-cs35l56-amplifiers.patch

  [ Bin Li ]
  * Add rt713 & rt1318 LED control (LP: #2100732)
    - d/p/0001-Turn-speaker-LED-accroding-to-rt1318-speaker-status.patch
    - d/p/0002-sof-soundwire-rt1318-add-playback-control-switch.patch

  [ Chris Chiu ]
  * Change the default output volume of headphone for rt722 (LP: #2106464)
    - d/p/0001-rt722-change-output-volume-of-headphone-to-0dB.patch

 -- Atlas Yu <email address hidden> Mon, 19 May 2025 13:45:13 +0800

Changed in alsa-ucm-conf (Ubuntu Plucky):
status: Fix Committed → Fix Released
Revision history for this message
Timo Aaltonen (tjaalton) wrote :

plucky got released by mistake, please test [4] too on noble/oracular and then mark verified..

tags: added: verification-needed-oracular-linux
removed: verification-done-oracular-linux
Revision history for this message
Sebastien Bacher (seb128) wrote :

v3 uploaded to N/O/P now

Revision history for this message
Nick Rosbrook (enr0n) wrote : Please test proposed package

Hello AaronMa, or anyone else affected,

Accepted alsa-ucm-conf into plucky-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/alsa-ucm-conf/1.2.12-1ubuntu1.3 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-plucky to verification-done-plucky. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-plucky. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in alsa-ucm-conf (Ubuntu Plucky):
status: Fix Released → Fix Committed
tags: added: verification-needed verification-needed-plucky
removed: verification-done verification-done-plucky
tags: added: verification-needed-oracular
removed: verification-done-oracular
Revision history for this message
Nick Rosbrook (enr0n) wrote :

Hello AaronMa, or anyone else affected,

Accepted alsa-ucm-conf into oracular-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/alsa-ucm-conf/1.2.10-1ubuntu6.6 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-oracular to verification-done-oracular. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-oracular. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Revision history for this message
Nick Rosbrook (enr0n) wrote :

Hello AaronMa, or anyone else affected,

Accepted alsa-ucm-conf into noble-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/alsa-ucm-conf/1.2.10-1ubuntu5.7 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-noble to verification-done-noble. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-noble. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

tags: added: verification-needed-noble
removed: verification-failed-noble
AaronMa (mapengyu)
description: updated
Revision history for this message
Atlas Yu (pseudoc) wrote (last edit ):

Verified the sound input and output using speaker-test and arecord+aplay from noble-proposed/oracular-proposed/plucky-proposed, the speaker-mute and mic-mute key also work fine.
The input and output are good after plugging the headset (Sony MDR-EX255AP) as well.

Package versions being tested:
alsa-ucm-conf/noble-proposed 1.2.10-1ubuntu5.7
alsa-ucm-conf/oracular-proposed 1.2.10-1ubuntu6.6
alsa-ucm-conf/plucky-proposed 1.2.12-1ubuntu1.3

Revision history for this message
Atlas Yu (pseudoc) wrote (last edit ):

Hi KC, would you please help to verify the regression fix as well on that AMD platform using rt722 chipsets?
Also, please update the tags when you finish the verification.

The symlink is correctly set:
u@Alloy-3:~$ realpath /usr/share/alsa/ucm2/conf.d/amd-soundwire/amd-soundwire.conf
/usr/share/alsa/ucm2/sof-soundwire/sof-soundwire.conf

Revision history for this message
Kai-Chuan Hsieh (kchsieh) wrote (last edit ):

Verify below items on https://certification.canonical.com/hardware/202505-36756/ with amdsoundwire soundcard with kernel 6.11.0-1024-oem and BIOS 0.2.22

1. internal input/output ok
2. headset input/output ok
3. micmute LED ok

Package versions being tested:
alsa-ucm-conf/noble-proposed 1.2.10-1ubuntu5.7
alsa-ucm-conf/oracular-proposed 1.2.10-1ubuntu6.6
alsa-ucm-conf/plucky-proposed 1.2.12-1ubuntu1.3

Atlas Yu (pseudoc)
tags: added: verification-done verification-done-noble verification-done-oracular verification-done-plucky
removed: verification-needed verification-needed-noble verification-needed-oracular verification-needed-plucky
Juerg Haefliger (juergh)
Changed in linux-firmware (Ubuntu):
status: In Progress → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package firmware-sof - 2023.12.1-1ubuntu1.5

---------------
firmware-sof (2023.12.1-1ubuntu1.5) noble; urgency=medium

  * Enable cs42l43+cs35l56 audio on Intel LNL of ThinkPad. (LP: #2106394)
    - Add 2.12 topology binaries for cs42l43+cs35l56 on Intel LNL targets

 -- Chris Chiu <email address hidden> Tue, 08 Apr 2025 13:43:07 +0800

Changed in firmware-sof (Ubuntu Noble):
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package firmware-sof - 2024.06-1ubuntu1.4

---------------
firmware-sof (2024.06-1ubuntu1.4) oracular; urgency=medium

  * Enable cs42l43+cs35l56 audio on Intel LNL of ThinkPad. (LP: #2106394)
    - Add 2.12 topology binaries for cs42l43+cs35l56 on Intel LNL targets

 -- Chris Chiu <email address hidden> Wed, 16 Apr 2025 09:24:59 +0800

Changed in firmware-sof (Ubuntu Oracular):
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package alsa-ucm-conf - 1.2.10-1ubuntu5.7

---------------
alsa-ucm-conf (1.2.10-1ubuntu5.7) noble; urgency=medium

  * Fix file mode of amd-soundwire.conf (LP: #2106394)
    amd-soundwire.conf should be a symlink to sof-soundwire.conf

alsa-ucm-conf (1.2.10-1ubuntu5.6) noble; urgency=medium

  * Add LED support for cs42l43 and cs35l56 (LP: #2106394)
    Some inapplicable patches were dropped in the previous upload. Now
    we include all its dependencies to make it work.

    Drop:
    - d/p/0001-sof-soundwire-Add-LED-support-for-cs35l56-amplifiers.patch

    Some upstream commits got modified due to contextual changes.
    Add:
    - d/p/0001-sof-soundwire-cs42l43-spk-Correct-PlaybackPCM-and-ro.patch
    - d/p/0002-sof-soundwire-cs42l43-Correct-CapturePCM-and-routing.patch
    - d/p/0003-ucm2-sof-soundwire-Correct-FixedBootSequence-for-dmi.patch
    - d/p/0004-sof-soundwire-Split-cs42l43-dmic-initialisation.patch
    - d/p/0005-sof-soundwire-Fix-cs42l43-dmic-initialisation.patch
    - d/p/0006-common-add-led.conf-with-SetLED-macro-to-hide-implem.patch
    - d/p/0007-ucm2-use-new-SetLED-macro-to-hide-the-implementation.patch
    - d/p/0008-sof-soundwire-cs42l43-Drop-headset-mic-from-mic-mute.patch
    - d/p/0009-sof-soundwire-Add-LED-support-for-cs35l56-amplifiers.patch
    - d/p/0010-sof-soundwire-cs42l43-Switch-mixer-based-on-output-v.patch

alsa-ucm-conf (1.2.10-1ubuntu5.5) noble; urgency=medium

  [Atlas Yu]
  * Add LED support for cs42l43 and cs35l56 (LP: #2106394)
    Upstream commits got dropped/modified due to contextual changes.
    - d/p/0001-sof-soundwire-Add-LED-support-for-cs35l56-amplifiers.patch

  [Bin Li]
  * Add rt713 & rt1318 LED control (LP: #2100732)
    - d/p/0001-Turn-speaker-LED-accroding-to-rt1318-speaker-status.patch
    - d/p/0002-sof-soundwire-rt1318-add-playback-control-switch.patch

  [Chris Chiu]
  * Change the default output volume of headphone for rt722 (LP: #2106464)
    - d/p/0001-rt722-change-output-volume-of-headphone-to-0dB.patch

 -- Atlas Yu <email address hidden> Tue, 10 Jun 2025 20:39:10 +0200

Changed in alsa-ucm-conf (Ubuntu Noble):
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package alsa-ucm-conf - 1.2.10-1ubuntu6.6

---------------
alsa-ucm-conf (1.2.10-1ubuntu6.6) oracular; urgency=medium

  * Fix file mode of amd-soundwire.conf (LP: #2106394)
    amd-soundwire.conf should be a symlink to sof-soundwire.conf

alsa-ucm-conf (1.2.10-1ubuntu6.5) oracular; urgency=medium

  * Add LED support for cs42l43 and cs35l56 (LP: #2106394)
    Some inapplicable patches were dropped in the previous upload. Now
    we include all its dependencies to make it work.

    Drop:
    - d/p/0001-sof-soundwire-Add-LED-support-for-cs35l56-amplifiers.patch

    Some upstream commits got modified due to contextual changes.
    Add:
    - d/p/0001-sof-soundwire-cs42l43-spk-Correct-PlaybackPCM-and-ro.patch
    - d/p/0002-sof-soundwire-cs42l43-Correct-CapturePCM-and-routing.patch
    - d/p/0003-ucm2-sof-soundwire-Correct-FixedBootSequence-for-dmi.patch
    - d/p/0004-sof-soundwire-Split-cs42l43-dmic-initialisation.patch
    - d/p/0005-sof-soundwire-Fix-cs42l43-dmic-initialisation.patch
    - d/p/0006-common-add-led.conf-with-SetLED-macro-to-hide-implem.patch
    - d/p/0007-ucm2-use-new-SetLED-macro-to-hide-the-implementation.patch
    - d/p/0008-sof-soundwire-cs42l43-Drop-headset-mic-from-mic-mute.patch
    - d/p/0009-sof-soundwire-Add-LED-support-for-cs35l56-amplifiers.patch
    - d/p/0010-sof-soundwire-cs42l43-Switch-mixer-based-on-output-v.patch

alsa-ucm-conf (1.2.10-1ubuntu6.4) oracular; urgency=medium

  [ Atlas Yu ]
  * Add LED support for cs42l43 and cs35l56 (LP: #2106394)
    Upstream commits got dropped/modified due to contextual changes.
    - d/p/0001-sof-soundwire-Add-LED-support-for-cs35l56-amplifiers.patch

  [ Bin Li ]
  * Add rt713 & rt1318 LED control (LP: #2100732)
    - d/p/0001-Turn-speaker-LED-accroding-to-rt1318-speaker-status.patch
    - d/p/0002-sof-soundwire-rt1318-add-playback-control-switch.patch

  [ Chris Chiu ]
  * Change the default output volume of headphone for rt722 (LP: #2106464)
    - d/p/0001-rt722-change-output-volume-of-headphone-to-0dB.patch

 -- Atlas Yu <email address hidden> Tue, 10 Jun 2025 20:37:09 +0200

Changed in alsa-ucm-conf (Ubuntu Oracular):
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package alsa-ucm-conf - 1.2.12-1ubuntu1.3

---------------
alsa-ucm-conf (1.2.12-1ubuntu1.3) plucky; urgency=medium

  * Fix file mode of amd-soundwire.conf (LP: #2106394)
    amd-soundwire.conf should be a symlink to sof-soundwire.conf

alsa-ucm-conf (1.2.12-1ubuntu1.2) plucky; urgency=medium

  * Import patches that have already been applied to noble and oracular,
    but not yet to plucky. This and previous uploads are dependent on
    these patches.
    - d/p/0001-sof-soundwire-Add-missing-match-for-cs42l43-speakers.patch
    - d/p/0002-sof-soundwire-Add-support-for-cs42l43-cs35l56-bridge.patch
    - d/p/0001-sof-soundwire-Change-map-control-names-to-make-them-.patch
    - d/p/0002-sof-soundwire-Add-sequence-for-controlling-Mic-Mute-.patch
    - d/p/0004-rt722-add-mic-led-support.patch

  * Add LED support for cs42l43 and cs35l56 (LP: #2106394)
    Some inapplicable patches were dropped in the previous upload. Now
    we include all its dependencies to make it work.

    Drop:
    - d/p/0001-sof-soundwire-Add-LED-support-for-cs35l56-amplifiers.patch

    Some upstream commits got modified due to contextual changes.
    Add:
    - d/p/0001-sof-soundwire-cs42l43-spk-Correct-PlaybackPCM-and-ro.patch
    - d/p/0002-sof-soundwire-cs42l43-Correct-CapturePCM-and-routing.patch
    - d/p/0003-ucm2-sof-soundwire-Correct-FixedBootSequence-for-dmi.patch
    - d/p/0004-sof-soundwire-Split-cs42l43-dmic-initialisation.patch
    - d/p/0005-sof-soundwire-Fix-cs42l43-dmic-initialisation.patch
    - d/p/0006-common-add-led.conf-with-SetLED-macro-to-hide-implem.patch
    - d/p/0007-ucm2-use-new-SetLED-macro-to-hide-the-implementation.patch
    - d/p/0008-sof-soundwire-cs42l43-Drop-headset-mic-from-mic-mute.patch
    - d/p/0009-sof-soundwire-Add-LED-support-for-cs35l56-amplifiers.patch
    - d/p/0010-sof-soundwire-cs42l43-Switch-mixer-based-on-output-v.patch

alsa-ucm-conf (1.2.12-1ubuntu1.1) plucky; urgency=medium

  [ Atlas Yu ]
  * Add LED support for cs42l43 and cs35l56 (LP: #2106394)
    Upstream commits got dropped/modified due to contextual changes.
    - d/p/0001-sof-soundwire-Add-LED-support-for-cs35l56-amplifiers.patch

  [ Bin Li ]
  * Add rt713 & rt1318 LED control (LP: #2100732)
    - d/p/0001-Turn-speaker-LED-accroding-to-rt1318-speaker-status.patch
    - d/p/0002-sof-soundwire-rt1318-add-playback-control-switch.patch

  [ Chris Chiu ]
  * Change the default output volume of headphone for rt722 (LP: #2106464)
    - d/p/0001-rt722-change-output-volume-of-headphone-to-0dB.patch

 -- Atlas Yu <email address hidden> Thu, 05 Jun 2025 15:12:06 +0800

Changed in alsa-ucm-conf (Ubuntu Plucky):
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (60.3 KiB)

This bug was fixed in the package linux - 6.11.0-28.28

---------------
linux (6.11.0-28.28) oracular; urgency=medium

  * oracular/linux: 6.11.0-28.28 -proposed tracker (LP: #2110681)

  * Oracular update: upstream stable patchset 2025-05-07 (LP: #2110173)
    - drm/dp_mst: Factor out function to queue a topology probe work
    - drm/dp_mst: Add a helper to queue a topology probe
    - drm/amd/display: Don't write DP_MSTM_CTRL after LT
    - watch_queue: fix pipe accounting mismatch
    - x86/mm/pat: cpa-test: fix length for CPA_ARRAY test
    - cpufreq: scpi: compare kHz instead of Hz
    - smack: dont compile ipv6 code unless ipv6 is configured
    - smack: ipv4/ipv6: tcp/dccp/sctp: fix incorrect child socket label
    - sched: Cancel the slice protection of the idle entity
    - cpufreq: governor: Fix negative 'idle_time' handling in dbs_update()
    - EDAC/{skx_common,i10nm}: Fix some missing error reports on Emerald Rapids
    - x86/fpu: Fix guest FPU state buffer allocation size
    - x86/fpu: Avoid copying dynamic FP state from init_task in
      arch_dup_task_struct()
    - x86/platform: Only allow CONFIG_EISA for 32-bit
    - [Config] updateconfigs for EISA
    - x86/sev: Add missing RIP_REL_REF() invocations during sme_enable()
    - lockdep/mm: Fix might_fault() lockdep check of current->mm->mmap_lock
    - PM: sleep: Adjust check before setting power.must_resume
    - cpufreq: tegra194: Allow building for Tegra234
    - RISC-V: KVM: Disable the kernel perf counter during configure
    - kunit/stackinit: Use fill byte different from Clang i386 pattern
    - watchdog/hardlockup/perf: Fix perf_event memory leak
    - selinux: Chain up tool resolving errors in install_policy.sh
    - EDAC/ie31200: Fix the size of EDAC_MC_LAYER_CHIP_SELECT layer
    - EDAC/ie31200: Fix the DIMM size mask for several SoCs
    - EDAC/ie31200: Fix the error path order of ie31200_init()
    - x86/resctrl: Fix allocation of cleanest CLOSID on platforms with no monitors
    - thermal: int340x: Add NULL check for adev
    - PM: sleep: Fix handling devices with direct_complete set on errors
    - lockdep: Don't disable interrupts on RT in disable_irq_nosync_lockdep.*()
    - perf/ring_buffer: Allow the EPOLLRDNORM flag for poll
    - x86/traps: Make exc_double_fault() consistently noreturn
    - x86/fpu/xstate: Fix inconsistencies in guest FPU xfeatures
    - x86/entry: Add __init to ia32_emulation_override_cmdline()
    - regulator: pca9450: Fix enable register for LDO5
    - auxdisplay: MAX6959 should select BITREVERSE
    - media: verisilicon: HEVC: Initialize start_bit field
    - media: platform: allgro-dvt: unregister v4l2_device on the error path
    - auxdisplay: panel: Fix an API misuse in panel.c
    - platform/x86: lenovo-yoga-tab2-pro-1380-fastcharger: Make symbol static
    - platform/x86: dell-uart-backlight: Make dell_uart_bl_serdev_driver static
    - platform/x86: dell-ddv: Fix temperature calculation
    - ASoC: cs35l41: check the return value from spi_setup()
    - ASoC: amd: acp: Fix for enabling DMIC on acp platforms via _DSD entry
    - HID: remove superfluous (and wrong) Makefile entry for
      CONFIG_INTEL_ISH_FIRMWARE_DOWNLOADER
    ...

Changed in linux (Ubuntu Oracular):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.