Ubuntu

conffile_prompt check incomplete on multiple conffiles

Reported by Michael Vogt on 2011-04-29
16
This bug affects 2 people
Affects Status Importance Assigned to Milestone
unattended-upgrades (Debian)
Fix Released
Unknown
unattended-upgrades (Ubuntu)
Medium
Unassigned
Lucid
Medium
Unassigned
Maverick
Medium
Unassigned
Natty
Medium
Unassigned

Bug Description

TEST CASE:
 The bug can only be triggered when there is a package with multiple configuration files and the update
 changes one configuration files (but not the first) and the user has modified the local configuration
 file. This is the case for asterisk-config in debian/squeeze and this is how the bug got discovered.
 I added a test in the code to artificially trigger the error. For the real verification we can either
 reply on Debian or create a squeeze chroot with asterisk-config installed then modifying /etc/asterisk
 /sip.conf and running unattended-upgrades.

Given that its pretty difficult to trigger this bug I think a regression test is sufficient. Running the
lucid-updates version in a clean VM and then the lucid-proposed version and comparing /var/log/apt/history.log (or comparing the result of unattedned-upgrades --dry-run) should be sufficient.

Binary package hint: unattended-upgrades

There is a bug in the conffile detection that causes the code to miss modified conffiles if there are multiple conffiles.

Michael Vogt (mvo) on 2011-04-29
Changed in unattended-upgrades (Ubuntu):
status: New → In Progress
importance: Undecided → High
Michael Vogt (mvo) on 2011-04-29
Changed in unattended-upgrades (Ubuntu Natty):
status: New → In Progress
Changed in unattended-upgrades (Ubuntu):
status: In Progress → Fix Committed
Changed in unattended-upgrades (Ubuntu Natty):
importance: Undecided → High
Michael Vogt (mvo) on 2011-04-29
description: updated
Michael Vogt (mvo) on 2011-04-29
Changed in unattended-upgrades (Ubuntu Maverick):
status: New → In Progress
Changed in unattended-upgrades (Ubuntu Lucid):
status: New → In Progress
Michael Vogt (mvo) on 2011-04-29
Changed in unattended-upgrades (Ubuntu Maverick):
importance: Undecided → High
Changed in unattended-upgrades (Ubuntu Lucid):
importance: Undecided → Medium
Changed in unattended-upgrades (Ubuntu Maverick):
importance: High → Medium
Changed in unattended-upgrades (Ubuntu Natty):
importance: High → Medium
Changed in unattended-upgrades (Ubuntu):
importance: High → Medium

Accepted unattended-upgrades into lucid-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

Changed in unattended-upgrades (Ubuntu Lucid):
status: In Progress → Fix Committed
tags: added: verification-needed
Changed in unattended-upgrades (Ubuntu Maverick):
status: In Progress → Fix Committed
Martin Pitt (pitti) wrote :

Accepted unattended-upgrades into maverick-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

Martin Pitt (pitti) wrote :

Accepted unattended-upgrades into natty-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

Changed in unattended-upgrades (Ubuntu Natty):
status: In Progress → Fix Committed
Rolf Leggewie (r0lf) wrote :

If you need help testing this on lucid let me know. Right now the test case is a bit opaque to me.

Changed in unattended-upgrades (Debian):
status: Unknown → Fix Released
tags: added: testcase
Michael Vogt (mvo) on 2011-11-28
description: updated
Jean-Baptiste Lallement (jibel) wrote :

SRU verification for Lucid:

Here is the test case I followed:
1. Installed asterisk-config from lucid-release
2. modified /etc/asterisk/sip.conf
3. Ran unattended-upgrades from lucid-updates
=> the upgrade fails with the following error: 'EOF on stdin at conffile prompt'
4. downgrade asterisk-config to lucid-release again
5. install u-u from -proposed
6. run u-u again

RESULT: no failure and the package is kept untouched.

I have reproduced the problem with unattended-upgrades 0.55ubuntu5 in lucid-updates and have verified that the version of unattended-upgrades 0.55ubuntu6 in -proposed fixes the issue.

Marking as verification-done-lucid

tags: added: verification-done
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package unattended-upgrades - 0.55ubuntu6

---------------
unattended-upgrades (0.55ubuntu6) lucid-proposed; urgency=low

  * unattended-upgrade:
    - fix conffile prompt detection on multiple conffiles (LP: #773007)
  * test/unattended_upgrade.py:
    - add symlink to unattended-upgrades needed for the test of the
      conffile_prompt() function
  * test/test_conffile.py:
    - backport the conffile test case to ensure the fix is correct
  * test/{var,etc}/
    - backport fake root for the test
 -- Michael Vogt <email address hidden> Fri, 29 Apr 2011 10:47:38 +0200

Changed in unattended-upgrades (Ubuntu Lucid):
status: Fix Committed → Fix Released
Martin Pitt (pitti) wrote :

Setting back verification tags for other releases.

tags: added: verification-done-lucid
removed: verification-done
Martin Pitt (pitti) wrote :

Hello Michael, or anyone else affected,

Accepted unattended-upgrades into oneiric-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

Launchpad Janitor (janitor) wrote :

This bug was fixed in the package unattended-upgrades - 0.75.1

---------------
unattended-upgrades (0.75.1) unstable; urgency=low

  * print conffile hold-backs to stdout to ensure its part of
    the cron mail (LP: #773007), thanks to Jean-Baptiste Lallement
  * unattended-upgrade:
    - fix crash on automatic-reboot, thanks to Teodor (closes: #651822)
  * typo fixes, thanks to Lei Zhang
 -- Ubuntu Archive Auto-Sync <email address hidden> Mon, 26 Dec 2011 17:53:01 +0000

Changed in unattended-upgrades (Ubuntu):
status: Fix Committed → Fix Released
Bartosz Kosiorek (gang65) wrote :

The package for Lucid is still in proposed, that's why I set it to "Fix Commited"

Changed in unattended-upgrades (Ubuntu Lucid):
status: Fix Released → Fix Committed
status: Fix Committed → Fix Released
Bartosz Kosiorek (gang65) wrote :

Sorry I made mistake...

Sebastien Bacher (seb128) wrote :

Could someone who had the issue confirm that the fix works so it can be validated as a correct update and move out of staging?

The fix for this bug has been awaiting testing feedback in the -proposed repository for oneiric for more than 90 days. Please test this fix and update the bug appropriately with the results. In the event that the fix for this bug is still not verified 15 days from now, the package will be removed from the -proposed repository.

tags: added: removal-candidate
Changed in unattended-upgrades (Ubuntu Maverick):
status: Fix Committed → Won't Fix
Changed in unattended-upgrades (Ubuntu Natty):
status: Fix Committed → Won't Fix
tags: removed: verification-needed
tags: removed: removal-candidate
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.