Resize grips are covering scrollbar button on Chromium

[Cody Russell]

Binary package hint: chromium-browser

Chromium's lower scrollbar button is covered by the new gtk+ resize grip.

[Fabien Tassin (fta)]

Interesting. I will give it a try shortly and land it in the various builds with the next updates.
Is it supposed to fix the ugly orange square too?

[Fabien Tassin (fta)]

questions:

why did you make it against Chromium 6? it's old.

I will first attempt to land it in trunk (v10), then dev and beta (v9), and then stable (v8, soon v9). (that's my workflow)

Also, will it break on older dists? lucid? hardy? (i auto-backport everything down to hardy by default)

[Evan Martin (Chromium) (evan-chromium)]

I forget, did we already discuss this? We'd be ok with offsetting the scrollbars so that they don't cover the grip, too.

[Fabien Tassin (fta)]

what i see is an orange square covering the scrollbar, not the grip. well, it is the grip as it permits the resize, but an ugly one.

I'd prefer not to have to carry a patch but as it's needed in the stable branch for natty, i'm afraid i will have to take one.

[Matthew Paul Thomas (mpt)]

Offsetting to retain the grip would be nicer than disabling the grip.

The orange-brown square seems to be a side-effect of orange-brown being the overall background color for the window, which normally is hidden everywhere except the tab bar and window borders. I guess one way to fix it would be to draw over that square in the default background color. Another would be to use a less vibrant background color for the window.

[Cody Russell (bratsche)]

"Also, will it break on older dists? lucid? hardy? (i auto-backport everything down to hardy by default)"

@Fabien: Yes, if possible this really needs to be a distro-patch for now. The resize grip feature has landed upstream in GTK+ 3.0, but I backported it to 2.x for Natty. It's not possible to backport it to older distros at this point though.

[Fabien Tassin (fta)]

I'm all for offsetting the scrollbar too but it seems tricky to achieve. the behavior is not the same if there's a download bar or not, if it's in app mode, or in the inspector window, etc.

In the meantime, I'll apply the patch as it is, on natty only, starting with the daily builds to see how it goes, then I'll land it downward to the more stable builds.

[Evan Martin (Chromium) (evan-chromium)]

The window background color is the same as the window border color, and they are chosen to match because resizing the window (on a non-compositing WM) causes the background color to be drawn in the regions that haven't been painted yet. So when the colors match the bleeding is at least of a single color.

We tried to provide hooks to let people (like you guys!) improve the colors, because GTK sorta leaves us hanging otherwise:
http://code.google.com/p/chromium/wiki/LinuxGtkThemeIntegration
(Comes complete with suggested modifications for Ubuntu Ambiance.)

[Launchpad Janitor (janitor)]

This bug was fixed in the package chromium-browser - 9.0.597.84~r72991-0ubuntu1

---------------
chromium-browser (9.0.597.84~r72991-0ubuntu1) natty; urgency=high

  * New upstream release from the Stable Channel (LP: #712655)
    This release fixes the following security issues:
    - [55831] High, Use-after-free in image loading. Credit to Aki Helin of
      OUSPG.
    - [59081] Low, Apply some restrictions to cross-origin drag + drop. Credit
      to Google Chrome Security Team (SkyLined) and the Google Security Team
      (Michal Zalewski, David Bloom).
    - [62791] Low, Browser crash with extension with missing key. Credit to
      Brian Kirchoff.
    - [65669] Low, Handle merging of autofill profiles more gracefully. Credit
      to Google Chrome Security Team (Inferno).
    - [68244] Low, Browser crash with bad volume setting. Credit to Matthew
      Heidermann.
    - [69195] Critical, Race condition in audio handling. Credit to the gamers
      of Reddit!
  * Add the app/resources/app_strings.grd template to the list
    of templates translated in Launchpad
    - update debian/rules
  * Drop the gcc 4.5 work-around, applied upstream
    - remove debian/patches/gcc-4.5-build-workaround.patch
    - update debian/patches/series
  * Drop gcc 4.2/4.3 from Build-depends and remove the gcc 4.4 workarounds
    now done in the upstream gyp files
    - update debian/control
    - update debian/rules
  * Add libxtst-dev to Build-deps now that chromoting uses the XTest extension
    to execute mouse and keyboard events
    - update debian/control
  * Remove GNOME_DESKTOP_SESSION_ID from the Apport report, it's useless
    - update debian/apport/chromium-browser.py
  * Add a system to enable/disable distribution specific patches from the quilt
    series
    - add debian/enable-dist-patches.pl
    - update debian/rules
  * Disable the gtk resize grip on Natty (LP: #703451)
    Original patch by Cody Russell <email address hidden>, ported to v9
    - add debian/patches/disable_gtk_resize_grip_on_natty.patch
    - update debian/patches/series
  * Fix the libgnutls dlopen to look for the sonamed lib
    - add debian/patches/dlopen_libgnutls.patch
    - update debian/patches/series
  * Fix the libosmesa/libGLESv2/libEGL dlopen() to look for the sonamed libs.
    This assumes either the libgles2-mesa + libegl1-mesa packages (better) or
    the libosmesa6 package are installed
    - add debian/patches/dlopen_sonamed_gl.patch
    - update debian/patches/series
 -- Fabien Tassin <email address hidden> Thu, 03 Feb 2011 22:56:37 +0100

[Fabien Tassin (fta)]

we should probably keep this open to track a real fix..