95-kpartx.rules uses invalid -Q argument to modprobe(8)

Bug #644481 reported by John Morrissey
16
This bug affects 2 people
Affects Status Importance Assigned to Milestone
multipath-tools (Ubuntu)
Fix Released
Medium
Unassigned
Lucid
Won't Fix
Medium
Unassigned
Maverick
Won't Fix
Undecided
Unassigned

Bug Description

Binary package hint: multipath-tools

95-kpartx.rules calls modprobe(8) with the invalid -Q argument. I'm guessing it wants -q, for quiet?

--
# Always attempt to load dm-multipath. This way we can get rid of the
# init script.
ACTION=="add|change", SUBSYSTEM=="block", \
     RUN+="/sbin/modprobe -Qba dm-multipath"
--

udevd debug output:

1285084979.983300 [15293] udev_rules_apply_to_event: RUN '/sbin/modprobe -Qba dm-multipath' /lib/udev/rules.d/95-kpartx.rul
es:10
1285084979.984021 [15293] util_run_program: '/sbin/modprobe -Qba dm-multipath' started
1285084979.984499 [15293] util_run_program: '/sbin/modprobe' (stderr) '/sbin/modprobe: invalid option -- 'Q''
1285084979.984516 [15293] util_run_program: '/sbin/modprobe' (stderr) 'Usage: /sbin/modprobe [-v] [-V] [-C config-file] [-d <dirname> ] [-n] [-i] [-q] [-b] [-o <modname>] [ --dump-modversions ] <modname> [parameters...]'
1285084979.984522 [15293] util_run_program: '/sbin/modprobe' (stderr) '/sbin/modprobe -r [-n] [-i] [-v] <modulename> ...'
1285084979.984524 [15293] util_run_program: '/sbin/modprobe' (stderr) '/sbin/modprobe -l -t <dirname> [ -a <modulename> ...]'
1285084979.984578 [15293] util_run_program: '/sbin/modprobe -Qba dm-multipath' returned with exitcode 1

SRU Justification:
1. Impact: multipath fails because modprobe doesn't load the needed modules
2. How bug addressed: the udev rule calling multipath is fixed to not use a wrong argument
3. Patch: see comment #3
4. Test case: dont' have dm-multipath in /etc/modules. 95-kpartx.rules won't load it.
5. Regression potential: none.

Revision history for this message
Mathias Gug (mathiaz) wrote :

Thank you for taking the time to report this bug and helping to make Ubuntu better.

Which version are you seeing this bug with?

Changed in multipath-tools (Ubuntu):
status: New → Incomplete
importance: Undecided → Medium
Revision history for this message
John Morrissey (jwm) wrote :

0.4.8-14ubuntu4. Sorry, I forgot to mention that.

Changed in multipath-tools (Ubuntu):
status: Incomplete → Confirmed
assignee: nobody → Serge Hallyn (serge-hallyn)
Revision history for this message
Serge Hallyn (serge-hallyn) wrote :
Revision history for this message
Serge Hallyn (serge-hallyn) wrote :

The fix for this is now in natty. Since this bug does no actual damage, I do not intend to pursue SRUs to lucid and maverick.

Changed in multipath-tools (Ubuntu):
status: Confirmed → Fix Released
Changed in multipath-tools (Ubuntu):
assignee: Serge Hallyn (serge-hallyn) → nobody
Revision history for this message
Serge Hallyn (serge-hallyn) wrote :

nominating for lucid and maverick as per bug 737027 which reports actual breakage as a result.

description: updated
Changed in multipath-tools (Ubuntu Lucid):
status: New → Confirmed
Changed in multipath-tools (Ubuntu Maverick):
status: New → Confirmed
Revision history for this message
Clint Byrum (clint-fewbar) wrote : Please test proposed package

Accepted multipath-tools into lucid-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

Changed in multipath-tools (Ubuntu Lucid):
status: Confirmed → Fix Committed
tags: added: verification-needed
Revision history for this message
Clint Byrum (clint-fewbar) wrote :

The upload to lucid-proposed was deleted, as the version was higher than that of the dev release, oneiric. If you happened to download that version while it was briefly available, you should manually downgrade back to 0.4.8-14ubuntu4, otherwise you run the risk of not updating this package on an upgrade to maverick.

Changed in multipath-tools (Ubuntu Lucid):
importance: Undecided → Medium
status: Fix Committed → Triaged
tags: removed: verification-needed
Revision history for this message
Rolf Leggewie (r0lf) wrote :

maverick has seen the end of its life and is no longer receiving any updates. Marking the maverick task for this ticket as "Won't Fix".

Changed in multipath-tools (Ubuntu Maverick):
status: Confirmed → Won't Fix
Revision history for this message
Rolf Leggewie (r0lf) wrote :

lucid has seen the end of its life and is no longer receiving any updates. Marking the lucid task for this ticket as "Won't Fix".

Changed in multipath-tools (Ubuntu Lucid):
status: Triaged → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.