[MIR] linphone

[Rohan Garg]

Binary package hint: linphone

Hi
linphone provides two packages libmediastreamer-dev and libosip2-dev in universe (apart from many others),these packages are required for enabling google chat call support in kopete.We just need the above 2 packages in main.

The package is already in universe and has good upstream support from debian
I have verified that the package meets all MIR requirements and is fit to be included in main.

[Jonathan Riddell (jr)]

promoted relevant parts to main, approval still needed

[Alexander Sack (asac)]

a few strict-aliasing warnings that should be taken seriously:

libtool: compile: gcc -DHAVE_CONFIG_H -I. -I.. -I.. -I../mediastreamer2/include -DIN_LINPHONE -I../oRTP/include -DOSIP_MT -DHAVE_PTHREAD -DOSIP_MT -DHAVE_PTHREAD -DOSIP_MT -DENABLE_TRACE -DLOG_DOMAIN=\"LinphoneCore\" -DINET6 -DORTP_INET6 -g -O2 -g -Wall -O2 -c address.c -fPIC -DPIC -o .libs/address.o
misc.c: In function 'linphone_core_get_local_ip_for':
misc.c:739: warning: dereferencing pointer 'p_addr' does break strict-aliasing rules
misc.c:700: note: initialized from here
misc.c:741: warning: dereferencing pointer 'p_sin' does break strict-aliasing rules
misc.c:740: note: initialized from here

something dangerous:
linphonec-commands.o: In function `lpc_cmd_speak':
/build/buildd/linphone-3.3.1/console/commands.c:1660: warning: the use of `tempnam' is dangerous, better use `mkstemp'

1. check those out please for main inclusion.

2. Also please ensure that there is either .symbols or explicit shlibs depends version specified - alternatively point to process used by debian maintainers to ensure that ABI/API is properly tracked.

[Alexander Sack (asac)]

set back to NEW status when done so i can revisit. thanks!

[Jonathan Riddell (jr)]

The problems you point out in comment #2 do not affect the two libraries we need from linphone. Only libortp and libmediastreamer should get promoted, the rest should stay in universe. If requires I could split out these libraries into separate source packages, but that seems hassle for no good reason.

[Alexander Sack (asac)]

i am fine if none of these affects libraries is for main. however, please ensure that thoes bugs get filed upstream etc. also abi/api tracking should probably still be required?

[Alexander Sack (asac)]

setting to incomplete until my points are answered addressed ;)

[Matthias Klose (doko)]

libexosip2 and libpsip2 build dependencies ..

[Matthias Klose (doko)]

from the linphone source package, demoted:
  linphone linphone-nox linphone-common liblinphone3 liblinphone-dev
kept in main:
  libmediastreamer0 libmediastreamer-dev libortp8 libortp-dev

the latter needed by

[Launchpad Janitor (janitor)]

This bug was fixed in the package libosip2 - 3.3.0-1ubuntu1

---------------
libosip2 (3.3.0-1ubuntu1) maverick; urgency=low

  * Add libosip2-4.symbols file for ABI tracking, LP: #595173
 -- Jonathan Riddell <email address hidden> Tue, 21 Sep 2010 13:04:24 +0100

[Launchpad Janitor (janitor)]

This bug was fixed in the package libexosip2 - 3.3.0-1ubuntu1

---------------
libexosip2 (3.3.0-1ubuntu1) maverick; urgency=low

  * Build-depend on 3.3.0-1ubuntu1 for guaranteed ABI
  * Add libexosip2-4.symbols to ensure ABI stability, LP: #595173
 -- Jonathan Riddell <email address hidden> Tue, 21 Sep 2010 13:14:57 +0100

[Launchpad Janitor (janitor)]

This bug was fixed in the package linphone - 3.3.2-2ubuntu2

---------------
linphone (3.3.2-2ubuntu2) maverick; urgency=low

  * Build-depend on libosip2-dev (>= 3.3.0-1ubuntu1), libexosip2-dev (>=
    3.3.0-1ubuntu1) for guaranteed ABI
  * Add debian/liblinphone3.symbols debian/libmediastreamer0.symbols
    debian/libortp8.symbols to ensure ABI compatibility LP: #595173
 -- Jonathan Riddell <email address hidden> Tue, 21 Sep 2010 13:48:30 +0100