[Impact]
The command ordering between libmpathpersist and multipathd is not using the correct keyword for commands. The result is when attempting to use mpathpersist a "Missing argument" is displayed and the command can not be executed properly.
This is a regression caused by a CVE fix in release 0.8.8-1ubuntu1.22.04.1,
https://github.com/opensvc/multipath-tools/commit/f812466f68b8e020818c6454d7b7a7e278bc99f6
A patch from upstream fixes this by handling different command ordering: https://github.com/opensvc/multipath-tools/commit/04912e2fea94da2e7ccedabab5725b07ade2bcd4
[Test Plan]
The autopkgtest provide sufficient testing to spot for regressions, specifically tgtbasedmpaths does a full set-up and stress test of the multipath on local iscsi targets. Therefore, the targeted test here will be for mpathpersist and ensuring the command ordering is working, on-top of that, ensuring the multipath-tools package upgrades in-place without any problems.
1. Set up a VM
2. Login to VM, and install required packages
# apt install -y lsscsi multipath-tools open-iscsi tgt
// If testing new PPA add that here
# add-apt-repository -y ppa:mitchdz/multipath-tools-2026881 && apt update -y && apt upgrade -y
3. Setup targets to test against
```
targetname="iqn.2016-11.foo.com:target.iscsi"
cwd=$(pwd)
testdir="/mnt/tgtmpathtest"
localhost="127.0.0.1"
portal="${localhost}:3260"
maxpaths=4
backfn="backingfile"
expectwwid="60000000000000000e00000000010001"
testdisk="/dev/disk/by-id/wwn-0x${expectwwid}"
### Setup mpath devices
# Restart tgtd to make sure modules are all loaded
service tgt restart || echo "Failed to restart tgt" >&2
# prep SINGLE test file
truncate --size 100M ${backfn}
# create target
tgtadm --lld iscsi --op new --mode target --tid 1 -T "${targetname}"
# allow all to bind the target
tgtadm --lld iscsi --op bind --mode target --tid 1 -I ALL
# set backing file
tgtadm --lld iscsi --op new --mode logicalunit --tid 1 --lun 1 -b "${cwd}/${backfn}"
# scan for targets (locally)
iscsiadm --mode discovery --type sendtargets --portal ${localhost}
# login
echo "login #1"
iscsiadm --mode node --targetname "${targetname}" --portal ${portal} --login
# duplicate this session (always 1)
for i in $(seq 2 ${maxpaths})
do
echo "extra login #${i}"
iscsiadm --mode session -r 1 --op new
done
udevadm settle
sleep 5 # sleep a bit to allow device to be created.
# status summary
echo "Status after initial setup"
tgtadm --lld iscsi --mode target --op show
tgtadm --lld iscsi --op show --mode conn --tid 1
iscsiadm --mode session -P 1
lsscsi -liv
multipath -v3 -ll
dmsetup table
echo "Test WWN should now point to DM"
readlink "${testdisk}" | grep dm
```
4. test mpathpersist usage
// Current (failing) case
# dpkg -l multipath-tools | awk '/^ii/ {print $3}'
0.8.8-1ubuntu1.22.04.1
# mpathpersist -v2 --out --register-ignore --param-sark=0x214872831999999 /dev/dm-0
184.785211 | mpatha: adding new path sdd
184.786687 | mpatha: adding new path sda
184.788045 | mpatha: adding new path sdc
184.789458 | mpatha: adding new path sdb
184.790255 | mpatha: pr message=map mpatha setprstatus
184.790521 | mpatha: message=map mpatha setprstatus reply=map mpatha setprstatus: Missing argument
....
// Fixed case
# dpkg -l multipath-tools | awk '/^ii/ {print $3}'
0.8.8-1ubuntu1.22.04.2~jammy5
# mpathpersist -v2 --out --register-ignore --param-sark=0x214872831999999 /dev/dm-0
299.345497 | mpatha: adding new path sdd
299.347042 | mpatha: adding new path sdb
299.348504 | mpatha: adding new path sdc
299.349918 | mpatha: adding new path sda
299.350760 | mpatha: pr message=setprstatus map mpatha
299.351526 | mpatha: message=setprstatus map mpatha reply=ok
5. Test in-place upgrade
# dpkg -l multipath-tools | awk '/^ii/ {print $3}'
0.8.8-1ubuntu1.22.04.1
# multipath -ll
mpatha (360000000000000000e00000000010001) dm-0 IET,VIRTUAL-DISK
size=100M features='0' hwhandler='0' wp=rw
|-+- policy='service-time 0' prio=1 status=active
| `- 9:0:0:1 sdd 8:48 active ready running
|-+- policy='service-time 0' prio=1 status=enabled
| `- 6:0:0:1 sda 8:0 active ready running
|-+- policy='service-time 0' prio=1 status=enabled
| `- 7:0:0:1 sdb 8:16 active ready running
`-+- policy='service-time 0' prio=1 status=enabled
`- 8:0:0:1 sdc 8:32 active ready running
# sudo apt install multipath-tools=0.8.8-1ubuntu1.22.04.2~jammy5
# dpkg -l multipath-tools | awk '/^ii/ {print $3}'
0.8.8-1ubuntu1.22.04.2~jammy5
# multipath -ll
mpatha (360000000000000000e00000000010001) dm-0 IET,VIRTUAL-DISK
size=100M features='0' hwhandler='0' wp=rw
|-+- policy='service-time 0' prio=1 status=active
| `- 9:0:0:1 sdd 8:48 active ready running
|-+- policy='service-time 0' prio=1 status=enabled
| `- 6:0:0:1 sda 8:0 active ready running
|-+- policy='service-time 0' prio=1 status=enabled
| `- 7:0:0:1 sdb 8:16 active ready running
`-+- policy='service-time 0' prio=1 status=enabled
`- 8:0:0:1 sdc 8:32 active ready running
[Where things can go wrong]
- The applied patch is relatively small and handles different command ordering. A potential issue I foresee is other occurences of a mismatch between the libaries.
Hi Arnaud, thanks for taking the time to report this bug.
I don't have an easy way to reproduce it locally, but it seems like you have everything set up to verify and confirm the possible fix. Would you be able to test the following PPA and see if the package in it fixes the bug?
https:/
If it works, then we can proceed with the SRU process.
Thanks.