[SRU] fwbuilder crashes in Noble when trying to create almost any type of new object

[Lupe Christoph]

[ Impact ]

fwbuilder will crash immediately if the user tries to create almost any type of new object.

On Noble, even the gnome-shell will crash when fwbuilder crashes and the user will need to login again.

[ Test Plan ]

1. Open fwbuilder
2. Close the Quick Start Guide,.
3. Click on the "New Object" icon.
4. From the popup menu, click on "New Library"

If the package is not fixed then it will crash immediately.

With the fixed package, it will open the screen with the New Library editor.

[ Where problems could occur ]

It is an upstream patch and is just adding a NULL check before the pointer is actually dereferenced. There is no other change in the code. And, so the chances of a regression is very less for this change.

[ Other Info ]

Focal also has the same problem but this patch alone is not fixing the problem with Focal. It will need more changes and it appears it will need fixes in "qtbase-opensource-src".

[ Original Bug Description ]

To reproduce:
* start fwbuilder without any arguments
* click "New Object"
* click any type of object, e.g. "New Library"
* fwbuilder will segfault

Here is the stack trace:
(gdb) where
#0 0x000055555571115e in ?? ()
#1 0x000055555571cc73 in ?? ()
#2 0x0000555555720fc3 in ?? ()
#3 0x00005555559f3825 in ?? ()
#4 0x00007ffff6a49a88 in ?? () from /lib/x86_64-linux-gnu/libQt5Core.so.5
#5 0x00007ffff76a8b86 in QAction::triggered(bool) () from /lib/x86_64-linux-gnu/libQt5Widgets.so.5
#6 0x00007ffff76ab89c in QAction::activate(QAction::ActionEvent) () from /lib/x86_64-linux-gnu/libQt5Widgets.so.5
#7 0x00007ffff78355d2 in ?? () from /lib/x86_64-linux-gnu/libQt5Widgets.so.5
#8 0x00007ffff783d199 in ?? () from /lib/x86_64-linux-gnu/libQt5Widgets.so.5
#9 0x00007ffff76f217e in QWidget::event(QEvent*) () from /lib/x86_64-linux-gnu/libQt5Widgets.so.5
#10 0x00007ffff76af6b3 in QApplicationPrivate::notify_helper(QObject*, QEvent*) () from /lib/x86_64-linux-gnu/libQt5Widgets.so.5
#11 0x00007ffff76b72e4 in QApplication::notify(QObject*, QEvent*) () from /lib/x86_64-linux-gnu/libQt5Widgets.so.5
#12 0x00005555559e2dfc in ?? ()
#13 0x00007ffff6a1216a in QCoreApplication::notifyInternal2(QObject*, QEvent*) () from /lib/x86_64-linux-gnu/libQt5Core.so.5
#14 0x00007ffff76b5dc7 in QApplicationPrivate::sendMouseEvent(QWidget*, QMouseEvent*, QWidget*, QWidget*, QWidget**, QPointer<QWidget>&, bool, bool) () from /lib/x86_64-linux-gnu/libQt5Widgets.so.5
#15 0x00007ffff770c4b3 in ?? () from /lib/x86_64-linux-gnu/libQt5Widgets.so.5
#16 0x00007ffff770ec45 in ?? () from /lib/x86_64-linux-gnu/libQt5Widgets.so.5
#17 0x00007ffff76af6b3 in QApplicationPrivate::notify_helper(QObject*, QEvent*) () from /lib/x86_64-linux-gnu/libQt5Widgets.so.5
#18 0x00005555559e2dfc in ?? ()
#19 0x00007ffff6a1216a in QCoreApplication::notifyInternal2(QObject*, QEvent*) () from /lib/x86_64-linux-gnu/libQt5Core.so.5
#20 0x00007ffff6fa8257 in QGuiApplicationPrivate::processMouseEvent(QWindowSystemInterfacePrivate::MouseEvent*) () from /lib/x86_64-linux-gnu/libQt5Gui.so.5
#21 0x00007ffff6f7d9bc in QWindowSystemInterface::sendWindowSystemEvents(QFlags<QEventLoop::ProcessEventsFlag>) () from /lib/x86_64-linux-gnu/libQt5Gui.so.5
#22 0x00007ffff2d64b9e in ?? () from /lib/x86_64-linux-gnu/libQt5XcbQpa.so.5
#23 0x00007ffff55258bb in g_main_context_dispatch () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#24 0x00007ffff5578f08 in ?? () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#25 0x00007ffff5523003 in g_main_context_iteration () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#26 0x00007ffff6a6b548 in QEventDispatcherGlib::processEvents(QFlags<QEventLoop::ProcessEventsFlag>) () from /lib/x86_64-linux-gnu/libQt5Core.so.5
#27 0x00007ffff6a10a9b in QEventLoop::exec(QFlags<QEventLoop::ProcessEventsFlag>) () from /lib/x86_64-linux-gnu/libQt5Core.so.5
#28 0x00007ffff6a19024 in QCoreApplication::exec() () from /lib/x86_64-linux-gnu/libQt5Core.so.5
#29 0x00005555556744cf in ?? ()
#30 0x00007ffff6324fd0 in __libc_start_call_main (main=main@entry=0x5555556736d3, argc=argc@entry=1, argv=argv@entry=0x7fffffffdd08) at ../sysdeps/nptl/libc_start_call_main.h:58
#31 0x00007ffff632507d in __libc_start_main_impl (main=0x5555556736d3, argc=1, argv=0x7fffffffdd08, init=<optimized out>, fini=<optimized out>, rtld_fini=<optimized out>, stack_end=0x7fffffffdcf8) at ../csu/libc-start.c:409
#32 0x00005555556735de in ?? ()

Details:
Package version: 5.3.7-4.1build2
OS: VERSION="21.10 (Impish Indri)"

[Sudip Mukherjee (sudipmuk)]

I can reproduce the error on Focal, Jammy and Mantic. Could not test on Noble as its uninstallable until time_t transition is over.

[Sudip Mukherjee (sudipmuk)]

tested and confirmed that it affects Noble also.

[Sudip Mukherjee (sudipmuk)]

debdiff attached for Noble.

[Sudip Mukherjee (sudipmuk)]

Adding modified debdiff for Noble.

[Sudip Mukherjee (sudipmuk)]

debdiff for Mantic.

[Sudip Mukherjee (sudipmuk)]

debdiff for Jammy.

[Sudip Mukherjee (sudipmuk)]

adding modified Noble debdiff with modified version.

[Sudip Mukherjee (sudipmuk)]

Debdiff for Oracular

[Dave Jones (waveform)]

Confirmed on an oracular desktop VM with the current release (5.3.7-8). Patch needed a quick rebase against that current version (and update-maintainer running, but that may be because the current release has no Ubuntu changes). Anyway, sponsoring for oracular, and adding noble to the targetting.

[Dave Jones (waveform)]

Leaving ubuntu-sponsors subscribed for the SRU uploads

[Launchpad Janitor (janitor)]

This bug was fixed in the package fwbuilder - 5.3.7-8ubuntu1

---------------
fwbuilder (5.3.7-8ubuntu1) oracular; urgency=medium

  * Add upstream commit to fix crash creating new object. (LP: #1957168)

 -- Sudip Mukherjee <email address hidden> Tue, 30 Apr 2024 20:33:47 +0100

[Lukas Märdian (slyon)]

Thanks, the Noble patch matches upstream and looks good to me.

Sponsored, with a modified version string, initially. But you were actually right, as we have the same revision in multiple Ubuntu series, so I re-uploaded with your proposed version string.

https://launchpad.net/ubuntu/noble/+queue?queue_state=1&queue_text=fwbuilder

[Lukas Märdian (slyon)]

Sponsored Mantic, too: https://launchpad.net/ubuntu/mantic/+queue?queue_state=1&queue_text=fwbuilder
And Jammy, as well https://launchpad.net/ubuntu/jammy/+queue?queue_state=1&queue_text=fwbuilder

[Lukas Märdian (slyon)]

I'll unsubscribe ~ubuntu-sponsors for now. Feel free to re-subscribe once a debdiff for Focal is prepared ad well.

[Timo Aaltonen (tjaalton)]

Hello Lupe, or anyone else affected,

Accepted fwbuilder into noble-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/fwbuilder/5.3.7-5ubuntu0.24.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-noble to verification-done-noble. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-noble. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Timo Aaltonen (tjaalton)]

Hello Lupe, or anyone else affected,

Accepted fwbuilder into mantic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/fwbuilder/5.3.7-5ubuntu0.23.10.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-mantic to verification-done-mantic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-mantic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Timo Aaltonen (tjaalton)]

Hello Lupe, or anyone else affected,

Accepted fwbuilder into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/fwbuilder/5.3.7-5ubuntu0.22.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Lupe Christoph (lupe)]

All my Ubuntu hosts are on 23.10, because two of them are affected by a bug in ubuntu-release-upgrader, #2067071. That bug has supposedly been fixed in 24.04. So before I upgrade to that, I've tested the new fwbuilder, and I can confirm that the problem does not occur. That's no really surprising given that it's a one line fix adding a NULL check. Thanks for making the effort to guide this one line all the way through to a proposed update in four releases!

I'll test again when my main machine is on 24.04.

[Sudip Mukherjee (sudipmuk)]

I can confirm that fwbuilder from noble-proposed has fixed the bug for me.

Test done:

installed fwbuilder and followed the testplan to verify the error is still seen.

Added noble-proposed to apt sources.
install fwbuilder from noble-proposed.

followed the testplan to verify the error is not seen.

Package tested:

$ apt-cache policy fwbuilder
fwbuilder:
  Installed: 5.3.7-5ubuntu0.24.04.1
  Candidate: 5.3.7-5ubuntu0.24.04.1
  Version table:
 *** 5.3.7-5ubuntu0.24.04.1 100
        100 http://gb.archive.ubuntu.com/ubuntu noble-proposed/universe amd64 Packages
        100 /var/lib/dpkg/status
     5.3.7-5build3 500
        500 http://gb.archive.ubuntu.com/ubuntu noble/universe amd64 Packages

[Sudip Mukherjee (sudipmuk)]

I can confirm that fwbuilder from mantic-proposed has fixed the bug for me.

Test done:

installed fwbuilder and followed the testplan to verify the error is still seen.

Added mantic-proposed to apt sources.
install fwbuilder from mantic-proposed.

followed the testplan to verify the error is not seen.

Package tested:

$ apt-cache policy fwbuilder
fwbuilder:
  Installed: 5.3.7-5ubuntu0.23.10.1
  Candidate: 5.3.7-5ubuntu0.23.10.1
  Version table:
 *** 5.3.7-5ubuntu0.23.10.1 100
        100 http://us.archive.ubuntu.com/ubuntu mantic-proposed/universe amd64 Packages
        100 /var/lib/dpkg/status
     5.3.7-5 500
        500 http://us.archive.ubuntu.com/ubuntu mantic/universe amd64 Packages

[Sudip Mukherjee (sudipmuk)]

I can confirm that fwbuilder from jammy-proposed has fixed the bug for me.

Test done:

installed fwbuilder and followed the testplan to verify the error is still seen.

Added jammy-proposed to apt sources.
install fwbuilder from jammy-proposed.

followed the testplan to verify the error is not seen.

Package tested:

$ apt-cache policy fwbuilder
fwbuilder:
  Installed: 5.3.7-5ubuntu0.22.04.1
  Candidate: 5.3.7-5ubuntu0.22.04.1
  Version table:
 *** 5.3.7-5ubuntu0.22.04.1 500
        500 http://gb.archive.ubuntu.com/ubuntu jammy-proposed/universe amd64 Packages
        100 /var/lib/dpkg/status
     5.3.7-5 500
        500 http://gb.archive.ubuntu.com/ubuntu jammy/universe amd64 Packages

[Launchpad Janitor (janitor)]

This bug was fixed in the package fwbuilder - 5.3.7-5ubuntu0.24.04.1

---------------
fwbuilder (5.3.7-5ubuntu0.24.04.1) noble; urgency=medium

  * Add upstream commit to fix crash creating new object. (LP: #1957168)

 -- Sudip Mukherjee <email address hidden> Tue, 30 Apr 2024 20:33:47 +0100

[Andreas Hasenack (ahasenack)]

The verification of the Stable Release Update for fwbuilder has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[Launchpad Janitor (janitor)]

This bug was fixed in the package fwbuilder - 5.3.7-5ubuntu0.23.10.1

---------------
fwbuilder (5.3.7-5ubuntu0.23.10.1) mantic; urgency=medium

  * Add upstream commit to fix crash creating new object. (LP: #1957168)

 -- Sudip Mukherjee <email address hidden> Tue, 23 Apr 2024 20:56:36 +0100

[Launchpad Janitor (janitor)]

This bug was fixed in the package fwbuilder - 5.3.7-5ubuntu0.22.04.1

---------------
fwbuilder (5.3.7-5ubuntu0.22.04.1) jammy; urgency=medium

  * Add upstream commit to fix crash creating new object. (LP: #1957168)

 -- Sudip Mukherjee <email address hidden> Tue, 23 Apr 2024 21:24:12 +0100