rootstock: bashism introduced in bzr revision 94

Bug #575854 reported by Robert Nelson
38
This bug affects 6 people
Affects Status Importance Assigned to Milestone
RootStock
Fix Released
High
Ricardo Salveti
rootstock (Ubuntu)
Fix Released
Undecided
Unassigned
Declined for Maverick by Stefano Rivera
Lucid
Won't Fix
Undecided
Unassigned

Bug Description

I: First stage install done
I: Downloading kernel image (deb) from external site
I: linux-image-2.6.32.11-l13_1.0lucid_armel.deb download complete
rootstock: 792: Bad substitution

Bashism: KERNEL_IMG_REL=${KERNEL_IMG_REL/_*_armel.deb}

Replace with: KERNEL_IMG_REL=${KERNEL_IMG_REL%%_*}

=== modified file 'rootstock'
--- rootstock 2010-04-15 21:57:01 +0000
+++ rootstock 2010-05-05 14:32:36 +0000
@@ -378,7 +378,7 @@
     KERNEL_IMAGE_CMD="dpkg -x /tmp/$KERNEL_IMG /"

     KERNEL_IMG_REL=${KERNEL_IMG##*linux-image-}
- KERNEL_IMG_REL=${KERNEL_IMG_REL/_*_armel.deb}
+ KERNEL_IMG_REL=${KERNEL_IMG_REL%%_*}

     KERNEL_IMAGE_CREATE_INITRAMFS="update-initramfs -c -k $KERNEL_IMG_REL"
 }

After:

I: Downloading kernel image (deb) from external site
I: linux-image-2.6.32.11-l13_1.0lucid_armel.deb download complete
I: Setting up serial tty in image

and it's generating the /boot/initrd.img:

ldconfig deferred processing now taking place
update-initramfs: Generating /boot/initrd.img-2.6.32.11-l13

Related branches

Revision history for this message
Robert Nelson (robertcnelson) wrote :
Changed in rootstock (Ubuntu):
status: New → Confirmed
Revision history for this message
Daniel J Blueman (danielblueman) wrote :
Revision history for this message
Daniel J Blueman (danielblueman) wrote :

For Ubuntu 10.04 LTS, I can provide an SRU justification for anyone sponsoring this - just let me know.
Thanks, Daniel

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package rootstock - 0.1.99.3-0ubuntu2

---------------
rootstock (0.1.99.3-0ubuntu2) maverick; urgency=low

  * integrate "bad substitution" fix for BASHism from Robert Nelson
    (LP: #575854)
 -- Daniel J Blueman <email address hidden> Fri, 09 Jul 2010 17:09:57 +0100

Changed in rootstock (Ubuntu):
status: Confirmed → Fix Released
Revision history for this message
Stefano Rivera (stefanor) wrote :

Daniel: your bug closing syntax wasn't quite right, but corrected and uploaded.

Changed in rootstock (Ubuntu):
status: Fix Released → Fix Committed
status: Fix Committed → Fix Released
Changed in project-rootstock:
assignee: nobody → Ricardo Salveti (rsalveti)
status: New → Confirmed
Changed in project-rootstock:
status: Confirmed → In Progress
Revision history for this message
Ricardo Salveti (rsalveti) wrote :

Fixed on revision 104.

Changed in project-rootstock:
status: In Progress → Fix Committed
importance: Undecided → High
Changed in project-rootstock:
milestone: none → 0.1.99.4
status: Fix Committed → Fix Released
Revision history for this message
Rolf Leggewie (r0lf) wrote :

lucid has seen the end of its life and is no longer receiving any updates. Marking the lucid task for this ticket as "Won't Fix".

Changed in rootstock (Ubuntu Lucid):
status: New → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.